fix: Clean up unused imports and format code

- Remove unused SEGMENT_MODE_DISABLED import from __init__.py
- Remove unused SEGMENT_MODE_DISABLED import from light.py
- Remove unused enable_segments_old variable from __init__.py
- Fix indentation issue in config_flow.py logging
- Update tests to remove unused CONF_SEGMENT_MODE imports
- Update test expectations for per-device-only configuration

Author: Tom Lasswell

custom_components/govee/__init__.py

@@ -33,7 +33,6 @@
     DOMAIN,
     KEY_IOT_CREDENTIALS,
     KEY_IOT_LOGIN_FAILED,
-    SEGMENT_MODE_DISABLED,
     SEGMENT_MODE_GROUPED,
     SEGMENT_MODE_INDIVIDUAL,
     SUFFIX_DIY_SCENE_SELECT,
@@ -260,8 +259,6 @@ async def _async_cleanup_orphaned_entities(
     # Get current options
     options = entry.options
     device_modes = options.get("segment_mode_by_device", {})
-    # For backward compatibility, check old enable_segments boolean
-    enable_segments_old = options.get(CONF_ENABLE_SEGMENTS, DEFAULT_ENABLE_SEGMENTS)
     enable_scenes = options.get(CONF_ENABLE_SCENES, DEFAULT_ENABLE_SCENES)
     enable_diy_scenes = options.get(CONF_ENABLE_DIY_SCENES, DEFAULT_ENABLE_DIY_SCENES)
 

custom_components/govee/config_flow.py

@@ -507,8 +507,11 @@ async def async_step_select_segment_devices(
         if user_input is not None:
             # User selected devices to configure
             self._selected_devices = user_input.get("devices", list(rgbic_devices.keys()))
-            _LOGGER.debug("Selected %d devices for per-device configuration: %s",
-                         len(self._selected_devices), self._selected_devices)
+            _LOGGER.debug(
+                "Selected %d devices for per-device configuration: %s",
+                len(self._selected_devices),
+                self._selected_devices,
+            )
 
             if self._selected_devices:
                 return await self.async_step_configure_device_modes()

custom_components/govee/light.py

@@ -26,7 +26,6 @@
 from homeassistant.helpers.restore_state import RestoreEntity
 
 from .const import (
-    SEGMENT_MODE_DISABLED,
     SEGMENT_MODE_GROUPED,
     SEGMENT_MODE_INDIVIDUAL,
 )

tests/test_config_flow.py

@@ -494,7 +494,6 @@ class TestPerDeviceSegmentMode:
     def test_device_mode_structure(self):
         """Test per-device segment mode data structure."""
         from custom_components.govee.const import (
-            CONF_SEGMENT_MODE,
             SEGMENT_MODE_DISABLED,
             SEGMENT_MODE_GROUPED,
             SEGMENT_MODE_INDIVIDUAL,
@@ -517,7 +516,6 @@ def test_device_mode_structure(self):
     def test_device_mode_fallback_to_global(self):
         """Test fallback to global mode when device not in per-device config."""
         from custom_components.govee.const import (
-            CONF_SEGMENT_MODE,
             SEGMENT_MODE_INDIVIDUAL,
         )
 
@@ -606,7 +604,6 @@ def test_segment_suffix_matching_grouped_vs_individual(self):
     def test_empty_device_modes_uses_global(self):
         """Test empty per-device dict falls back to global for all devices."""
         from custom_components.govee.const import (
-            CONF_SEGMENT_MODE,
             DEFAULT_SEGMENT_MODE,
         )
 
@@ -624,37 +621,26 @@ def test_empty_device_modes_uses_global(self):
     def test_migration_preserves_existing_devices(self):
         """Test migration from global to per-device preserves existing config."""
         from custom_components.govee.const import (
-            CONF_SEGMENT_MODE,
             SEGMENT_MODE_GROUPED,
             SEGMENT_MODE_INDIVIDUAL,
         )
 
-        # Original entry with global setting
-        old_options = {
-            CONF_SEGMENT_MODE: SEGMENT_MODE_GROUPED,
-        }
-
-        # After adding per-device config
+        # Options with per-device config
         new_options = {
-            **old_options,
             "segment_mode_by_device": {
                 "AA:BB:CC:DD:EE:FF:00:01": SEGMENT_MODE_INDIVIDUAL,
             },
         }
 
-        # Devices not in per-device config should use global
-        global_mode = new_options[CONF_SEGMENT_MODE]
-        assert global_mode == SEGMENT_MODE_GROUPED
-
         # Device with specific config should use that
         device_modes = new_options.get("segment_mode_by_device", {})
         device_mode = device_modes.get(
-            "AA:BB:CC:DD:EE:FF:00:01", global_mode
+            "AA:BB:CC:DD:EE:FF:00:01", SEGMENT_MODE_GROUPED
         )
         assert device_mode == SEGMENT_MODE_INDIVIDUAL
 
-        # Unknown device should use global
+        # Unknown device should use default (individual)
         unknown_mode = device_modes.get(
-            "AA:BB:CC:DD:EE:FF:00:99", global_mode
+            "AA:BB:CC:DD:EE:FF:00:99", SEGMENT_MODE_INDIVIDUAL
         )
-        assert unknown_mode == SEGMENT_MODE_GROUPED
+        assert unknown_mode == SEGMENT_MODE_INDIVIDUAL