You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
do not allow unsupported server URLs as arguments (#423)
### TL;DR
Improved app identifier handling by removing URL support and enforcing proper ID formats.
### What changed?
- Modified `parse_app_identifier()` to only accept proper app IDs (`app_...`) or app configuration IDs (`apcnf_...`), removing URL support
- Updated the function to return a tuple of just `(app_id, config_id)` instead of including server URL
- Added proper error handling with descriptive error messages when invalid identifiers are provided
- Updated help text in CLI commands to reflect the new identifier requirements
- Removed server URL parameters from internal functions that no longer need them
- Updated example commands to use proper app IDs instead of URLs
### How to test?
1. Try using the logger tail command with proper app IDs:
```
mcp-agent cloud logger tail app_abc123
mcp-agent cloud logger tail apcnf_xyz789
```
2. Verify that using URLs now fails with a clear error message:
```
mcp-agent cloud logger tail https://app.mcpac.dev/abc123
```
3. Test server commands with proper IDs:
```
mcp-agent cloud servers describe app_abc123
mcp-agent cloud servers delete apcnf_xyz789
```
### Why make this change?
This change standardizes how we identify apps and configurations throughout the CLI, making the interface more consistent and reducing confusion. By enforcing proper ID formats and providing clear error messages, users will better understand what identifiers are expected. Removing URL support simplifies the codebase and creates a more predictable user experience.
0 commit comments