Skip to content

Commit 584ec61

Browse files
fix: restore NotificationToggle component to SettingsPanel
Restores the NotificationToggle component that was incorrectly removed in commit 504f97c. Without this component, users cannot enable/disable notifications via the UI, causing notifications to fail even when browser permissions are granted. Root cause: The component was removed as "unused" but is actually essential for controlling the notificationStore.enabled flag that gates notification display on timer completion. Changes: - Add NotificationToggle import to SettingsPanel - Place NotificationToggle at the top of settings options for visibility Verified: - Build successful (TypeScript, ESLint) - UI tested on desktop (1280x720), tablet (768x1024), mobile (375x667) - All breakpoints render correctly with proper touch targets This fix enables users to control notifications through the settings panel.
1 parent dd1ab45 commit 584ec61

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

components/settings/SettingsPanel.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { useSettingsStore } from '@/lib/stores/settingsStore'
77
import useStore from '@/lib/hooks/useStore'
88
import { SoundSelector } from './SoundSelector'
99
import { VolumeControl } from './VolumeControl'
10+
import { NotificationToggle } from './NotificationToggle'
1011

1112
interface SettingsPanelProps {
1213
isOpen: boolean
@@ -44,6 +45,7 @@ export function SettingsPanel({ isOpen, onClose }: SettingsPanelProps) {
4445
{/* Settings Content - Scrollable */}
4546
<div className="flex-1 overflow-y-auto px-6">
4647
<div className="space-y-6">
48+
<NotificationToggle />
4749
<SoundSelector value={soundPreset} onChange={setSoundPreset} />
4850
<VolumeControl value={volume} onChange={setVolume} />
4951
</div>

0 commit comments

Comments
 (0)