Commit 6382a5f
committed
fix: resolve GitHub Actions failures in lint and E2E mobile workflows
Fixes two ESLint warnings that were causing lint workflow to fail:
- app/[locale]/page.tsx: Move tick() call inside useEffect to avoid unstable dependency
- ServiceWorkerRegistration.tsx: Move setPermission inside useEffect to avoid unstable dependency
Fixes E2E mobile test viewport issue:
- SoundSelector.tsx: Change dropdown from fixed h-64 to responsive max-h-48 md:max-h-64
to ensure preview buttons are within viewport on mobile devices
All changes verified locally:
- pnpm lint: passes with --max-warnings=0
- pnpm build: successful production build1 parent bb5801d commit 6382a5f
File tree
3 files changed
+8
-8
lines changed- app/[locale]
- components
- notifications
- settings
3 files changed
+8
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
38 | 36 | | |
39 | 37 | | |
40 | 38 | | |
| |||
59 | 57 | | |
60 | 58 | | |
61 | 59 | | |
62 | | - | |
| 60 | + | |
63 | 61 | | |
64 | 62 | | |
65 | | - | |
| 63 | + | |
66 | 64 | | |
67 | 65 | | |
68 | 66 | | |
69 | | - | |
| 67 | + | |
70 | 68 | | |
71 | 69 | | |
72 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
| |||
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
43 | | - | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| |||
0 commit comments