Issues with lld 18 on FreeBSD

[hdholm]

In https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277905 a patch is proposed to remove the check for the --version-script link flag in lib/meson.build because it's breaking the new lld version. That patch seems to have no adverse affect on the Linux and FreeBSD builds, but it looks like it fails on OSX. e.g., https://github.com/hdholm/jose/actions/runs/8402521186/job/23011995537 and I could easily be missing something about which symbols are getting exported. I'm frankly a little out of my depth here. Of course the FreeBSD build could just patch that check out (which is almost certain to happen in the short term) but, of course, I'd rather see a more proper fix here. It's tempting to submit a PR to add host_machine.system() == 'freebsd' logic to the check and be done with it, or the inverse and simply check for OSX. But I feel like there's likely a better meson fix for this that actually accounts for the linker difference. I'm happy to write the PR, if someone can give me insight into the "right" answer here.

[sarroutbi]

Hello @hdholm. IMHO, I see no issue on doing this configuration conditional to freebsd, as it is done in meson.build for license, for example.

Ideally, this should be fixed by using an option that is available in all architectures, but, as OSX is being used on its latest version, and it fails, I don't see a cleaner way of proceeding.

Please, go ahead on creating the PR and, if we figure out another solution, we can proceed with it later.

[xbeaudouin]

Hello there,
I am FreeBSD port commiter and we had some report the condition you made on jose14 has some issues back on FreeBSD 13.5 and 14.x branch.
See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284417
The fix proposed on this PR will be pushed, see https://reviews.freebsd.org/D49871, but it should be nice we can find a better fix other that comment a random configuration line in the build script.

Kind regards,
Xavier

[hdholm]

I did see the bug report on the FreeBSD side, and it is unfortunate that it's sat for far too long. Between some hardware updates making my FreeBSD build machine temporarily unavailable and an incredible number of demands on my time lately I haven't been able to look at it. I'm hoping that some time will free up in May to get back ahead of things like this.

[xbeaudouin]

If you need I try some of your code, I have a bunch of freebsd machines on my hands...