added comment, do not set rls if admin context

Author: geclos

packages/platform/db-postgres/src/client.ts

@@ -53,16 +53,6 @@ export const closePostgres = async (pool: Pool): Promise<void> => {
   await pool.end()
 }
 
-/**
- * Check if a database operator is a transaction database.
- *
- * @param db The database operator to check
- * @returns True if the database is a transaction database, false otherwise
- */
-export const isTransactionDb = (db: Operator): boolean => transactionDbs.has(db as object)
-
-const transactionDbs = new WeakSet<object>()
-
 const parsePostgresPoolConfig = (config: PostgresConfig = {}) =>
   Effect.all({
     connectionString: config.databaseUrl ? Effect.succeed(config.databaseUrl) : parseEnv("LAT_DATABASE_URL", "string"),
@@ -77,11 +67,7 @@ const parsePostgresPoolConfig = (config: PostgresConfig = {}) =>
 
 const buildPostgresClient = (pool: Pool): PostgresClient => {
   const db = drizzle({ client: pool })
-  const transaction = <T>(fn: (tx: TransactionDb) => Promise<T>): Promise<T> =>
-    db.transaction(async (tx) => {
-      transactionDbs.add(tx)
-      return fn(tx)
-    })
+  const transaction = <T>(fn: (tx: TransactionDb) => Promise<T>): Promise<T> => db.transaction(async (tx) => fn(tx))
 
   return { db, pool, transaction }
 }

packages/platform/db-postgres/src/index.ts

@@ -3,7 +3,6 @@ export {
   closePostgres,
   createPostgresClient,
   createPostgresPool,
-  isTransactionDb,
 } from "./client.ts"
 
 export { InvalidEnvValueError, MissingEnvValueError } from "@platform/env"

packages/platform/db-postgres/src/sql-client.ts

@@ -15,7 +15,18 @@ import type { Operator, PostgresClient } from "./client.ts"
  * The inner effect runs in the parent fiber (via `Effect.exit`) so all
  * provided services (repositories, etc.) remain available inside the
  * transaction scope.
+ *
+ * **Concurrent transactions**: do NOT run two `transaction()` calls
+ * concurrently on the same SqlClient instance (e.g. via `Effect.all` with
+ * concurrency > 1). `activeTx` has no fiber identity, so concurrent
+ * transactions will overwrite each other's operator and corrupt both
+ * connections. Use separate `SqlClientLive` layer instances instead.
  */
+const setRlsContext = (tx: Operator, organizationId: OrganizationId) => {
+  if (organizationId === "system") return Promise.resolve()
+  return tx.execute(sql`select set_config('app.current_organization_id', ${organizationId}, true)`)
+}
+
 export const SqlClientLive = (client: PostgresClient, organizationId: OrganizationId = OrganizationId("system")) =>
   Layer.effect(
     SqlClient,
@@ -42,7 +53,7 @@ export const SqlClientLive = (client: PostgresClient, organizationId: Organizati
             })
 
             const txPromise = client.transaction(async (tx) => {
-              await tx.execute(sql`select set_config('app.current_organization_id', ${organizationId}, true)`)
+              await setRlsContext(tx as Operator, organizationId)
               resolveTxReady(tx as Operator)
               const result = await effectDone
               if (!result.ok) throw result.error
@@ -89,7 +100,7 @@ export const SqlClientLive = (client: PostgresClient, organizationId: Organizati
             return yield* Effect.tryPromise({
               try: () =>
                 client.transaction(async (tx) => {
-                  await tx.execute(sql`select set_config('app.current_organization_id', ${organizationId}, true)`)
+                  await setRlsContext(tx as Operator, organizationId)
                   return fn(tx as Operator, organizationId)
                 }),
               catch: (error) => toRepositoryError(error, "query"),