Skip to content

Place a query fingerprint in a comment at the start of each queryΒ #4099

@grahamc

Description

@grahamc

I have found these related issues/pull requests

I don't see any related issues or pull requests.

Description

I'm finding that various DB performance tools don't show me the whole query. In particular, this is true for RDS. This makes it hard to identify which query is slow. To help this, we've manually injected a uuid in a comment on all queries:

sqlx::query_scalar!(
                r#"
                -- 935300b8-3def-431f-8480-8ae8e034fb0a
                SELECT
                    customer.name
...

This seems fine in the sense that it solves the problem, but the diff to apply it was hefty and tedious (+4,261 -3,752).

Prefered solution

Instead, I'd love for sqlx to automatically inject an identifying hash (for example, the hash of the query string) as a comment prefix. This would let us search .sqlx/query-*.json for the matching hash and conclusively identify the query.

Is this a breaking change? Why or why not?

It will cause all the pregenerated / stored .json query documents to change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions