feat: rename test function for EFS file system and enhance lifecycle policy documentation

Author: jaxom-widby-nttd

README.md

@@ -550,7 +550,7 @@ No modules.
 | <a name="input_performance_mode"></a> [performance\_mode](#input\_performance\_mode) | The file system performance mode. Valid values: 'generalPurpose' (default, lower latency for most workloads) or 'maxIO' (higher aggregate throughput for highly parallelized workloads) | `string` | `"generalPurpose"` | no |
 | <a name="input_throughput_mode"></a> [throughput\_mode](#input\_throughput\_mode) | Throughput mode for the file system. Valid values: 'bursting' (scales with file system size), 'elastic' (automatically scales based on workload), or 'provisioned' (fixed throughput - requires provisioned\_throughput\_in\_mibps to be set) | `string` | `"bursting"` | no |
 | <a name="input_provisioned_throughput_in_mibps"></a> [provisioned\_throughput\_in\_mibps](#input\_provisioned\_throughput\_in\_mibps) | The throughput, measured in MiB/s, that you want to provision for the file system. Only applicable when throughput\_mode is set to 'provisioned' | `number` | `null` | no |
-| <a name="input_lifecycle_policy"></a> [lifecycle\_policy](#input\_lifecycle\_policy) | Lifecycle policy for the file system. Supports transition\_to\_ia (AFTER\_7\_DAYS, AFTER\_14\_DAYS, AFTER\_30\_DAYS, AFTER\_60\_DAYS, AFTER\_90\_DAYS, AFTER\_1\_DAY, AFTER\_180\_DAYS, AFTER\_270\_DAYS, AFTER\_365\_DAYS), transition\_to\_primary\_storage\_class (AFTER\_1\_ACCESS), and transition\_to\_archive (AFTER\_1\_DAY, AFTER\_7\_DAYS, AFTER\_14\_DAYS, AFTER\_30\_DAYS, AFTER\_60\_DAYS, AFTER\_90\_DAYS, AFTER\_180\_DAYS, AFTER\_270\_DAYS, AFTER\_365\_DAYS) | <pre>object({<br/>    transition_to_ia                    = optional(string)<br/>    transition_to_primary_storage_class = optional(string)<br/>    transition_to_archive               = optional(string)<br/>  })</pre> | `null` | no |
+| <a name="input_lifecycle_policy"></a> [lifecycle\_policy](#input\_lifecycle\_policy) | Lifecycle policy for the file system. | <pre>object({<br/>    transition_to_ia                    = optional(string)<br/>    transition_to_primary_storage_class = optional(string)<br/>    transition_to_archive               = optional(string)<br/>  })</pre> | `null` | no |
 | <a name="input_protection"></a> [protection](#input\_protection) | Protection configuration for the file system. Supports replication\_overwrite (ENABLED, DISABLED, REPLICATING) | <pre>object({<br/>    replication_overwrite = optional(string)<br/>  })</pre> | `null` | no |
 | <a name="input_tags"></a> [tags](#input\_tags) | A map of tags to assign to the EFS file system | `map(string)` | `{}` | no |
 

tests/post_deploy_functional_readonly/main_test.go

@@ -25,7 +25,7 @@ const (
 	infraTFVarFileNameDefault        = "test.tfvars"
 )
 
-func TestLambdaLayerModule(t *testing.T) {
+func TestEFSFileSystemModule(t *testing.T) {
 
 	ctx := types.CreateTestContextBuilder().
 		SetTestConfig(&testimpl.ThisTFModuleConfig{}).

tests/testimpl/test_impl.go

@@ -78,7 +78,8 @@ func testFileSystemArn(t *testing.T, awsFileSystem *types.FileSystemDescription,
 	assert.NotEmpty(t, fileSystemArn, "File system ARN should not be empty")
 
 	// Verify it's a valid ARN format
-	matched, _ := regexp.MatchString(`^arn:aws:elasticfilesystem:`, fileSystemArn)
+	matched, err := regexp.MatchString(`^arn:aws:elasticfilesystem:`, fileSystemArn)
+	require.NoError(t, err, "Regex match for ARN failed")
 	assert.True(t, matched, "ARN should start with 'arn:aws:elasticfilesystem:'")
 }
 

variables.tf

@@ -60,8 +60,32 @@ variable "provisioned_throughput_in_mibps" {
   default     = null
 }
 
+# Lifecycle policy for the file system.
+# Supported values:
+#   transition_to_ia:
+#     - AFTER_1_DAY
+#     - AFTER_7_DAYS
+#     - AFTER_14_DAYS
+#     - AFTER_30_DAYS
+#     - AFTER_60_DAYS
+#     - AFTER_90_DAYS
+#     - AFTER_180_DAYS
+#     - AFTER_270_DAYS
+#     - AFTER_365_DAYS
+#   transition_to_primary_storage_class:
+#     - AFTER_1_ACCESS
+#   transition_to_archive:
+#     - AFTER_1_DAY
+#     - AFTER_7_DAYS
+#     - AFTER_14_DAYS
+#     - AFTER_30_DAYS
+#     - AFTER_60_DAYS
+#     - AFTER_90_DAYS
+#     - AFTER_180_DAYS
+#     - AFTER_270_DAYS
+#     - AFTER_365_DAYS
 variable "lifecycle_policy" {
-  description = "Lifecycle policy for the file system. Supports transition_to_ia (AFTER_7_DAYS, AFTER_14_DAYS, AFTER_30_DAYS, AFTER_60_DAYS, AFTER_90_DAYS, AFTER_1_DAY, AFTER_180_DAYS, AFTER_270_DAYS, AFTER_365_DAYS), transition_to_primary_storage_class (AFTER_1_ACCESS), and transition_to_archive (AFTER_1_DAY, AFTER_7_DAYS, AFTER_14_DAYS, AFTER_30_DAYS, AFTER_60_DAYS, AFTER_90_DAYS, AFTER_180_DAYS, AFTER_270_DAYS, AFTER_365_DAYS)"
+  description = "Lifecycle policy for the file system."
   type = object({
     transition_to_ia                    = optional(string)
     transition_to_primary_storage_class = optional(string)