Skip to content

Commit 4277eab

Browse files
feat: Update EFS examples to prioritize variable inputs over generated names and correct tflint.hcl file in root
1 parent 029b7d0 commit 4277eab

File tree

3 files changed

+11
-20
lines changed

3 files changed

+11
-20
lines changed

.tflint.hcl

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,4 @@
1-
config {
2-
plugin_dir = "~/.tflint.d/plugins"
3-
4-
call_module_type = "all"
5-
force = false
6-
disabled_by_default = false
7-
8-
ignore_module = {
9-
}
10-
11-
varfile = []
12-
variables = []
1+
plugin "terraform" {
2+
enabled = true
3+
preset = "recommended"
134
}

examples/complete/main.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,13 @@ module "efs_complete" {
5656
source = "../../"
5757

5858
# Unique identifier for the EFS file system within AWS account and region
59-
# Uses generated name from resource_names module if available, otherwise uses var.creation_token
60-
creation_token = try(module.resource_names["efs"].standard, var.creation_token)
59+
# Uses var.creation_token if provided, otherwise uses generated name from resource_names module
60+
creation_token = try(var.creation_token, module.resource_names["efs"].standard)
6161

6262
# Friendly name for AWS Console identification
6363
# Automatically creates a 'Name' tag
64-
# Uses generated name from resource_names module if available, otherwise uses var.name
65-
name = try(module.resource_names["efs"].standard, var.name)
64+
# Uses var.name if provided, otherwise uses generated name from resource_names module
65+
name = try(var.name, module.resource_names["efs"].standard)
6666

6767
# Optional: Specify an Availability Zone for One Zone storage class
6868
# Leave null (default) for Multi-AZ storage with high availability

examples/simple/main.tf

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,13 @@ module "efs" {
5353

5454
# Unique identifier for the EFS file system
5555
# Must be unique within your AWS account and region
56-
# Uses generated name from resource_names module if available, otherwise uses var.creation_token
57-
creation_token = try(module.resource_names["efs"].standard, var.creation_token)
56+
# Uses var.creation_token if provided, otherwise uses generated name from resource_names module
57+
creation_token = try(var.creation_token, module.resource_names["efs"].standard)
5858

5959
# Optional friendly name that appears in AWS Console
6060
# Creates a 'Name' tag automatically
61-
# Uses generated name from resource_names module if available, otherwise uses var.name
62-
name = try(module.resource_names["efs"].standard, var.name)
61+
# Uses var.name if provided, otherwise uses generated name from resource_names module
62+
name = try(var.name, module.resource_names["efs"].standard)
6363

6464
# Enable encryption at rest using AWS managed key
6565
# Set to false only if encryption is not required (not recommended)

0 commit comments

Comments
 (0)