-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Enhance EFS module with additional outputs and testing framework #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c76e3af
pre-staged stuff for Jaxom to finish
ben-vaughan-nttd 7268f63
Update workflow dependencies to version 0.11.0 for pull request label…
ben-vaughan-nttd 8b24ea0
feat: Enhance EFS module with additional outputs and testing framework
jaxom-widby-nttd 2af0ad9
chore: Remove unused locals.tf files from examples
jaxom-widby-nttd 3980b1f
feat: Update EFS example configurations and remove obsolete files
jaxom-widby-nttd d5f5ff6
feat: Implement resource naming module and update EFS configurations …
jaxom-widby-nttd 029b7d0
Fixed Symlinks
jaxom-widby-nttd 4277eab
feat: Update EFS examples to prioritize variable inputs over generate…
jaxom-widby-nttd b07f17d
feat: Enhance EFS module documentation and variable requirements for …
jaxom-widby-nttd f3a9b62
feat: Refactor EFS example configurations for standardized naming and…
jaxom-widby-nttd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # GitHub Copilot Instructions | ||
|
|
||
| ## File Editing Rules | ||
|
|
||
| - **NEVER remove license headers** from files when making edits | ||
| - Always preserve the Apache 2.0 license header at the top of all source files (`.tf`, `.go`, `.sh`, etc.) | ||
| - When editing files, include the full license header in replacements if modifying code near the top of files | ||
|
|
||
| ## Terminal Command Rules | ||
|
|
||
| - **DO NOT use timeout flags** with terminal commands (e.g., avoid `-timeout` with go test) | ||
| - Let commands run to completion naturally | ||
| - If a command needs to be stopped, the user will cancel it manually | ||
| - For long-running tests, rely on the default behavior rather than imposing artificial time limits | ||
|
|
||
| ## Terraform Best Practices | ||
|
|
||
| - Follow the module structure defined in the repository | ||
| - Maintain consistency with existing patterns | ||
| - Use dynamic blocks appropriately for optional nested configurations | ||
| - Always validate configurations with `terraform validate` before planning or applying | ||
|
|
||
| ## Testing Guidelines | ||
|
|
||
| - Write comprehensive tests that verify actual AWS resource creation | ||
| - Use the AWS SDK to verify resource properties match Terraform outputs | ||
| - Test both required and optional parameters | ||
| - Include validation for resource naming, encryption, and other critical settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| - package-ecosystem: "gomod" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" | ||
| - package-ecosystem: "terraform" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| --- | ||
| name-template: "$RESOLVED_VERSION" | ||
| tag-template: "$RESOLVED_VERSION" | ||
| template: | | ||
| # Changelog | ||
|
|
||
| $CHANGES | ||
|
|
||
| --- | ||
|
|
||
| See details of [all code changes](https://github.com/$OWNER/$REPOSITORY/compare/$PREVIOUS_TAG...$RESOLVED_VERSION) since previous release. | ||
|
|
||
| categories: | ||
| - title: ":warning: Breaking Changes" | ||
| labels: | ||
| - "major" | ||
| - title: "🚀 Features" | ||
| labels: | ||
| - "minor" | ||
| - title: "🔧 Fixes" | ||
| collapse-after: 3 | ||
| labels: | ||
| - "patch" | ||
|
|
||
| autolabeler: | ||
| - label: "major" | ||
| branch: | ||
| - '/(patch|bug|fix|feature|chore)!\/.+/' | ||
| - label: "minor" | ||
| branch: | ||
| - '/feature\/.+/' | ||
| - label: "patch" | ||
| branch: | ||
| - '/(patch|bug|fix|chore)\/.+/' | ||
|
|
||
| change-template: "- $TITLE @$AUTHOR (#$NUMBER)" | ||
|
|
||
| version-resolver: | ||
| major: | ||
| labels: | ||
| - "major" | ||
| minor: | ||
| labels: | ||
| - "minor" | ||
| patch: | ||
| labels: | ||
| - "patch" | ||
| - "dependencies" | ||
| default: patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| name: Label Pull Request | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize] | ||
|
|
||
| jobs: | ||
| check: | ||
| name: "Label Pull Request" | ||
| permissions: | ||
| contents: read | ||
| issues: write | ||
| pull-requests: write | ||
| uses: launchbynttdata/launch-workflows/.github/workflows/[email protected] | ||
| secrets: inherit # pragma: allowlist secret |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: Check AWS Terraform Code | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, reopened, synchronize, ready_for_review] | ||
| branches: [main] | ||
|
|
||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
|
|
||
| jobs: | ||
| check: | ||
| name: "Check AWS Terraform Code" | ||
| permissions: | ||
| contents: read | ||
| id-token: write | ||
| uses: launchbynttdata/launch-workflows/.github/workflows/[email protected] | ||
| with: | ||
| assume_role_arn: ${{ vars.TERRAFORM_CHECK_AWS_ASSUME_ROLE_ARN }} | ||
| region: ${{ vars.TERRAFORM_CHECK_AWS_REGION }} | ||
| secrets: inherit # pragma: allowlist secret |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Publish Release | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| release-on-merge: | ||
| name: "Create and Publish Release on Merge" | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| uses: launchbynttdata/launch-workflows/.github/workflows/[email protected] | ||
| secrets: inherit # pragma: allowlist secret |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| terraform.* | ||
| .repo/ | ||
| components/ | ||
| .semverbot.toml | ||
| vendor/ | ||
|
|
||
| .idea | ||
| !examples/*.tfvars | ||
|
|
||
| # We don't want to commit the test run lock files | ||
| .terraform.lock.hcl | ||
|
|
||
| # Don't include the .test-data directory created by Terratest's test-structure module | ||
| **/.test-data/* | ||
|
|
||
| # Local .terraform directories | ||
| **/.terraform/* | ||
|
|
||
| # Local .terragrunt directories | ||
| **/.terragrunt/* | ||
|
|
||
| # .tfstate files | ||
| *.tfstate | ||
| *.tfstate.* | ||
| *.tfplan | ||
| tfplan.* | ||
| tfplan | ||
|
|
||
| # Crash log files | ||
| crash.log | ||
| crash.*.log | ||
|
|
||
| # Exclude all .tfvars files, which are likely to contain sensitive data, such as | ||
| # password, private keys, and other secrets. These should not be part of version | ||
| # control as they are data points which are potentially sensitive and subject | ||
| # to change depending on the environment. | ||
| *.tfvars.json | ||
| *.auto.tfvars | ||
|
|
||
| # Ignore override files as they are usually used to override resources locally and so | ||
| # are not checked in | ||
| override.tf | ||
| override.tf.json | ||
| *_override.tf | ||
| *_override.tf.json | ||
| provider.tf | ||
|
|
||
| # Include override files you do wish to add to version control using negated pattern | ||
| # !example_override.tf | ||
|
|
||
| # Include tfplan files to ignore the plan output of command: terraform plan -out=tfplan | ||
| # example: *tfplan* | ||
|
|
||
| # Ignore CLI configuration files | ||
| .terraformrc | ||
| terraform.rc | ||
|
|
||
| # Files from common modules | ||
| azure_env.sh | ||
| .releaserc.json | ||
|
|
||
| # VS Code | ||
| .vscode/ | ||
| .devcontainer/ | ||
| .context/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| version: "2" | ||
| run: | ||
| # Timeout for analysis, e.g. 30s, 5m. | ||
| timeout: 5m | ||
| allow-parallel-runners: true |
jaxom-widby-nttd marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| repos: | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v4.5.0 | ||
| hooks: | ||
| - id: trailing-whitespace | ||
| - id: check-case-conflict | ||
| - id: check-executables-have-shebangs | ||
| - id: check-json | ||
| - id: check-merge-conflict | ||
| - id: check-shebang-scripts-are-executable | ||
| - id: check-yaml | ||
| args: | ||
| - --allow-multiple-documents | ||
| - id: end-of-file-fixer | ||
| - id: mixed-line-ending | ||
| args: | ||
| - --fix=auto | ||
| - repo: https://github.com/antonbabenko/pre-commit-terraform | ||
| rev: v1.99.0 | ||
| hooks: | ||
| - id: terraform_fmt | ||
| - id: terraform_validate | ||
| - id: terraform_docs | ||
| args: | ||
| - --hook-config=--path-to-file=README.md | ||
| - --hook-config=--add-to-existing-file=true | ||
| - --hook-config=--create-file-if-not-exist=true | ||
| - --args=--sort=false | ||
| - repo: https://github.com/golangci/golangci-lint | ||
| rev: v2.2.1 | ||
| hooks: | ||
| - id: golangci-lint | ||
| name: golangci-lint | ||
| description: Fast linters runner for Go. | ||
| entry: golangci-lint run --fix | ||
| types: [go] | ||
| language: golang | ||
| pass_filenames: false | ||
| - repo: https://github.com/alessandrojcm/commitlint-pre-commit-hook | ||
| rev: v9.22.0 | ||
| hooks: | ||
| - id: commitlint | ||
| stages: [commit-msg] | ||
| additional_dependencies: ["@commitlint/config-conventional"] | ||
| - repo: https://github.com/Yelp/detect-secrets | ||
| rev: v1.5.0 | ||
| hooks: | ||
| - id: detect-secrets | ||
| args: ["--baseline", ".secrets.baseline"] | ||
| exclude: package.lock.json |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.