Skip to content

Commit aff67f1

Browse files
Refactor KMS key policy to format principals and conditions for better readability
1 parent e4810ed commit aff67f1

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

examples/simple/main.tf

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ locals {
2929
]
3030
resources = ["arn:aws:kms:*:${data.aws_caller_identity.current.account_id}:key/*"]
3131
principals = {
32-
"AWS" = concat(tolist(data.aws_iam_roles.administrator_access.arns), ["arn:aws:iam::020127659860:role/github-actions-deploy-role-terraform"])
32+
"AWS" = concat(
33+
tolist(data.aws_iam_roles.administrator_access.arns),
34+
["arn:aws:iam::020127659860:role/github-actions-deploy-role-terraform"],
35+
)
3336
}
3437
}
3538
}

examples/with_condition/main.tf

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ locals {
3636
]
3737
resources = ["arn:aws:kms:*:${data.aws_caller_identity.current.account_id}:key/*"]
3838
principals = {
39-
"AWS" = concat(tolist(data.aws_iam_roles.administrator_access.arns), ["arn:aws:iam::020127659860:role/github-actions-deploy-role-terraform"])
39+
"AWS" = concat(
40+
tolist(data.aws_iam_roles.administrator_access.arns),
41+
["arn:aws:iam::020127659860:role/github-actions-deploy-role-terraform"],
42+
)
4043
}
4144
condition = [
4245
{
@@ -47,7 +50,10 @@ locals {
4750
{
4851
test = "ArnEquals"
4952
variable = "aws:PrincipalArn"
50-
values = tolist(data.aws_iam_roles.administrator_access.arns)
53+
values = concat(
54+
tolist(data.aws_iam_roles.administrator_access.arns),
55+
["arn:aws:iam::020127659860:role/github-actions-deploy-role-terraform"],
56+
)
5157
}
5258
]
5359
}

0 commit comments

Comments
 (0)