fix: ignore EBUSY windows errors when removing temporary folders in CI

Author: joelgallant

app-config-test-utils/package.json

@@ -31,6 +31,7 @@
   },
   "dependencies": {
     "@app-config/logging": "^2.4.2",
+    "@app-config/utils": "^2.4.2",
     "@types/fs-extra": "9",
     "@types/tmp": "0.2",
     "fs-extra": "9",

app-config-test-utils/src/index.ts

@@ -3,6 +3,7 @@ import { dir } from 'tmp-promise';
 import { outputFile, remove } from 'fs-extra';
 import { stdin } from 'mock-stdin';
 import { isTestEnvAndShouldNotPrompt } from '@app-config/logging';
+import { isWindows } from '@app-config/utils';
 
 // function that joins the temp dir to a filename
 type JoinDir = (filename: string) => string;
@@ -32,7 +33,14 @@ export async function withTempFiles(
 
     await callback((filename) => join(folder, filename), folder);
   } finally {
-    await remove(folder);
+    await remove(folder).catch((error) => {
+      console.warn(error);
+
+      // we'll just ignore this, it's spurious in CI
+      if (isWindows && error.code !== 'EBUSY') {
+        throw error;
+      }
+    });
   }
 }
 

app-config-test-utils/tsconfig.json

@@ -7,6 +7,7 @@
   "include": ["src"],
   "exclude": ["node_modules"],
   "references": [
-    { "path": "../app-config-logging" }
+    { "path": "../app-config-logging" },
+    { "path": "../app-config-utils" }
   ]
 }