fix: lints

Author: joelgallant

app-config-extensions/src/index.test.ts

@@ -121,10 +121,6 @@ describe('$if directive', () => {
   });
 
   it('doesnt evaluate the else branch', async () => {
-    const failDirective = forKey('$fail', () => () => {
-      throw new Error();
-    });
-
     const source = new LiteralSource({
       $if: {
         $check: true,
@@ -139,10 +135,6 @@ describe('$if directive', () => {
   });
 
   it('doesnt evaluate the other branch', async () => {
-    const failDirective = forKey('$fail', () => () => {
-      throw new Error();
-    });
-
     const source = new LiteralSource({
       $if: {
         $check: false,

app-config-extensions/src/index.ts

@@ -52,6 +52,7 @@ export function tryDirective(): ParsingExtension {
           .addProperty('$fallback', SchemaBuilder.fromJsonSchema({}))
           .addBoolean('$unsafe', {}, false),
       (value) => async (parse) => {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
         const { $value, $fallback, $unsafe } = value;
 
         try {
@@ -80,14 +81,14 @@ export function ifDirective(): ParsingExtension {
           .addProperty('$then', SchemaBuilder.fromJsonSchema({}))
           .addProperty('$else', SchemaBuilder.fromJsonSchema({})),
       (value) => async (parse) => {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
         const { $check, $then, $else } = value;
         const condition = (await parse($check)).toJSON();
 
         if (condition) {
           return parse($then, { shouldFlatten: true });
-        } else {
-          return parse($else, { shouldFlatten: true });
         }
+        return parse($else, { shouldFlatten: true });
       },
       { lazy: true },
     ),