fix: resolves all requests to config-placeholder so that $extends works

Author: joelgallant

.github/workflows/cypress.yml

@@ -67,3 +67,12 @@ jobs:
         start: yarn serve -l 8993 ./dist
       env:
         CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+    - uses: cypress-io/github-action@v2
+      with:
+        group: app-config-extending-other-files
+        working-directory: tests/webpack-projects/extending-other-files
+        install: false
+        record: true
+        start: yarn serve -l 8994 ./dist
+      env:
+        CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}

app-config-webpack/src/index.ts

@@ -60,11 +60,7 @@ export default class AppConfigPlugin {
               this.schemaLoadingOptions,
             );
 
-            if (filePaths?.length) {
-              [resolve.request] = filePaths; // eslint-disable-line no-param-reassign
-            } else {
-              resolve.request = join(__dirname, '..', '.config-placeholder'); // eslint-disable-line no-param-reassign
-            }
+            resolve.request = join(__dirname, '..', '.config-placeholder'); // eslint-disable-line no-param-reassign
           }
 
           return resolve;

tests/webpack-projects/extending-other-files/.app-config.meta.yml

@@ -0,0 +1,2 @@
+generate:
+  - file: './src/@types/lcdev__app-config/index.d.ts'

tests/webpack-projects/extending-other-files/.app-config.schema.yml

@@ -0,0 +1,9 @@
+type: object
+additionalProperties: false
+
+required:
+  - foo
+
+properties:
+  foo:
+    type: string

tests/webpack-projects/extending-other-files/.app-config.yml

@@ -0,0 +1,3 @@
+foo: bar
+
+$extends: ./other-file.yml

tests/webpack-projects/extending-other-files/cypress.json

@@ -0,0 +1,4 @@
+{
+  "projectId": "fm6zcy",
+  "baseUrl": "http://localhost:8994"
+}

tests/webpack-projects/extending-other-files/cypress/integration/main.spec.ts

@@ -0,0 +1,7 @@
+describe('Config Loading', () => {
+  it('should render the configuration', () => {
+    cy.visit('/');
+
+    cy.get('body').should('contain', `"foo": "baz"`);
+  });
+});

tests/webpack-projects/extending-other-files/cypress/plugins/index.js

@@ -0,0 +1,2 @@
+module.exports = (on, config) => {
+}

tests/webpack-projects/extending-other-files/cypress/screenshots/main.spec.ts/Config Loading -- should render the configuration (failed).png

@@ -0,0 +1,25 @@
+// ***********************************************
+// This example commands.js shows you how to
+// create various custom commands and overwrite
+// existing commands.
+//
+// For more comprehensive examples of custom
+// commands please read more here:
+// https://on.cypress.io/custom-commands
+// ***********************************************
+//
+//
+// -- This is a parent command --
+// Cypress.Commands.add("login", (email, password) => { ... })
+//
+//
+// -- This is a child command --
+// Cypress.Commands.add("drag", { prevSubject: 'element'}, (subject, options) => { ... })
+//
+//
+// -- This is a dual command --
+// Cypress.Commands.add("dismiss", { prevSubject: 'optional'}, (subject, options) => { ... })
+//
+//
+// -- This will overwrite an existing command --
+// Cypress.Commands.overwrite("visit", (originalFn, url, options) => { ... })