fix: linter, used built in logger, tests

Author: fstylermiller

app-config-webpack/package.json

@@ -34,6 +34,7 @@
     "@app-config/config": "^2.8.7",
     "@app-config/schema": "^2.8.7",
     "@app-config/utils": "^2.8.7",
+    "@app-config/logging": "^2.8.7",
     "loader-utils": "2"
   },
   "peerDependencies": {

app-config-webpack/src/index.test.ts

@@ -1,6 +1,7 @@
 import { resolve, join } from 'path';
-import webpack, { Compiler } from 'webpack';
+import webpack from 'webpack';
 import HtmlPlugin from 'html-webpack-plugin';
+import { logger, LogLevel } from '@app-config/logging';
 import AppConfigPlugin, { regex, loader, Options } from './index';
 
 const examplesDir = resolve(__dirname, '../../examples');
@@ -54,7 +55,9 @@ describe('frontend-webpack-project example', () => {
         throw new Error('html-webpack-plugin not found');
       });
 
-      const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
+      const writeMsg = jest.fn();
+      logger.setWriter(writeMsg);
+      logger.setLevel(LogLevel.Verbose);
 
       try {
         await new Promise<void>((done, reject) => {
@@ -66,14 +69,16 @@ describe('frontend-webpack-project example', () => {
           });
         });
       } catch (err) {
-        expect(consoleErrorSpy).toHaveBeenCalledTimes(3);
-        expect(consoleErrorSpy).toHaveBeenCalledWith('html-webpack-plugin not found');
-        expect(consoleErrorSpy).toHaveBeenCalledWith('Failed to resolve html-webpack-plugin');
-        expect(consoleErrorSpy).toHaveBeenCalledWith(
-          'Either include the module in your dependencies and enable the webpack plugin, or set headerInjection to false in your configuration.',
+        expect(writeMsg).toHaveBeenCalledTimes(3);
+        expect(writeMsg).toHaveBeenCalledWith(
+          '[app-config][ERROR] html-webpack-plugin not found\n',
+        );
+        expect(writeMsg).toHaveBeenCalledWith(
+          '[app-config][ERROR] Failed to resolve html-webpack-plugin\n',
+        );
+        expect(writeMsg).toHaveBeenCalledWith(
+          '[app-config][ERROR] Either include the module in your dependencies and enable the webpack plugin, or set headerInjection to false in your configuration.\n',
         );
-      } finally {
-        consoleErrorSpy.mockRestore();
       }
     });
   });

app-config-webpack/src/index.ts

@@ -2,6 +2,7 @@ import { join } from 'path';
 import { Compiler } from 'webpack';
 import type { ConfigLoadingOptions, SchemaLoadingOptions } from '@app-config/main';
 import type { HtmlTagObject } from 'html-webpack-plugin';
+import { logger } from '@app-config/logging';
 
 import { regex } from './loader';
 
@@ -114,10 +115,10 @@ export default class AppConfigPlugin implements Options {
             },
           );
         })
-        .catch((error) => {
-          console.error(error.message);
-          console.error('Failed to resolve html-webpack-plugin');
-          console.error(
+        .catch((error: Error) => {
+          logger.error(error.message);
+          logger.error('Failed to resolve html-webpack-plugin');
+          logger.error(
             'Either include the module in your dependencies and enable the webpack plugin, or set headerInjection to false in your configuration.',
           );
         });