chore: clean up webpack configs

Author: joelgallant

examples/frontend-webpack-project/webpack.config.js

@@ -5,6 +5,10 @@ const { default: AppConfigPlugin } = require('@app-config/webpack');
 // Important parts are in module->rules (the AppConfigPlugin.loader), and plugins
 // AppConfigPlugin relies on HtmlPlugin (html-webpack-plugin), when using headerInjection
 
+const appConfigOptions = {
+  headerInjection: true,
+};
+
 module.exports = {
   entry: './src/index.ts',
   output: {
@@ -21,11 +25,11 @@ module.exports = {
       },
       {
         test: AppConfigPlugin.regex,
-        use: { loader: AppConfigPlugin.loader, options: { headerInjection: true } },
+        use: { loader: AppConfigPlugin.loader, options: appConfigOptions },
       },
     ],
   },
-  plugins: [new HtmlPlugin(), new AppConfigPlugin({ headerInjection: true })],
+  plugins: [new HtmlPlugin(), new AppConfigPlugin(appConfigOptions)],
   devServer: {
     host: '0.0.0.0',
     port: 8080,

tests/webpack-projects/cypress-plugin/webpack.config.js

@@ -2,8 +2,9 @@ const path = require('path');
 const HtmlPlugin = require('html-webpack-plugin');
 const { default: AppConfigPlugin } = require('@app-config/webpack');
 
-// Important parts are in module->rules (the AppConfigPlugin.loader), and plugins
-// AppConfigPlugin relies on HtmlPlugin (html-webpack-plugin), when using headerInjection
+const appConfigOptions = {
+  headerInjection: true,
+};
 
 module.exports = {
   entry: './src/index.ts',
@@ -21,11 +22,11 @@ module.exports = {
       },
       {
         test: AppConfigPlugin.regex,
-        use: { loader: AppConfigPlugin.loader, options: { headerInjection: true } },
+        use: { loader: AppConfigPlugin.loader, options: appConfigOptions },
       },
     ],
   },
-  plugins: [new HtmlPlugin(), new AppConfigPlugin({ headerInjection: true })],
+  plugins: [new HtmlPlugin(), new AppConfigPlugin(appConfigOptions)],
   devServer: {
     host: '0.0.0.0',
     port: 8991,

tests/webpack-projects/extending-other-files/webpack.config.js

@@ -2,8 +2,7 @@ const path = require('path');
 const HtmlPlugin = require('html-webpack-plugin');
 const { default: AppConfigPlugin } = require('@app-config/webpack');
 
-// Important parts are in module->rules (the AppConfigPlugin.loader), and plugins
-// AppConfigPlugin relies on HtmlPlugin (html-webpack-plugin), when using headerInjection
+const appConfigOptions = {};
 
 module.exports = {
   entry: './src/index.ts',
@@ -21,11 +20,11 @@ module.exports = {
       },
       {
         test: AppConfigPlugin.regex,
-        use: { loader: AppConfigPlugin.loader },
+        use: { loader: AppConfigPlugin.loader, options: appConfigOptions },
       },
     ],
   },
-  plugins: [new HtmlPlugin(), new AppConfigPlugin()],
+  plugins: [new HtmlPlugin(), new AppConfigPlugin(appConfigOptions)],
   devServer: {
     host: '0.0.0.0',
     port: 8994,

tests/webpack-projects/query-parameter-overrides/webpack.config.js

@@ -2,8 +2,7 @@ const path = require('path');
 const HtmlPlugin = require('html-webpack-plugin');
 const { default: AppConfigPlugin } = require('@app-config/webpack');
 
-// Important parts are in module->rules (the AppConfigPlugin.loader), and plugins
-// AppConfigPlugin relies on HtmlPlugin (html-webpack-plugin), when using headerInjection
+const appConfigOptions = {};
 
 module.exports = {
   entry: './src/index.ts',
@@ -21,11 +20,11 @@ module.exports = {
       },
       {
         test: AppConfigPlugin.regex,
-        use: { loader: AppConfigPlugin.loader, options: { headerInjection: true } },
+        use: { loader: AppConfigPlugin.loader, options: appConfigOptions },
       },
     ],
   },
-  plugins: [new HtmlPlugin(), new AppConfigPlugin({ headerInjection: true })],
+  plugins: [new HtmlPlugin(), new AppConfigPlugin(appConfigOptions)],
   devServer: {
     host: '0.0.0.0',
     port: 8990,

tests/webpack-projects/two-app-config-sources/webpack.config.js

@@ -2,8 +2,20 @@ const path = require('path');
 const HtmlPlugin = require('html-webpack-plugin');
 const { default: AppConfigPlugin } = require('@app-config/webpack');
 
-// Important parts are in module->rules (the AppConfigPlugin.loader), and plugins
-// AppConfigPlugin relies on HtmlPlugin (html-webpack-plugin), when using headerInjection
+const appConfigOptions = {
+  headerInjection: true,
+};
+
+const appConfigStaticOptions = {
+  noGlobal: true,
+  intercept: /app-config-static/,
+  loading: {
+    fileNameBase: 'app-config-static',
+  },
+  schemaLoading: {
+    fileNameBase: 'app-config-static.schema',
+  },
+};
 
 module.exports = {
   entry: './src/index.ts',
@@ -23,33 +35,19 @@ module.exports = {
         test: /app-config-static/,
         use: {
           loader: AppConfigPlugin.loader,
-          options: {
-            noGlobal: true,
-            loading: {
-              fileNameBase: 'app-config-static',
-            },
-          },
+          options: appConfigStaticOptions,
         },
       },
       {
         test: AppConfigPlugin.regex,
-        use: { loader: AppConfigPlugin.loader, options: { headerInjection: true } },
+        use: { loader: AppConfigPlugin.loader, options: appConfigOptions },
       },
     ],
   },
   plugins: [
     new HtmlPlugin(),
-    new AppConfigPlugin({ headerInjection: true }),
-    new AppConfigPlugin({
-      noGlobal: true,
-      intercept: /app-config-static/,
-      loading: {
-        fileNameBase: 'app-config-static',
-      },
-      schemaLoading: {
-        fileNameBase: 'app-config-static.schema',
-      },
-    }),
+    new AppConfigPlugin(appConfigOptions),
+    new AppConfigPlugin(appConfigStaticOptions),
   ],
   devServer: {
     host: '0.0.0.0',

tests/webpack-projects/webpack5/webpack.config.js

@@ -2,8 +2,9 @@ const path = require('path');
 const HtmlPlugin = require('html-webpack-plugin');
 const { default: AppConfigPlugin } = require('@app-config/webpack');
 
-// Important parts are in module->rules (the AppConfigPlugin.loader), and plugins
-// AppConfigPlugin relies on HtmlPlugin (html-webpack-plugin), when using headerInjection
+const appConfigOptions = {
+  headerInjection: true,
+};
 
 module.exports = {
   entry: './src/index.ts',
@@ -21,11 +22,11 @@ module.exports = {
       },
       {
         test: AppConfigPlugin.regex,
-        use: { loader: AppConfigPlugin.loader, options: { headerInjection: true } },
+        use: { loader: AppConfigPlugin.loader, options: appConfigOptions },
       },
     ],
   },
-  plugins: [new HtmlPlugin(), new AppConfigPlugin({ headerInjection: true })],
+  plugins: [new HtmlPlugin(), new AppConfigPlugin(appConfigOptions)],
   devServer: {
     host: '0.0.0.0',
     port: 8995,