Skip to content

Commit 2c7ff62

Browse files
fix: #104 dependency optimisation (#111)
1 parent 15eff6b commit 2c7ff62

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

pkgs/sdk/client/src/LaunchDarkly.ClientSdk.csproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
<ItemGroup>
4242
<Folder Include="Properties\"/>
4343
<PackageReference Include="System.Numerics.Vectors" Version="4.5.0"/>
44-
<PackageReference Include="System.Text.Json" Version="6.0.10"/>
4544
<PackageReference Include="LaunchDarkly.CommonSdk" Version="7.0.0"/>
4645
<PackageReference Include="LaunchDarkly.EventSource" Version="5.0.1"/>
4746
<PackageReference Include="LaunchDarkly.InternalSdk" Version="3.5.1" />
@@ -51,6 +50,11 @@
5150
<Compile Include="PlatformSpecific\*.shared.cs"/>
5251
</ItemGroup>
5352

53+
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'net462'">
54+
<PackageReference Include="System.Text.Json" Version="6.0.10" />
55+
<!-- it's a built-in package in netcoreapp3.1 and net6.0 -->
56+
</ItemGroup>
57+
5458
<!-- dependencies and source files for .NET 8.0 (all versions) -->
5559
<ItemGroup Condition="$(TargetFramework.ToLower().Equals('netstandard2.0')) Or $(TargetFramework.ToLower().Equals('net8.0'))">
5660
<Compile Include="**\*.netstandard.cs"/>

pkgs/sdk/server/src/LaunchDarkly.ServerSdk.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@
4343
<PackageReference Include="LaunchDarkly.EventSource" Version="5.2.0" />
4444
<PackageReference Include="LaunchDarkly.InternalSdk" Version="3.5.1" />
4545
<PackageReference Include="LaunchDarkly.Logging" Version="2.0.0" />
46-
<PackageReference Include="System.Collections.Immutable" Version="1.7.1" />
4746
</ItemGroup>
4847

4948
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'net462'">
5049
<PackageReference Include="System.Text.Json" Version="6.0.10" />
50+
<PackageReference Include="System.Collections.Immutable" Version="1.7.1" />
5151
<!-- it's a built-in package in net8.0 -->
5252
</ItemGroup>
5353

pkgs/shared/common-json-net/src/LaunchDarkly.CommonSdk.JsonNet.csproj

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,8 @@
3434
<PackageReference Include="Newtonsoft.Json" Version="[12.0.1,]" />
3535
</ItemGroup>
3636

37-
<ItemGroup>
37+
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'net462'">
3838
<PackageReference Include="System.Collections.Immutable" Version="1.7.1" />
39-
</ItemGroup>
40-
41-
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'
42-
or '$(TargetFramework)' == 'net462'">
4339
<PackageReference Include="System.Text.Json" Version="6.0.0" />
4440
<!-- it's a built-in package in net8.0 -->
4541
</ItemGroup>

pkgs/shared/common/src/LaunchDarkly.CommonSdk.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,11 @@
3636

3737
<ItemGroup>
3838
<PackageReference Include="LaunchDarkly.Logging" Version="2.0.0" />
39-
<PackageReference Include="System.Collections.Immutable" Version="1.7.1" />
4039
</ItemGroup>
4140

4241
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'net462'">
4342
<PackageReference Include="System.Text.Json" Version="6.0.0" />
43+
<PackageReference Include="System.Collections.Immutable" Version="1.7.1" />
4444
<!-- it's a built-in package in net8.0 -->
4545
</ItemGroup>
4646

0 commit comments

Comments
 (0)