fix: Track latencies greater than 1 second (#133)

Author: jsonbailey

pkgs/sdk/server/src/Migrations/MigrationOpTracker.cs

@@ -279,8 +279,9 @@ private bool CheckEventConsistency()
                 {
                     migrationOpEvent.Latency = new EventProcessorTypes.MigrationOpEvent.LatencyMeasurement
                     {
-                        Old = _oldLatency?.Milliseconds,
-                        New = _newLatency?.Milliseconds
+                        // Fractional milliseconds are trucated as LatencyMeasurement does not support them.
+                        Old = (long?)_oldLatency?.TotalMilliseconds,
+                        New = (long?)_newLatency?.TotalMilliseconds
                     };
                 }
 

pkgs/sdk/server/test/Migrations/MigrationOpTrackerTest.cs

@@ -213,6 +213,55 @@ public void ItHandlesAllCombinationsOfLatency(bool oldLatency, bool newLatency)
             Assert.Empty(LogCapture.GetMessages());
         }
 
+        [Fact]
+        public void ItRecordsLatencyInMillisecondsGreaterThanASecond()
+        {
+            var tracker = BasicTracker();
+            tracker.Op(MigrationOperation.Read);
+            tracker.Invoked(MigrationOrigin.New);
+            tracker.Invoked(MigrationOrigin.Old);
+
+            // 2.5 seconds = 2500 milliseconds
+            var oldLatency = TimeSpan.FromMilliseconds(2500);
+            var newLatency = TimeSpan.FromMilliseconds(1500);
+
+            tracker.Latency(MigrationOrigin.Old, oldLatency);
+            tracker.Latency(MigrationOrigin.New, newLatency);
+
+            var optEvent = tracker.CreateEvent();
+            Assert.True(optEvent.HasValue);
+            var migrationOpEvent = optEvent.Value;
+
+            Assert.True(migrationOpEvent.Latency.HasValue);
+            Assert.Equal(2500, migrationOpEvent.Latency?.Old);
+            Assert.Equal(1500, migrationOpEvent.Latency?.New);
+            Assert.Empty(LogCapture.GetMessages());
+        }
+
+        [Fact]
+        public void ItHandlesExtremelyLargeLatencyWithoutException()
+        {
+            var tracker = BasicTracker();
+            tracker.Op(MigrationOperation.Read);
+            tracker.Invoked(MigrationOrigin.New);
+            tracker.Invoked(MigrationOrigin.Old);
+
+            var hugeLatency = TimeSpan.MaxValue;
+
+            Exception ex = Record.Exception(() =>
+            {
+                tracker.Latency(MigrationOrigin.Old, hugeLatency);
+                tracker.Latency(MigrationOrigin.New, hugeLatency);
+                var optEvent = tracker.CreateEvent();
+                var migrationOpEvent = optEvent.Value;
+                Assert.Equal((long?)TimeSpan.MaxValue.TotalMilliseconds, migrationOpEvent.Latency?.Old);
+                Assert.Equal((long?)TimeSpan.MaxValue.TotalMilliseconds, migrationOpEvent.Latency?.New);
+                Assert.Empty(LogCapture.GetMessages());
+            });
+
+            Assert.Null(ex);
+        }
+
         [Theory]
         [InlineData(true)]
         [InlineData(false)]