Address feedback to make validation more specific. Removed forcing offline mode.

Author: jsonbailey

pkgs/sdk/server/src/Configuration.cs

@@ -187,7 +187,7 @@ internal Configuration(ConfigurationBuilder builder)
             Events = builder._events;
             Http = builder._http;
             Logging = builder._logging;
-            Offline = builder._sdkKey == null || builder._offline;
+            Offline = builder._offline;
             SdkKey = builder._sdkKey;
             ServiceEndpoints = (builder._serviceEndpointsBuilder ?? Components.ServiceEndpoints()).Build();
             StartWaitTime = builder._startWaitTime;

pkgs/sdk/server/src/ConfigurationBuilder.cs

@@ -59,7 +59,7 @@ public sealed class ConfigurationBuilder
         /// </summary>
         private void SetSdkKeyIfValid(string sdkKey)
         {
-            if (ValidationUtils.ValidateStringValue(sdkKey) == null)
+            if (ValidationUtils.ValidateSdkKeyFormat(sdkKey) == null)
             {
                 _sdkKey = sdkKey;
             }

pkgs/shared/common/src/Helpers/ValidationUtils.cs

@@ -10,6 +10,33 @@ public static class ValidationUtils
     {
         private static readonly Regex ValidCharsRegex = new Regex("^[-a-zA-Z0-9._]+\\z");
 
+        /// <summary>
+        /// Validates that a string does not contain invalid characters or exceed the max length of 8192 characters.
+        /// </summary>
+        /// <param name="sdkKey">the SDK key to validate.</param>
+        /// <returns>Null if the input is valid, otherwise an error string describing the issue.</returns>
+        public static string ValidateSdkKeyFormat(string sdkKey)
+        {
+
+            // For offline mode, we allow a null or empty SDK key and it is not invalid.
+            if (string.IsNullOrEmpty(sdkKey))
+            {
+                return null;
+            }
+
+            if (sdkKey.Length > 8192)
+            {
+                return "SDK key cannot be longer than 1024 characters.";
+            }
+
+            if (!ValidCharsRegex.IsMatch(sdkKey))
+            {
+                return "SDK key contains invalid characters.";
+            }
+
+            return null;
+        }
+
         /// <summary>
         /// Validates that a string is non-empty, not too longer for our systems, and only contains
         /// alphanumeric characters, hyphens, periods, and underscores.