Simplify state data

Author: kinyoklion

pkgs/sdk/server/src/Internal/DataSources/CompositeDataSource/IDataSourceObserver.cs

@@ -11,7 +11,7 @@ namespace LaunchDarkly.Sdk.Server.Internal.DataSources
     /// </summary>
     internal interface IDataSourceObserver
     {
-        void Apply(ChangeSet<ItemDescriptor> changeSet, bool exhausted);
+        void Apply(ChangeSet<ItemDescriptor> changeSet);
 
         /// <param name="newState">the data source state</param>
         /// <param name="newError">information about a new error, if any</param>

pkgs/sdk/server/src/Internal/DataSources/CompositeDataSource/ObservableDataSourceUpdates.cs

@@ -22,7 +22,6 @@ internal sealed class ObservableDataSourceUpdates : IDataSourceUpdatesV2
     {
         private readonly IDataSourceUpdatesV2 _primary;
         private readonly IReadOnlyList<IDataSourceObserver> _secondaries;
-        private readonly bool _isLast;
 
         /// <summary>
         /// Creates a new <see cref="ObservableDataSourceUpdates"/> instance.
@@ -34,7 +33,6 @@ public ObservableDataSourceUpdates(IDataSourceUpdatesV2 primary, IReadOnlyList<I
         {
             _primary = primary ?? throw new ArgumentNullException(nameof(primary));
             _secondaries = secondaries ?? throw new ArgumentNullException(nameof(secondaries));
-            _isLast = isLast;
         }
 
         /// <inheritdoc/>
@@ -67,7 +65,7 @@ public bool Apply(ChangeSet<ItemDescriptor> changeSet)
             // Then invoke on the secondaries
             foreach (var secondary in _secondaries)
             {
-                secondary.Apply(changeSet, _isLast);
+                secondary.Apply(changeSet);
             }
 
             return primarySucceeded;

pkgs/sdk/server/src/Internal/FDv2DataSources/FDv2DataSource.CompositeObserver.cs

@@ -19,11 +19,11 @@ public CompositeObserver(params IDataSourceObserver[] observers)
                 _observers = observers ?? throw new ArgumentNullException(nameof(observers));
             }
 
-            public void Apply(DataStoreTypes.ChangeSet<DataStoreTypes.ItemDescriptor> changeSet, bool exhausted)
+            public void Apply(DataStoreTypes.ChangeSet<DataStoreTypes.ItemDescriptor> changeSet)
             {
                 foreach (var dataSourceObserver in _observers)
                 {
-                    dataSourceObserver.Apply(changeSet, exhausted);
+                    dataSourceObserver.Apply(changeSet);
                 }
             }
 

pkgs/sdk/server/src/Internal/FDv2DataSources/FDv2DataSource.InitializationTracker.cs

@@ -230,16 +230,12 @@ private void DetermineState(Action action)
                 }
             }
 
-            public void Apply(DataStoreTypes.ChangeSet<DataStoreTypes.ItemDescriptor> changeSet, bool exhausted,
+            public void Apply(DataStoreTypes.ChangeSet<DataStoreTypes.ItemDescriptor> changeSet,
                 DataSourceCategory category)
             {
                 if (!changeSet.Selector.IsEmpty) DetermineState(Action.SelectorReceived);
 
                 DetermineState(Action.DataReceived);
-                if (category == DataSourceCategory.Initializers && exhausted)
-                {
-                    DetermineState(Action.InitializersExhausted);
-                }
             }
 
             public void UpdateStatus(DataSourceState newState, DataSourceStatus.ErrorInfo? newError,

pkgs/sdk/server/src/Internal/FDv2DataSources/FDv2DataSource.cs

@@ -149,7 +149,7 @@ public void UpdateStatus(DataSourceState newState, DataSourceStatus.ErrorInfo? n
                 }
             }
 
-            public void Apply(ChangeSet<ItemDescriptor> changeSet, bool exhausted)
+            public void Apply(ChangeSet<ItemDescriptor> changeSet)
             {
                 if (!changeSet.Selector.IsEmpty)
                 {
@@ -263,7 +263,7 @@ private void CancelPendingFallbackTask()
                 _interruptedFallbackTask = null;
             }
 
-            public void Apply(ChangeSet<ItemDescriptor> changeSet, bool exhausted)
+            public void Apply(ChangeSet<ItemDescriptor> changeSet)
             {
                 lock (_lock)
                 {
@@ -297,7 +297,7 @@ public void UpdateStatus(DataSourceState newState, DataSourceStatus.ErrorInfo? n
                 }
             }
 
-            public void Apply(ChangeSet<ItemDescriptor> changeSet, bool exhausted)
+            public void Apply(ChangeSet<ItemDescriptor> changeSet)
             {
                 // If this change has a selector, then we know we can move out of the current phase.
                 // This doesn't look at the type of the changeset (Full, Partial, None), because having
@@ -332,7 +332,7 @@ public void UpdateStatus(DataSourceState newState, DataSourceStatus.ErrorInfo? n
                 }
             }
 
-            public void Apply(ChangeSet<ItemDescriptor> changeSet, bool exhausted)
+            public void Apply(ChangeSet<ItemDescriptor> changeSet)
             {
                 // this FDv1 fallback action applier doesn't care about apply, it only looks for the FDv1Fallback flag in the errors
             }
@@ -361,9 +361,9 @@ public InitializationObserver(InitializationTracker initializationTracker, DataS
                 _category = category;
             }
 
-            public void Apply(ChangeSet<ItemDescriptor> changeSet, bool exhausted)
+            public void Apply(ChangeSet<ItemDescriptor> changeSet)
             {
-                _initializationTracker.Apply(changeSet, exhausted, _category);
+                _initializationTracker.Apply(changeSet, _category);
             }
 
             public void UpdateStatus(DataSourceState newState, DataSourceStatus.ErrorInfo? newError)

pkgs/sdk/server/test/Internal/DataSources/CompositeDataSource/CompositeSourceTest.cs

@@ -520,7 +520,7 @@ public void Dispose()
                 // Nothing to dispose
             }
 
-            public void Apply(ChangeSet<ItemDescriptor> changeSet, bool exhausted)
+            public void Apply(ChangeSet<ItemDescriptor> changeSet)
             {
                 _capturingUpdates.Apply(changeSet);
             }
@@ -563,7 +563,7 @@ public void Dispose()
                 // Nothing to dispose
             }
 
-            public void Apply(ChangeSet<ItemDescriptor> changeSet, bool exhausted)
+            public void Apply(ChangeSet<ItemDescriptor> changeSet)
             {
                 _capturingUpdates.Apply(changeSet);
             }
@@ -651,7 +651,7 @@ public void Dispose()
                 // Nothing to dispose
             }
 
-            public void Apply(ChangeSet<ItemDescriptor> changeSet, bool exhausted)
+            public void Apply(ChangeSet<ItemDescriptor> changeSet)
             {
                 _capturingUpdates.Apply(changeSet);
             }