From 7a1239b7f8a0d095bbe0ff121d9d6b986297711e Mon Sep 17 00:00:00 2001 From: jsonbailey Date: Fri, 30 May 2025 11:44:52 -0500 Subject: [PATCH 1/2] chore: Remove secret step for CI builds --- .github/workflows/sdk-client-ci.yml | 6 ------ .github/workflows/sdk-server-ai-ci.yml | 5 ----- .github/workflows/sdk-server-ci.yml | 5 ----- .github/workflows/telemetry-ci.yml | 5 ----- 4 files changed, 21 deletions(-) diff --git a/.github/workflows/sdk-client-ci.yml b/.github/workflows/sdk-client-ci.yml index 60ca3dc9..ea6a0947 100644 --- a/.github/workflows/sdk-client-ci.yml +++ b/.github/workflows/sdk-client-ci.yml @@ -30,12 +30,6 @@ jobs: shell: bash run: echo "$(cat pkgs/sdk/client/github_actions.env)" >> $GITHUB_ENV - - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0 - name: Get secrets - with: - aws_assume_role: ${{ vars.AWS_ROLE_ARN }} - s3_path_pairs: 'launchdarkly-releaser/dotnet/LaunchDarkly.ClientSdk.snk = LaunchDarkly.ClientSdk.snk' - - uses: ./.github/actions/ci with: project_file: ${{ env.PROJECT_FILE}} diff --git a/.github/workflows/sdk-server-ai-ci.yml b/.github/workflows/sdk-server-ai-ci.yml index 0ba01a8a..c27a2de8 100644 --- a/.github/workflows/sdk-server-ai-ci.yml +++ b/.github/workflows/sdk-server-ai-ci.yml @@ -26,11 +26,6 @@ jobs: shell: bash run: echo "$(cat pkgs/sdk/server-ai/github_actions.env)" >> $GITHUB_ENV - - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0 - name: Get secrets - with: - aws_assume_role: ${{ vars.AWS_ROLE_ARN }} - - uses: ./.github/actions/ci with: project_file: ${{ env.PROJECT_FILE}} diff --git a/.github/workflows/sdk-server-ci.yml b/.github/workflows/sdk-server-ci.yml index e2679ef1..8a0a78d4 100644 --- a/.github/workflows/sdk-server-ci.yml +++ b/.github/workflows/sdk-server-ci.yml @@ -26,11 +26,6 @@ jobs: shell: bash run: echo "$(cat pkgs/sdk/server/github_actions.env)" >> $GITHUB_ENV - - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0 - name: Get secrets - with: - aws_assume_role: ${{ vars.AWS_ROLE_ARN }} - - uses: ./.github/actions/ci with: project_file: ${{ env.PROJECT_FILE}} diff --git a/.github/workflows/telemetry-ci.yml b/.github/workflows/telemetry-ci.yml index 4858dafd..dbc4c972 100644 --- a/.github/workflows/telemetry-ci.yml +++ b/.github/workflows/telemetry-ci.yml @@ -26,11 +26,6 @@ jobs: shell: bash run: echo "$(cat pkgs/telemetry/github_actions.env)" >> $GITHUB_ENV - - uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0 - name: Get secrets - with: - aws_assume_role: ${{ vars.AWS_ROLE_ARN }} - - uses: ./.github/actions/ci with: project_file: ${{ env.PROJECT_FILE}} From ca4d4c5445fe4e4115633126b223abfbad0b802d Mon Sep 17 00:00:00 2001 From: jsonbailey Date: Fri, 30 May 2025 14:35:58 -0500 Subject: [PATCH 2/2] set configuration property for docfx --- .github/workflows/sdk-client-ci.yml | 1 - pkgs/sdk/client/docfx.json | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sdk-client-ci.yml b/.github/workflows/sdk-client-ci.yml index ea6a0947..912146d0 100644 --- a/.github/workflows/sdk-client-ci.yml +++ b/.github/workflows/sdk-client-ci.yml @@ -34,7 +34,6 @@ jobs: with: project_file: ${{ env.PROJECT_FILE}} test_project_file: ${{ env.TEST_PROJECT_FILE}} - target_test_framework: "net8.0" - uses: ./.github/actions/contract-tests with: diff --git a/pkgs/sdk/client/docfx.json b/pkgs/sdk/client/docfx.json index 40e781a5..7c19a617 100644 --- a/pkgs/sdk/client/docfx.json +++ b/pkgs/sdk/client/docfx.json @@ -11,7 +11,10 @@ } ], "dest": "./api", - "namespaceLayout": "nested" + "namespaceLayout": "nested", + "properties" : { + "Configuration": "Debug" + } } ], "build": {