Merge pull request #86 from launchdarkly/eb/sc-148431/http-request-modifier

tests/comment edits for new HttpRequestModifier feature

Author: eli-darkly

src/LaunchDarkly.EventSource/ConfigurationBuilder.cs

@@ -78,9 +78,10 @@ public ConfigurationBuilder ConnectionTimeout(TimeSpan responseStartTimeout) =>
             ResponseStartTimeout(responseStartTimeout);
 
         /// <summary>
-        /// Sets a delegate hook invoked before an HTTP request has been performed.
+        /// Sets a delegate hook invoked before an HTTP request is performed. This may be useful if you
+        /// want to modify some properties of the request that EventSource doesn't already have an option for.
         /// </summary>
-        /// <param name="httpRequestModifier">The hook delegate</param>
+        /// <param name="httpRequestModifier">code that will be called with the request before it is sent</param>
         /// <returns>the builder</returns>
         public ConfigurationBuilder HttpRequestModifier(Action<HttpRequestMessage> httpRequestModifier)
         {

test/LaunchDarkly.EventSource.Tests/ConfigurationBuilderTest.cs

@@ -301,5 +301,13 @@ public void BuilderSetsRequestBodyString()
             var c = b.Build().RequestBodyFactory();
             Assert.IsType<StringContent>(c);
         }
+
+        [Fact]
+        public void BuilderSetsHttpRequestModifier()
+        {
+            Action<HttpRequestMessage> action = request => { };
+            var b = Configuration.Builder(uri).HttpRequestModifier(action);
+            Assert.Equal(action, b.Build().HttpRequestModifier);
+        }
     }
 }

test/LaunchDarkly.EventSource.Tests/EventSourceHttpBehaviorTest.cs

@@ -144,6 +144,27 @@ public void CustomRequestHeaders()
             }
         }
 
+        [Fact]
+        public void HttpRequestModifier()
+        {
+            using (var server = HttpServer.Start(EmptyStreamThatStaysOpen))
+            {
+                var headers = new Dictionary<string, string> { { "User-Agent", "mozilla" }, { "Authorization", "testing" } };
+
+                Action<HttpRequestMessage> modifier = request =>
+                {
+                    request.RequestUri = new Uri(request.RequestUri.ToString() + "-modified");
+                };
+                using (var es = MakeEventSource(server.Uri, builder => builder.HttpRequestModifier(modifier)))
+                {
+                    _ = Task.Run(es.StartAsync);
+
+                    var req = server.Recorder.RequireRequest();
+                    Assert.EndsWith("-modified", req.Path);
+                }
+            }
+        }
+
         [Fact]
         public void ReceiveEventStreamInChunks()
         {

test/LaunchDarkly.EventSource.Tests/LaunchDarkly.EventSource.Tests.csproj

@@ -25,7 +25,6 @@
 
 	<ItemGroup>
     <ProjectReference Include="..\..\src\LaunchDarkly.EventSource\LaunchDarkly.EventSource.csproj" />
-    <ProjectReference Include="..\..\..\dotnet-test-helpers\src\LaunchDarkly.TestHelpers\LaunchDarkly.TestHelpers.csproj" />
   </ItemGroup>
 
   <ItemGroup>