Skip to content

Commit 94982df

Browse files
authored
chore: Fix SSE contract tests (#52)
1 parent 0bf5a56 commit 94982df

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

.github/workflows/common_ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,16 @@ jobs:
3434
go-version: ${{ inputs.go-version }}
3535
- uses: ./.github/actions/get-go-version
3636
id: go-version
37+
- name: Build test service
38+
run: make build-contract-tests
3739
- name: Start test service in background
3840
run: make start-contract-test-service-bg
39-
- uses: launchdarkly/gh-actions/actions/[email protected]
40-
continue-on-error: true
41+
- uses: launchdarkly/gh-actions/actions/[email protected]
4142
with:
4243
test_service_port: ${{ env.TEST_SERVICE_PORT }}
4344
token: ${{ secrets.GITHUB_TOKEN }}
4445
repo: sse-contract-tests
46+
branch: main
4547
- name: Upload test service logs
4648
uses: actions/upload-artifact@v4
4749
with:

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@ bump-min-go-version:
2929
build-contract-tests:
3030
@cd contract-tests && go mod tidy && go build
3131

32-
start-contract-test-service:
32+
start-contract-test-service: build-contract-tests
3333
@./contract-tests/contract-tests
3434

3535
start-contract-test-service-bg:
3636
@echo "Test service output will be captured in $(TEMP_TEST_OUTPUT)"
3737
@make start-contract-test-service >$(TEMP_TEST_OUTPUT) 2>&1 &
3838

3939
run-contract-tests:
40-
@curl -s https://raw.githubusercontent.com/launchdarkly/sse-contract-tests/v2.0.0/downloader/run.sh \
40+
@curl -s https://raw.githubusercontent.com/launchdarkly/sse-contract-tests/main/downloader/run.sh \
4141
| VERSION=v2 PARAMS="-url http://localhost:8000 -debug -stop-service-at-end" sh
4242

4343
contract-tests: build-contract-tests start-contract-test-service-bg run-contract-tests

contract-tests/go.sum

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@ github.com/stretchr/testify v1.6.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
1212
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
1313
gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
1414
gopkg.in/yaml.v2 v2.2.8/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
15-
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=
1615
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
16+
gopkg.in/yaml.v3 v3.0.0 h1:hjy8E9ON/egN1tAYqKb61G10WtihqetD4sz2H+8nIeA=
17+
gopkg.in/yaml.v3 v3.0.0/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

0 commit comments

Comments
 (0)