misc cleanup

Author: eli-darkly

ldservices/client_sdk_data_test.go

@@ -6,6 +6,7 @@ import (
 
 	"gopkg.in/launchdarkly/go-sdk-common.v1/ldvalue"
 
+	"github.com/launchdarkly/eventsource"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -16,6 +17,10 @@ func TestFlagValuePatchEvent(t *testing.T) {
 	expectedJSON1 := `{"key": "flagkey", "version": 1, "flagVersion": 1000, "value": true, "variation": 1}`
 	assertJSONEqual(t, expectedJSON1, string(bytes1))
 
+	var event eventsource.Event = f
+	assert.Equal(t, "patch", event.Event())
+	assert.Equal(t, string(bytes1), event.Data())
+
 	bytes2 := f.ToJSON(false)
 	expectedJSON2 := `{"version": 1, "flagVersion": 1000, "value": true, "variation": 1}`
 	assertJSONEqual(t, expectedJSON2, string(bytes2))

ldservices/server_sdk_data.go

@@ -20,8 +20,6 @@ func (f fakeFlagOrSegment) GetKey() string {
 
 // FlagOrSegment provides a stub implementation of KeyedData that has only "key" and "version" properties.
 // This may be enough for some testing purposes that don't require full flag or segment data.
-//
-// It also implements the eventsource.Event interface, simulating a "patch" event for the streaming service.
 func FlagOrSegment(key string, version int) KeyedData {
 	return fakeFlagOrSegment{Key: key, Version: version}
 }