Merge pull request #15 from launchdarkly/eb/sc-151602/panic-message

eli-darkly · web-flow · commit 2dc2cf13ecea · 2022-05-02T14:38:51.000-07:00
clarify "expected panic" error output
diff --git a/httphelpers/handlers.go b/httphelpers/handlers.go
@@ -185,6 +185,7 @@ func BrokenConnectionHandler() http.Handler {
 				return
 			}
 		}
-		panic("connection deliberately closed by httphelpers.BrokenConnectionHandler")
+		panic("connection deliberately closed by httphelpers.BrokenConnectionHandler; a panic stacktrace" +
+			" here from the Go HTTP framework is expected and can be ignored")
 	})
 }

Original file line number	Diff line number	Diff line change
`@@ -185,6 +185,7 @@ func BrokenConnectionHandler() http.Handler {`
`185`	`185`	`return`
`186`	`186`	`}`
`187`	`187`	`}`
`188`		`- panic("connection deliberately closed by httphelpers.BrokenConnectionHandler")`
	`188`	`+ panic("connection deliberately closed by httphelpers.BrokenConnectionHandler; a panic stacktrace" +`
	`189`	`+ " here from the Go HTTP framework is expected and can be ignored")`
`189`	`190`	`})`
`190`	`191`	`}`