Skip to content

Commit 82d3710

Browse files
tanderson-ldtanderson-ld
authored
chore: updating CICD to support the java sdk internal package (#18)
This PR copies existing java-sdk-internal code from the private repo and takes the same approach as other migrated packages. I made a separate commit for the code copy to make that easier to verify. All code in lib/shared/internal should be identical to the [existing repo ](https://github.com/launchdarkly/java-sdk-internal)with no changes intended. Please check them carefully.
1 parent 9f7d64c commit 82d3710

File tree

83 files changed

+8594
-17
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

83 files changed

+8594
-17
lines changed

‎.github/ISSUE_TEMPLATE/package-sdk-common--bug_report.md

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,36 @@
11
---
2-
name: Feature request for the java-sdk-common package
3-
about: Suggest an idea for this project
2+
name: 'Bug report for the java-sdk-common package'
3+
about: Create a report to help us improve
44
title: ''
5-
labels: 'package: java-sdk-common, enhancement'
5+
labels: 'package: java-sdk-common, bug'
66
assignees: ''
7-
87
---
98

10-
**Is your feature request related to a problem? Please describe.**
11-
A clear and concise description of what the problem is. Ex. I would love to see the SDK [...does something new...]
9+
**Is this a support request?**
10+
This issue tracker is maintained by LaunchDarkly SDK developers and is intended for feedback on the code in this library. If you're not sure whether the problem you are having is specifically related to this library, or to the LaunchDarkly service overall, it may be more appropriate to contact the LaunchDarkly support team; they can help to investigate the problem and will consult the SDK team if necessary. You can submit a support request by going [here](https://support.launchdarkly.com/) and clicking "submit a request", or by emailing [email protected].
11+
12+
Note that issues filed on this issue tracker are publicly accessible. Do not provide any private account information on your issues. If your problem is specific to your account, you should submit a support request as described above.
13+
14+
**Describe the bug**
15+
A clear and concise description of what the bug is.
16+
17+
**To reproduce**
18+
Steps to reproduce the behavior.
19+
20+
**Expected behavior**
21+
A clear and concise description of what you expected to happen.
22+
23+
**Logs**
24+
If applicable, add any log output related to your problem.
25+
26+
**SDK version**
27+
The version of this SDK that you are using.
1228

13-
**Describe the solution you'd like**
14-
A clear and concise description of what you want to happen.
29+
**Language version, developer tools**
30+
For instance, Go 1.11 or Ruby 2.5.3. If you are using a language that requires a separate compiler, such as C, please include the name and version of the compiler too.
1531

16-
**Describe alternatives you've considered**
17-
A clear and concise description of any alternative solutions or features you've considered.
32+
**OS/platform**
33+
For instance, Ubuntu 16.04, Windows 10, or Android 4.0.3. If your code is running in a browser, please also include the browser type and version.
1834

1935
**Additional context**
20-
Add any other context about the feature request here.
36+
Add any other context about the problem here.

‎.github/ISSUE_TEMPLATE/package-sdk-common--feature_request.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature request for the java-sdk-common package
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: 'package: java-sdk-common, enhancement'
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I would love to see the SDK [...does something new...]
12+
13+
**Describe the solution you'd like**
14+
A clear and concise description of what you want to happen.
15+
16+
**Describe alternatives you've considered**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Additional context**
20+
Add any other context about the feature request here.

‎.github/ISSUE_TEMPLATE/package-sdk-commonl--bug_report.md renamed to ‎.github/ISSUE_TEMPLATE/package-sdk-internal--bug_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
---
2-
name: 'Bug report for the java-sdk-common package'
2+
name: 'Bug report for the java-sdk-internal package'
33
about: Create a report to help us improve
44
title: ''
5-
labels: 'package: java-sdk-common, bug'
5+
labels: 'package: java-sdk-internal, bug'
66
assignees: ''
77
---
88

‎.github/ISSUE_TEMPLATE/package-sdk-internal--feature_request.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature request for the java-sdk-internal package
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: 'package: java-sdk-internal, enhancement'
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I would love to see the SDK [...does something new...]
12+
13+
**Describe the solution you'd like**
14+
A clear and concise description of what you want to happen.
15+
16+
**Describe alternatives you've considered**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Additional context**
20+
Add any other context about the feature request here.

‎.github/workflows/java-sdk-internal.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
name: java-sdk-internal
2+
3+
on:
4+
push:
5+
branches: [main, 'feat/**']
6+
paths-ignore:
7+
- '**.md' #Do not need to run CI for markdown changes.
8+
pull_request:
9+
branches: [main, 'feat/**']
10+
paths-ignore:
11+
- '**.md'
12+
13+
jobs:
14+
build-test-java-sdk-internal:
15+
runs-on: ubuntu-latest
16+
steps:
17+
- uses: actions/checkout@v3
18+
19+
- name: Shared CI Steps
20+
uses: ./.github/actions/ci
21+
with:
22+
workspace_path: 'lib/shared/internal'
23+
java_version: 8

‎.github/workflows/manual-publish-docs.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
options:
99
- lib/java-server-sdk-otel
1010
- lib/shared/common
11+
- lib/shared/internal
1112
dry_run:
1213
description: 'Is this a dry run. If so no docs will be published.'
1314
type: boolean

‎.github/workflows/manual-publish.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
options:
1010
- lib/java-server-sdk-otel
1111
- lib/shared/common
12+
- lib/shared/internal
1213
prerelease:
1314
description: 'Is this a prerelease.'
1415
type: boolean

‎.github/workflows/release-please.yml

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,39 @@ jobs:
5252
aws_role: ${{ vars.AWS_ROLE_ARN }}
5353
token: ${{ secrets.GITHUB_TOKEN }}
5454

55+
release-sdk-internal:
56+
runs-on: ubuntu-latest
57+
needs: release-please
58+
permissions:
59+
id-token: write
60+
contents: write
61+
pull-requests: write
62+
if: ${{ needs.release-please.outputs.package-sdk-internal-released == 'true'}}
63+
steps:
64+
- uses: actions/checkout@v4
65+
66+
- uses: launchdarkly/gh-actions/actions/[email protected]
67+
name: Get secrets
68+
with:
69+
aws_assume_role: ${{ vars.AWS_ROLE_ARN }}
70+
ssm_parameter_pairs: '/production/common/releasing/sonatype/username = SONATYPE_USER_NAME,
71+
/production/common/releasing/sonatype/password = SONATYPE_PASSWORD'
72+
s3_path_pairs: 'launchdarkly-releaser/java/code-signing-keyring.gpg = code-signing-keyring.gpg'
73+
74+
- uses: ./.github/actions/full-release
75+
with:
76+
workspace_path: lib/shared/internal
77+
dry_run: true #TODO make this false after testing
78+
prerelease: true #TODO make this false after testing
79+
code_signing_keyring: 'code-signing-keyring.gpg'
80+
signing_key_id: ${{ env.SIGNING_KEY_ID }}
81+
signing_key_passphrase: ${{ env.SIGNING_KEY_PASSPHRASE }}
82+
sonatype_username: ${{ env.SONATYPE_USER_NAME }}
83+
sonatype_password: ${{ env.SONATYPE_PASSWORD }}
84+
aws_role: ${{ vars.AWS_ROLE_ARN }}
85+
token: ${{ secrets.GITHUB_TOKEN }}
86+
87+
5588
release-sdk-common:
5689
runs-on: ubuntu-latest
5790
needs: release-please

‎.release-please-manifest.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"lib/java-server-sdk-otel": "0.1.0",
3-
"lib/shared/common": "2.1.1"
3+
"lib/shared/common": "2.1.1",
4+
"lib/shared/internal": "1.3.0"
45
}

‎README.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@ This includes shared libraries, used by SDKs and other tools, as well as SDKs.
55

66
## Packages
77

8-
| Shared Packages | API Docs | maven | issues | tests |
9-
| ---------------------------------------------------------------- |--------------------------------------------------------------------| ---------------------------------------------------------- | ------------------------------------- | ------------------------------------------------------------- |
10-
| [@launchdarkly/java-sdk-common](lib/shared/common/README.md) | [![Documentation][sdk-common-docs-badge]][sdk-common-docs-link] | [![maven][sdk-common-maven-badge]][sdk-common-maven-link] | [Issues][sdk-common-issues] | [![Actions Status][sdk-common-ci-badge]][sdk-common-ci-link] |
8+
| Shared Packages | API Docs | maven | issues | tests |
9+
| ------------------------------------------------------------------ |---------------------------------------------------------------------| ------------------------------------------------------------- | ------------------------------------- | ----------------------------------------------------------------- |
10+
| [@launchdarkly/java-sdk-internal](lib/shared/internal/README.md) | [![Documentation][sdk-internal-docs-badge]][sdk-internal-docs-link] | [![maven][sdk-internal-maven-badge]][sdk-internal-maven-link] | [Issues][sdk-internal-issues] | [![Actions Status][sdk-internal-ci-badge]][sdk-internal-ci-link] |
11+
| [@launchdarkly/java-sdk-common](lib/shared/common/README.md) | [![Documentation][sdk-common-docs-badge]][sdk-common-docs-link] | [![maven][sdk-common-maven-badge]][sdk-common-maven-link] | [Issues][sdk-common-issues] | [![Actions Status][sdk-common-ci-badge]][sdk-common-ci-link] |
1112

1213
| Telemetry Packages | API Docs | maven | issues | tests |
1314
| ---------------------------------------------------------------------------- |--------------------------------------------------------------| ---------------------------------------------------------- | ------------------------------------- | ------------------------------------------------------------- |
@@ -57,6 +58,15 @@ We encourage pull requests and other contributions from the community. Check out
5758
[server-otel-docs-badge]: https://img.shields.io/static/v1?label=GitHub+Pages&message=API+reference&color=00add8
5859
[server-otel-docs-link]: https://launchdarkly.github.io/java-core/lib/java-server-sdk-otel/
5960

61+
[//]: # 'java-sdk-internal'
62+
[sdk-internal-issues]: https://github.com/launchdarkly/java-core/issues?q=is%3Aissue+is%3Aopen+label%3A%22package%3A+java-sdk-internal%22+
63+
[sdk-internal-maven-badge]: https://img.shields.io/maven-central/v/com.launchdarkly/launchdarkly-java-sdk-internal
64+
[sdk-internal-maven-link]: https://central.sonatype.com/artifact/com.launchdarkly/launchdarkly-java-sdk-internal
65+
[sdk-internal-ci-badge]: https://github.com/launchdarkly/java-core/actions/workflows/java-sdk-internal.yml/badge.svg
66+
[sdk-internal-ci-link]: https://github.com/launchdarkly/java-core/actions/workflows/java-sdk-internal.yml
67+
[sdk-internal-docs-badge]: https://img.shields.io/static/v1?label=GitHub+Pages&message=API+reference&color=00add8
68+
[sdk-internal-docs-link]: https://launchdarkly.github.io/java-core/lib/shared/internal/
69+
6070
[//]: # 'java-sdk-common'
6171
[sdk-common-issues]: https://github.com/launchdarkly/java-core/issues?q=is%3Aissue+is%3Aopen+label%3A%22package%3A+java-sdk-common%22+
6272
[sdk-common-maven-badge]: https://img.shields.io/maven-central/v/com.launchdarkly/launchdarkly-java-sdk-common

0 commit comments

Comments
 (0)