Skip to content

Commit 8a9670f

Browse files
Remove contextKeys assertions from EventOutputTest and rename contextKeys to contexts in ServerSideEventContextDeduplicator
Co-Authored-By: [email protected] <[email protected]>
1 parent 2ccb496 commit 8a9670f

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/ServerSideEventContextDeduplicator.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66
import java.time.Duration;
77

88
final class ServerSideEventContextDeduplicator implements EventContextDeduplicator {
9-
private final SimpleLRUCache<String, String> contextKeys;
9+
private final SimpleLRUCache<String, String> contexts;
1010
private final Duration flushInterval;
1111

1212
public ServerSideEventContextDeduplicator(
1313
int capacity,
1414
Duration flushInterval
1515
) {
16-
this.contextKeys = new SimpleLRUCache<>(capacity);
16+
this.contexts = new SimpleLRUCache<>(capacity);
1717
this.flushInterval = flushInterval;
1818
}
1919

@@ -28,12 +28,12 @@ public boolean processContext(LDContext context) {
2828
if (key == null || key.isEmpty()) {
2929
return false;
3030
}
31-
String previousValue = contextKeys.put(key, key);
31+
String previousValue = contexts.put(key, key);
3232
return previousValue == null;
3333
}
3434

3535
@Override
3636
public void flush() {
37-
contextKeys.clear();
37+
contexts.clear();
3838
}
3939
}

lib/shared/internal/src/test/java/com/launchdarkly/sdk/internal/events/EventOutputTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,6 @@ private void testContextSerialization(LDContext context, LDValue expectedJsonVal
720720
Event.Custom customEvent = customEvent(context, "eventkey").build();
721721
LDValue outputEvent = getSingleOutputEvent(f, customEvent);
722722
assertJsonEquals(expectedJsonValue, outputEvent.get("context"));
723-
assertJsonEquals(LDValue.ofNull(), outputEvent.get("contextKeys"));
724723
}
725724

726725
private void testInlineContextSerialization(LDContext context, LDValue expectedJsonValue, EventsConfiguration baseConfig) throws IOException {
@@ -729,18 +728,15 @@ private void testInlineContextSerialization(LDContext context, LDValue expectedJ
729728

730729
Event.FeatureRequest featureEvent = featureEvent(context, FLAG_KEY).build();
731730
LDValue outputEvent = getSingleOutputEvent(f, featureEvent);
732-
assertJsonEquals(LDValue.ofNull(), outputEvent.get("contextKeys"));
733731
assertJsonEquals(expectedJsonValue, outputEvent.get("context"));
734732

735733

736734
Event.Identify identifyEvent = identifyEvent(context);
737735
outputEvent = getSingleOutputEvent(f, identifyEvent);
738-
assertJsonEquals(LDValue.ofNull(), outputEvent.get("contextKeys"));
739736
assertJsonEquals(expectedJsonValue, outputEvent.get("context"));
740737

741738
Event.Index indexEvent = new Event.Index(0, context);
742739
outputEvent = getSingleOutputEvent(f, indexEvent);
743-
assertJsonEquals(LDValue.ofNull(), outputEvent.get("contextKeys"));
744740
assertJsonEquals(expectedJsonValue, outputEvent.get("context"));
745741
}
746742
}

0 commit comments

Comments
 (0)