chore: using the valuesAs converter for messages

Author: louis-launchdarkly

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/LDAiClient.java

@@ -84,12 +84,8 @@ protected AiConfig parseAiConfig(LDValue value, String key) {
             }
 
             List<Message> messages = new ArrayList<Message>();
-            for (LDValue valueMessage : valueMessages.values()) {
-                if (valueMessage == LDValue.ofNull() || valueMessage.getType() != LDValueType.OBJECT) {
-                    throw new AiConfigParseException("individual message must be a JSON object");
-                }
-
-                Message message = new Message(ldValueNullCheck(valueMessage.get("content")).stringValue(), Role.valueOf(valueMessage.get("role").stringValue().toUpperCase()));
+            valueMessages.valuesAs(new Message.MessageConverter());
+            for (Message message : valueMessages.valuesAs(new Message.MessageConverter())) {
                 messages.add(message);
             }
             result.setMessages(messages);

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/datamodel/Message.java

@@ -1,6 +1,23 @@
 package com.launchdarkly.sdk.server.ai.datamodel;
 
+import com.launchdarkly.sdk.LDValue;
+
 public final class Message {
+    public static class MessageConverter extends LDValue.Converter<Message> {
+        @Override
+        public LDValue fromType(Message message) {
+            return LDValue.buildObject()
+                    .put("content", message.getContent())
+                    .put("role", message.getRole().toString())
+                    .build();
+        }
+
+        @Override
+        public Message toType(LDValue ldValue) {
+            return new Message(ldValue.get("content").stringValue(), Role.getRole(ldValue.get("role").stringValue()));
+        }
+    }
+
     private String content;
 
     private Role role;

lib/sdk/server-ai/src/main/java/com/launchdarkly/sdk/server/ai/datamodel/Role.java

@@ -7,13 +7,37 @@ public enum Role {
     /**
      * User Role
      */
-    USER,
+    USER("user"),
     /**
      * System Role
      */
-    SYSTEM,
+    SYSTEM("system"),
     /**
      * Assistant Role
      */
-    ASSISTANT
+    ASSISTANT("assistant");
+
+    private final String role;
+
+    private Role(String role) {
+        this.role = role;
+    }
+
+    public static Role getRole(String role) {
+        switch (role) {
+            case "user":
+                return USER;
+            case "system":
+                return SYSTEM;
+            case "assistant":
+                return ASSISTANT;
+            default:
+                return null;
+        }
+    }
+
+    @Override
+    public String toString() {
+        return role;
+    }
 }

lib/sdk/server-ai/src/test/java/com/launchdarkly/sdk/server/ai/LDAiClientTest.java

@@ -9,50 +9,51 @@
 import static org.junit.Assert.assertEquals;
 
 public class LDAiClientTest {
-    @Test 
+    @Test
     public void testParseAiConfig() {
         String rawJson = "{\n" + //
-                        "  \"_ldMeta\": {\n" + //
-                        "    \"variationKey\" : 1234,\n" + //
-                        "    \"enabled\": true,\n" + //
-                        "    \"version\": 1\n" + //
-                        "  },\n" + //
-                        "  \"messages\": [\n" + //
-                        "    {\n" + //
-                        "      \"content\": \"This is an {{ adjective }} message.\",\n" + //
-                        "      \"role\": \"user\"\n" + //
-                        "    },\n" + //
-                        "    {\n" + //
-                        "      \"content\": \"{{ greeting}}, this is another message!\",\n" + //
-                        "      \"role\": \"system\"\n" + //
-                        "    },\n" + //
-                        "    {\n" + //
-                        "      \"content\": \"This is the final {{ noun }}.\",\n" + //
-                        "      \"role\": \"assistant\"\n" + //
-                        "    }\n" + //
-                        "  ],\n" + //
-                        "  \"model\": {\n" + //
-                        "    \"name\": \"my-cool-custom-model\",\n" + //
-                        "    \"parameters\": {\n" + //
-                        "      \"foo\" : \"bar\",\n" + //
-                        "      \"baz\" : 23,\n" + //
-                        "      \"qux\" : true,\n" + //
-                        "      \"whatever\" : [],\n" + //
-                        "      \"another\" : {}\n" + //
-                        "    }\n" + //
-                        "  },\n" + //
-                        "  \"provider\": {\n" + //
-                        "    \"name\" : \"provider-name\"\n" + //
-                        "  }\n" + //
-                        "}";
+                "  \"_ldMeta\": {\n" + //
+                "    \"variationKey\" : 1234,\n" + //
+                "    \"enabled\": true,\n" + //
+                "    \"version\": 1\n" + //
+                "  },\n" + //
+                "  \"messages\": [\n" + //
+                "    {\n" + //
+                "      \"content\": \"This is an {{ adjective }} message.\",\n" + //
+                "      \"role\": \"user\"\n" + //
+                "    },\n" + //
+                "    {\n" + //
+                "      \"content\": \"{{ greeting}}, this is another message!\",\n" + //
+                "      \"role\": \"system\"\n" + //
+                "    },\n" + //
+                "    {\n" + //
+                "      \"content\": \"This is the final {{ noun }}.\",\n" + //
+                "      \"role\": \"assistant\"\n" + //
+                "    }\n" + //
+                "  ],\n" + //
+                "  \"model\": {\n" + //
+                "    \"name\": \"my-cool-custom-model\",\n" + //
+                "    \"parameters\": {\n" + //
+                "      \"foo\" : \"bar\",\n" + //
+                "      \"baz\" : 23,\n" + //
+                "      \"qux\" : true,\n" + //
+                "      \"whatever\" : [],\n" + //
+                "      \"another\" : {}\n" + //
+                "    }\n" + //
+                "  },\n" + //
+                "  \"provider\": {\n" + //
+                "    \"name\" : \"provider-name\"\n" + //
+                "  }\n" + //
+                "}";
 
         LDValue input = LDValue.parse(rawJson);
-            
+
         LDAiClient client = new LDAiClient(null);
 
         AiConfig result = client.parseAiConfig(input, "Whatever");
 
         assertEquals(Role.USER, result.getMessages().get(0).getRole());
+        assertEquals("This is the final {{ noun }}.", result.getMessages().get(2).getContent());
         assertEquals(Integer.valueOf(1), result.getMeta().getVersion().orElse(0));
         assertEquals(LDValue.of(true), result.getModel().getParameters().get("qux"));
         assertEquals("provider-name", result.getProvider().getName());