Skip to content

Commit d671921

Browse files
committed
publish the internal package change first
Update the docs and simplify the local build enable using a property to disable signing vs commenting it out.
1 parent 04eb96b commit d671921

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

lib/sdk/server/contract-tests/service/src/main/java/sdktest/TestService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public class TestService {
3535
"filtering",
3636
"migrations",
3737
"event-sampling",
38-
"inline-context-all",
38+
"inline-context",
3939
"anonymous-redaction",
4040
"evaluation-hooks",
4141
"client-prereq-events"

lib/shared/common/CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ If you wish to clean your working directory between builds, you can clean it by
3737
./gradlew clean
3838
```
3939

40-
If you wish to use your generated SDK artifact by another Maven/Gradle project such as [java-server-sdk](https://github.com/launchdarkly/java-server-sdk), you will likely want to publish the artifact to your local Maven repository so that your other project can access it.
40+
If you wish to use your generated SDK artifact by another Maven/Gradle project such as [java-server-sdk](https://github.com/launchdarkly/java-server-sdk), you will likely want to publish the artifact to your local Maven repository so that your other project can access it. You can append `-SNAPSHOT` to the version in [gradle.properties](gradle.properties) and update any dependancies to test the snapshot version.
4141
```
42-
./gradlew publishToMavenLocal
42+
./gradlew publishToMavenLocal -PskipSigning=true
4343
```
4444

4545
### Testing

lib/shared/common/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,5 +88,6 @@ nexusPublishing {
8888
}
8989

9090
signing {
91+
setRequired({ findProperty("skipSigning") != "true" })
9192
sign(publishing.publications["mavenJava"])
9293
}

lib/shared/internal/CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ If you wish to clean your working directory between builds, you can clean it by
4545
./gradlew clean
4646
```
4747

48-
If you wish to use your generated SDK artifact by another Maven/Gradle project such as [java-server-sdk](https://github.com/launchdarkly/java-server-sdk), you will likely want to publish the artifact to your local Maven repository so that your other project can access it.
48+
If you wish to use your generated SDK artifact by another Maven/Gradle project such as [java-server-sdk](https://github.com/launchdarkly/java-server-sdk), you will likely want to publish the artifact to your local Maven repository so that your other project can access it. You can append `-SNAPSHOT` to the version in [gradle.properties](gradle.properties) and update any dependancies to test the snapshot version.
4949
```
50-
./gradlew publishToMavenLocal
50+
./gradlew publishToMavenLocal -PskipSigning=true
5151
```
5252

5353
### Testing

lib/shared/internal/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,5 +82,6 @@ nexusPublishing {
8282
}
8383

8484
signing {
85+
setRequired({ findProperty("skipSigning") != "true" })
8586
sign(publishing.publications["mavenJava"])
8687
}

0 commit comments

Comments
 (0)