Skip to content

Commit 085a17a

Browse files
prepare 3.2.0 release (#296)
## [3.2.0] - 2024-03-19 ### Changed: - Redact anonymous attributes within feature events - Always inline contexts for feature events Co-authored-by: Matthew M. Keeler <[email protected]>
1 parent e39dbca commit 085a17a

File tree

2 files changed

+9
-36
lines changed

2 files changed

+9
-36
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
},
7878
"dependencies": {
7979
"escape-string-regexp": "^4.0.0",
80-
"launchdarkly-js-sdk-common": "5.0.3"
80+
"launchdarkly-js-sdk-common": "5.1.0"
8181
},
8282
"repository": {
8383
"type": "git",

src/__tests__/LDClient-test.js

Lines changed: 8 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,8 @@ describe('LDClient', () => {
168168

169169
await client.flush();
170170

171-
expect(server.requests.length).toEqual(2);
172-
// ignore first request because it's just a side effect of calling browserPlatform.httpAllowsPost()
173-
expect(server.requests[1].async).toBe(true);
171+
expect(server.requests.length).toEqual(1);
172+
expect(server.requests[0].async).toBe(true);
174173
});
175174

176175
async function setupClientAndTriggerPageHide() {
@@ -196,9 +195,8 @@ describe('LDClient', () => {
196195

197196
await setupClientAndTriggerPageHide();
198197

199-
expect(server.requests.length).toEqual(2);
200-
// ignore first request because it's just a side effect of calling browserPlatform.httpAllowsPost()
201-
expect(server.requests[1].async).toBe(false); // events
198+
expect(server.requests.length).toEqual(1);
199+
expect(server.requests[0].async).toBe(false); // events
202200
});
203201
}
204202

@@ -218,13 +216,12 @@ describe('LDClient', () => {
218216
window.navigator.__defineGetter__('userAgent', () => ua);
219217

220218
const client = await setupClientAndTriggerPageHide();
221-
expect(server.requests.length).toEqual(2);
222-
// ignore first request because it's just a side effect of calling browserPlatform.httpAllowsPost()
223-
expect(server.requests[1].async).toBe(false); // events
219+
expect(server.requests.length).toEqual(1);
220+
expect(server.requests[0].async).toBe(false); // events
224221
client.track('Test'); // lets track a event that happen after a beforeunload event.
225222
client.flush().catch(() => {}); // flush that event
226-
expect(server.requests.length).toEqual(3); // assert the server got the request.
227-
expect(server.requests[2].async).toBe(true);
223+
expect(server.requests.length).toEqual(2); // assert the server got the request.
224+
expect(server.requests[1].async).toBe(true);
228225
});
229226
}
230227

@@ -237,29 +234,5 @@ describe('LDClient', () => {
237234

238235
testWithUserAgent('empty user-agent', null);
239236
});
240-
241-
describe('discards events during page unload', () => {
242-
function testWithUserAgent(desc, ua) {
243-
it('in ' + desc, async () => {
244-
window.navigator.__defineGetter__('userAgent', () => ua);
245-
246-
await setupClientAndTriggerPageHide();
247-
248-
window.dispatchEvent(new window.Event('beforeunload'));
249-
250-
expect(server.requests.length).toEqual(1); // flags query
251-
});
252-
}
253-
254-
testWithUserAgent(
255-
'Chrome 73',
256-
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.103 Safari/537.36'
257-
);
258-
259-
testWithUserAgent(
260-
'Chrome 74',
261-
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3683.103 Safari/537.36'
262-
);
263-
});
264237
});
265238
});

0 commit comments

Comments
 (0)