@@ -168,9 +168,8 @@ describe('LDClient', () => {
168
168
169
169
await client . flush ( ) ;
170
170
171
- expect ( server . requests . length ) . toEqual ( 2 ) ;
172
- // ignore first request because it's just a side effect of calling browserPlatform.httpAllowsPost()
173
- expect ( server . requests [ 1 ] . async ) . toBe ( true ) ;
171
+ expect ( server . requests . length ) . toEqual ( 1 ) ;
172
+ expect ( server . requests [ 0 ] . async ) . toBe ( true ) ;
174
173
} ) ;
175
174
176
175
async function setupClientAndTriggerPageHide ( ) {
@@ -196,9 +195,8 @@ describe('LDClient', () => {
196
195
197
196
await setupClientAndTriggerPageHide ( ) ;
198
197
199
- expect ( server . requests . length ) . toEqual ( 2 ) ;
200
- // ignore first request because it's just a side effect of calling browserPlatform.httpAllowsPost()
201
- expect ( server . requests [ 1 ] . async ) . toBe ( false ) ; // events
198
+ expect ( server . requests . length ) . toEqual ( 1 ) ;
199
+ expect ( server . requests [ 0 ] . async ) . toBe ( false ) ; // events
202
200
} ) ;
203
201
}
204
202
@@ -218,13 +216,12 @@ describe('LDClient', () => {
218
216
window . navigator . __defineGetter__ ( 'userAgent' , ( ) => ua ) ;
219
217
220
218
const client = await setupClientAndTriggerPageHide ( ) ;
221
- expect ( server . requests . length ) . toEqual ( 2 ) ;
222
- // ignore first request because it's just a side effect of calling browserPlatform.httpAllowsPost()
223
- expect ( server . requests [ 1 ] . async ) . toBe ( false ) ; // events
219
+ expect ( server . requests . length ) . toEqual ( 1 ) ;
220
+ expect ( server . requests [ 0 ] . async ) . toBe ( false ) ; // events
224
221
client . track ( 'Test' ) ; // lets track a event that happen after a beforeunload event.
225
222
client . flush ( ) . catch ( ( ) => { } ) ; // flush that event
226
- expect ( server . requests . length ) . toEqual ( 3 ) ; // assert the server got the request.
227
- expect ( server . requests [ 2 ] . async ) . toBe ( true ) ;
223
+ expect ( server . requests . length ) . toEqual ( 2 ) ; // assert the server got the request.
224
+ expect ( server . requests [ 1 ] . async ) . toBe ( true ) ;
228
225
} ) ;
229
226
}
230
227
@@ -237,29 +234,5 @@ describe('LDClient', () => {
237
234
238
235
testWithUserAgent ( 'empty user-agent' , null ) ;
239
236
} ) ;
240
-
241
- describe ( 'discards events during page unload' , ( ) => {
242
- function testWithUserAgent ( desc , ua ) {
243
- it ( 'in ' + desc , async ( ) => {
244
- window . navigator . __defineGetter__ ( 'userAgent' , ( ) => ua ) ;
245
-
246
- await setupClientAndTriggerPageHide ( ) ;
247
-
248
- window . dispatchEvent ( new window . Event ( 'beforeunload' ) ) ;
249
-
250
- expect ( server . requests . length ) . toEqual ( 1 ) ; // flags query
251
- } ) ;
252
- }
253
-
254
- testWithUserAgent (
255
- 'Chrome 73' ,
256
- 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.103 Safari/537.36'
257
- ) ;
258
-
259
- testWithUserAgent (
260
- 'Chrome 74' ,
261
- 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3683.103 Safari/537.36'
262
- ) ;
263
- } ) ;
264
237
} ) ;
265
238
} ) ;
0 commit comments