Skip to content

Commit ff06599

Browse files
authored
Merge pull request #36 from launchdarkly/zdavis/ch1056/make-ondone-optional
Make the `ondone` argument to `identify` optional
2 parents 03578ba + d8dfc6f commit ff06599

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
All notable changes to the LaunchDarkly client-side JavaScript SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
44

5+
## [1.1.7] - 2017-01-27
6+
### Changed
7+
- `onDone` argument to `identify` method is now optional
8+
59
## [1.1.6] - 2017-01-16
610
### Changed
711
- Removed dependency on Sizzle and direct to polyfill for older browser support

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ldclient-js",
3-
"version": "1.1.6",
3+
"version": "1.1.7",
44
"description": "LaunchDarkly SDK for JavaScript",
55
"author": "LaunchDarkly <[email protected]>",
66
"license": "Apache-2.0",

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ function identify(user, hash, onDone) {
8181
if (settings) {
8282
updateSettings(settings);
8383
}
84-
onDone();
84+
onDone && onDone();
8585
});
8686
}
8787

0 commit comments

Comments
 (0)