Skip to content

Commit 0da9d31

Browse files
committed
Change option to streaming.
1 parent aa33fa4 commit 0da9d31

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

packages/sdk/browser/__tests__/BrowserClient.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ describe('given a mock platform for a BrowserClient', () => {
129129
'client-side-id',
130130
AutoEnvAttributes.Disabled,
131131
{
132-
stream: false,
132+
streaming: false,
133133
logger,
134134
diagnosticOptOut: true,
135135
},
@@ -157,7 +157,7 @@ describe('given a mock platform for a BrowserClient', () => {
157157
'client-side-id',
158158
AutoEnvAttributes.Disabled,
159159
{
160-
stream: false,
160+
streaming: false,
161161
logger,
162162
diagnosticOptOut: true,
163163
eventUrlTransformer: (url: string) =>
@@ -190,7 +190,7 @@ describe('given a mock platform for a BrowserClient', () => {
190190
'client-side-id',
191191
AutoEnvAttributes.Disabled,
192192
{
193-
stream: false,
193+
streaming: false,
194194
logger,
195195
diagnosticOptOut: true,
196196
eventUrlTransformer: (url: string) =>
@@ -233,7 +233,7 @@ describe('given a mock platform for a BrowserClient', () => {
233233
'client-side-id',
234234
AutoEnvAttributes.Disabled,
235235
{
236-
stream: false,
236+
streaming: false,
237237
logger,
238238
diagnosticOptOut: true,
239239
eventUrlTransformer: (url: string) =>

packages/sdk/browser/__tests__/BrowserDataManager.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ describe('given a BrowserDataManager with mocked dependencies', () => {
128128
off: jest.fn(),
129129
} as unknown as jest.Mocked<FlagManager>;
130130

131-
browserConfig = validateOptions({ stream: false }, logger);
131+
browserConfig = validateOptions({ streaming: false }, logger);
132132
baseHeaders = {};
133133
emitter = {
134134
emit: jest.fn(),
@@ -173,7 +173,7 @@ describe('given a BrowserDataManager with mocked dependencies', () => {
173173
flagManager,
174174
'test-credential',
175175
config,
176-
validateOptions({ stream: true }, logger),
176+
validateOptions({ streaming: true }, logger),
177177
() => ({
178178
pathGet(encoding: Encoding, _plainContextString: string): string {
179179
return `/msdk/evalx/contexts/${base64UrlEncode(_plainContextString, encoding)}`;

packages/sdk/browser/contract-tests/entity/src/ClientEntity.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function makeSdkConfig(options: SDKConfigParams, tag: string) {
4141
if (options.streaming.baseUri) {
4242
cf.streamUri = options.streaming.baseUri;
4343
}
44-
cf.stream = true;
44+
cf.streaming = true;
4545
cf.streamInitialReconnectDelay = maybeTime(options.streaming.initialRetryDelayMs);
4646
}
4747

packages/sdk/browser/src/BrowserDataManager.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export default class BrowserDataManager extends BaseDataManager {
7171
identifyReject(e);
7272
}
7373

74-
if (this.browserConfig.stream) {
74+
if (this.browserConfig.streaming) {
7575
this.setupConnection(context);
7676
}
7777
}

packages/sdk/browser/src/options.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,25 +34,25 @@ export interface BrowserOptions extends Omit<LDOptionsBase, 'initialConnectionMo
3434
*
3535
* This is equivalent to calling `client.setStreaming()` with the same value.
3636
*/
37-
stream?: boolean;
37+
streaming?: boolean;
3838
}
3939

4040
export interface ValidatedOptions {
4141
fetchGoals: boolean;
4242
eventUrlTransformer: (url: string) => string;
43-
stream?: boolean;
43+
streaming?: boolean;
4444
}
4545

4646
const optDefaults = {
4747
fetchGoals: true,
4848
eventUrlTransformer: (url: string) => url,
49-
stream: undefined,
49+
streaming: undefined,
5050
};
5151

5252
const validators: { [Property in keyof BrowserOptions]: TypeValidator | undefined } = {
5353
fetchGoals: TypeValidators.Boolean,
5454
eventUrlTransformer: TypeValidators.Function,
55-
stream: TypeValidators.Boolean,
55+
streaming: TypeValidators.Boolean,
5656
};
5757

5858
export function filterToBaseOptions(opts: BrowserOptions): LDOptionsBase {

0 commit comments

Comments
 (0)