fix: boolean flags work with simplified flag logic, but no other flags work properly using welcome.tsx

Author: professorice

packages/tooling/jest/src/react-native/index.test.ts

@@ -1,5 +1,3 @@
-import { renderHook } from '@testing-library/react-hooks';
-
 import {
   ldClientMock,
   mockFlags,
@@ -11,9 +9,7 @@ import {
 
 describe('react-native', () => {
   test('reset LD Mocks', () => {
-    const {
-      result: { current },
-    } = renderHook(() => mockUseLDClient());
+    const current = mockUseLDClient();
 
     current?.track('event');
     expect(ldClientMock.track).toHaveBeenCalledTimes(1);
@@ -24,18 +20,22 @@ describe('react-native', () => {
 
   test('mock boolean flag correctly', () => {
     mockFlags({ 'bool-flag': true });
+    expect(ldClientMock.boolVariation).toBeDefined();
   });
 
   test('mock number flag correctly', () => {
     mockFlags({ 'number-flag': 42 });
+    expect(ldClientMock.numberVariation).toBeDefined();
   });
 
   test('mock string flag correctly', () => {
     mockFlags({ 'string-flag': 'hello' });
+    expect(ldClientMock.stringVariation).toBeDefined();
   });
 
   test('mock json flag correctly', () => {
     mockFlags({ 'json-flag': { key: 'value' } });
+    expect(ldClientMock.jsonVariation).toBeDefined();
   });
 
   test('mock LDProvider correctly', () => {
@@ -48,9 +48,7 @@ describe('react-native', () => {
 
   test('mock ldClient correctly', () => {
     resetLDMocks();
-    const {
-      result: { current },
-    } = renderHook(() => mockUseLDClient());
+    const current = mockUseLDClient();
 
     current?.track('event');
     expect(ldClientMock.track).toHaveBeenCalledTimes(1);

packages/tooling/jest/src/react-native/index.ts

@@ -6,16 +6,23 @@ import {
 } from '@launchdarkly/react-native-client-sdk';
 
 jest.mock('@launchdarkly/react-native-client-sdk', () => ({
-  LDProvider: jest.fn(),
-  ReactNativeLDClient: jest.fn(),
-  useLDClient: jest.fn(),
+  LDFlagSet: jest.fn(() => ({})),
+  LDProvider: jest.fn().mockImplementation(({ children }) => children),
+  ReactNativeLDClient: jest.fn().mockImplementation(),
+  useLDClient: jest.fn().mockImplementation(),
+  useBoolVariation: jest.fn(),
+  useBoolVariationDetail: jest.fn(),
+  useNumberVariation: jest.fn(),
+  useNumberVariationDetail: jest.fn(),
+  useStringVariation: jest.fn(),
+  useStringVariationDetail: jest.fn(),
+  useJsonVariation: jest.fn(),
+  useJsonVariationDetail: jest.fn(),
+  useTypedVariation: jest.fn(),
+  useTypedVariationDetail: jest.fn(),
 }));
 
-const mockLDProvider = LDProvider as jest.Mock;
-const mockReactNativeLDClient = ReactNativeLDClient as jest.Mock;
-const mockUseLDClient = useLDClient as jest.Mock;
-
-export const ldClientMock = {
+export const ldClientMock: any = {
   allFlags: jest.fn(),
   boolVariation: jest.fn(),
   boolVariationDetail: jest.fn(),
@@ -39,53 +46,44 @@ export const ldClientMock = {
   variationDetail: jest.fn(),
 };
 
-mockLDProvider.mockImplementation((props: any) => props.children);
-mockUseLDClient.mockImplementation(() => ldClientMock);
-mockReactNativeLDClient.mockImplementation(() => ldClientMock);
+export const mockLDProvider = LDProvider as jest.Mock;
+export const mockReactNativeLDClient = ReactNativeLDClient as jest.Mock;
+export const mockUseLDClient = useLDClient as jest.Mock;
 
-export { mockLDProvider, mockReactNativeLDClient, mockUseLDClient };
+mockLDProvider.mockImplementation(({ children }) => children);
+mockReactNativeLDClient.mockImplementation(() => ldClientMock);
+mockUseLDClient.mockImplementation(() => ldClientMock);
 
-export const mockFlags = (flags: LDFlagSet) => {
-  ldClientMock.boolVariation.mockImplementation((flagKey: string) => {
-    if (typeof flags[flagKey] !== 'boolean') {
-      throw new Error(`Flag ${flagKey} is not a boolean. Flag value, ${flags[flagKey]}`);
-    }
-    return flags[flagKey] as boolean;
-  });
-  ldClientMock.numberVariation.mockImplementation((flagKey: string) => {
-    if (typeof flags[flagKey] !== 'number') {
-      throw new Error(`Flag ${flagKey} is not a number. Flag value, ${flags[flagKey]}`);
-    }
-    return flags[flagKey] as number;
-  });
-  ldClientMock.stringVariation.mockImplementation((flagKey: string) => {
-    if (typeof flags[flagKey] !== 'string') {
-      throw new Error(`Flag ${flagKey} is not a string. Flag value, ${flags[flagKey]}`);
-    }
-    return flags[flagKey] as string;
-  });
-  ldClientMock.jsonVariation.mockImplementation((flagKey: string) => {
-    if (typeof flags[flagKey] !== 'object') {
-      throw new Error(`Flag ${flagKey} is not a JSON. Flag value, ${flags[flagKey]}`);
+export const mockFlags = (flags: LDFlagSet): any => {
+  Object.keys(flags).forEach((key) => {
+    const defaultValue = flags[key];
+    switch (typeof defaultValue) {
+      case 'boolean':
+        ldClientMock.boolVariation.mockImplementation(
+          (flagKey: string) => flags[flagKey] as boolean,
+        );
+        break;
+      case 'number':
+        ldClientMock.numberVariation.mockImplementation(
+          (flagKey: string) => flags[flagKey] as number,
+        );
+        break;
+      case 'string':
+        ldClientMock.stringVariation.mockImplementation(
+          (flagKey: string) => flags[flagKey] as string,
+        );
+        break;
+      case 'object':
+        ldClientMock.jsonVariation.mockImplementation(
+          (flagKey: string) => flags[flagKey] as object,
+        );
+        break;
+      default:
+        break;
     }
-    return flags[flagKey] as object;
   });
 };
 
 export const resetLDMocks = () => {
-  ldClientMock.allFlags.mockReset();
-  ldClientMock.boolVariation.mockReset();
-  ldClientMock.close.mockReset();
-  ldClientMock.flush.mockReset();
-  ldClientMock.getContext.mockReset();
-  ldClientMock.identify.mockReset();
-  ldClientMock.jsonVariation.mockReset();
-  ldClientMock.logger.mockReset();
-  ldClientMock.numberVariation.mockReset();
-  ldClientMock.off.mockReset();
-  ldClientMock.on.mockReset();
-  ldClientMock.setConnectionMode.mockReset();
-  ldClientMock.stringVariation.mockReset();
-  ldClientMock.track.mockReset();
-  ldClientMock.variation.mockReset();
+  jest.clearAllMocks();
 };