Tree version.

Author: kinyoklion

packages/shared/sdk-client/src/LDClientImpl.ts

@@ -565,19 +565,20 @@ export default class LDClientImpl implements LDClient {
     }
 
     successDetail.prerequisites?.forEach((prereqKey) => {
-      const prereqFlag = this.flagManager.get(prereqKey);
-      if (prereqFlag) {
-        this.eventProcessor?.sendEvent(
-          eventFactory.evalEventClient(
-            prereqKey,
-            prereqFlag.flag.value,
-            undefined,
-            prereqFlag.flag,
-            evalContext,
-            prereqFlag.flag.reason,
-          ),
-        );
-      }
+      this.variation(prereqKey, undefined);
+      // const prereqFlag = this.flagManager.get(prereqKey);
+      // if (prereqFlag) {
+      //   this.eventProcessor?.sendEvent(
+      //     eventFactory.evalEventClient(
+      //       prereqKey,
+      //       prereqFlag.flag.value,
+      //       undefined,
+      //       prereqFlag.flag,
+      //       evalContext,
+      //       prereqFlag.flag.reason,
+      //     ),
+      //   );
+      // }
     });
     this.eventProcessor?.sendEvent(
       eventFactory.evalEventClient(

packages/shared/sdk-server/__tests__/evaluation/Evaluator.prerequisite.test.ts

@@ -151,7 +151,7 @@ describe('given a flag payload with prerequisites', () => {
 
     expect(res.detail.reason.kind).toEqual('FALLTHROUGH');
 
-    expect(res.detail.prerequisites).toEqual(['is-prereq', 'has-prereq-depth-1']);
+    expect(res.detail.prerequisites).toEqual(['has-prereq-depth-1']);
   });
 
   it('can track prerequisites for a flag with multiple prereqs with and without additional prereqs', async () => {
@@ -164,9 +164,6 @@ describe('given a flag payload with prerequisites', () => {
     expect(res.detail.reason.kind).toEqual('FALLTHROUGH');
 
     expect(res.detail.prerequisites).toEqual([
-      'is-prereq',
-      'has-prereq-depth-1',
-      'is-prereq',
       'has-prereq-depth-1',
       'has-prereq-depth-2',
       'is-prereq',
@@ -184,6 +181,6 @@ describe('given a flag payload with prerequisites', () => {
     expect(res.detail.reason.kind).toEqual('PREREQUISITE_FAILED');
     expect(res.detail.reason.prerequisiteKey).toEqual('has-prereq-depth-1');
 
-    expect(res.detail.prerequisites).toEqual(['is-prereq', 'has-prereq-depth-1']);
+    expect(res.detail.prerequisites).toEqual(['has-prereq-depth-1']);
   });
 });

packages/shared/sdk-server/src/evaluation/Evaluator.ts

@@ -146,6 +146,7 @@ export default class Evaluator {
         res.events = state.events;
         cb(res);
       },
+      true,
       eventFactory,
     );
   }
@@ -166,6 +167,7 @@ export default class Evaluator {
     state: EvalState,
     visitedFlags: string[],
     cb: (res: EvalResult) => void,
+    topLevel: boolean,
     eventFactory?: EventFactory,
   ): void {
     if (!flag.on) {
@@ -201,6 +203,7 @@ export default class Evaluator {
           cb(this.variationForContext(flag.fallthrough, context, flag, Reasons.Fallthrough));
         });
       },
+      topLevel,
       eventFactory,
     );
   }
@@ -221,6 +224,7 @@ export default class Evaluator {
     state: EvalState,
     visitedFlags: string[],
     cb: (res: EvalResult | undefined) => void,
+    topLevel: boolean,
     eventFactory?: EventFactory,
   ): void {
     let prereqResult: EvalResult | undefined;
@@ -260,10 +264,12 @@ export default class Evaluator {
             (res) => {
               // eslint-disable-next-line no-param-reassign
               state.events ??= [];
-              // eslint-disable-next-line no-param-reassign
-              state.prerequisites ??= [];
+              if (topLevel) {
+                // eslint-disable-next-line no-param-reassign
+                state.prerequisites ??= [];
 
-              state.prerequisites.push(prereqFlag.key);
+                state.prerequisites.push(prereqFlag.key);
+              }
               if (eventFactory) {
                 state.events.push(
                   eventFactory.evalEventServer(prereqFlag, context, res.detail, null, flag),
@@ -281,6 +287,7 @@ export default class Evaluator {
               }
               return iterCb(true);
             },
+            false,
             eventFactory,
           );
         });