fix: Fix an error handling situation that could cause double evaluation. (#249)

kinyoklion · web-flow · commit 2c613ffc8c6e · 2023-08-24T08:59:57.000-07:00
diff --git a/packages/shared/sdk-server/src/LDClientImpl.ts b/packages/shared/sdk-server/src/LDClientImpl.ts
@@ -488,6 +488,7 @@ export default class LDClientImpl implements LDClient {
         );
         cb(EvalResult.forError(ErrorKinds.ClientNotReady, undefined, defaultValue));
       });
+      return;
     }
     this.variationInternal(flagKey, context, defaultValue, eventFactory, cb);
   }

Original file line number	Diff line number	Diff line change
`@@ -488,6 +488,7 @@ export default class LDClientImpl implements LDClient {`
`488`	`488`	`);`
`489`	`489`	`cb(EvalResult.forError(ErrorKinds.ClientNotReady, undefined, defaultValue));`
`490`	`490`	`});`
	`491`	`+ return;`
`491`	`492`	`}`
`492`	`493`	`this.variationInternal(flagKey, context, defaultValue, eventFactory, cb);`
`493`	`494`	`}`