fix: Fix default configs always being disabled (#965)

Author: jsonbailey

packages/sdk/server-ai/__tests__/LDAIClientImpl.test.ts

@@ -127,7 +127,14 @@ it('passes the default value to the underlying client', async () => {
     enabled: true,
   };
 
-  mockLdClient.variation.mockResolvedValue(defaultValue);
+  const expectedLDFlagValue = {
+    _ldMeta: { enabled: true },
+    model: defaultValue.model,
+    messages: defaultValue.messages,
+    provider: defaultValue.provider,
+  };
+
+  mockLdClient.variation.mockResolvedValue(expectedLDFlagValue);
 
   const result = await client.config(key, testContext, defaultValue);
 
@@ -136,11 +143,11 @@ it('passes the default value to the underlying client', async () => {
     messages: defaultValue.messages,
     provider: defaultValue.provider,
     tracker: expect.any(Object),
-    enabled: false,
+    enabled: defaultValue.enabled,
     toVercelAISDK: expect.any(Function),
   });
 
-  expect(mockLdClient.variation).toHaveBeenCalledWith(key, testContext, defaultValue);
+  expect(mockLdClient.variation).toHaveBeenCalledWith(key, testContext, expectedLDFlagValue);
 });
 
 // New agent-related tests
@@ -253,7 +260,14 @@ it('passes the default value to the underlying client for single agent', async (
     enabled: true,
   };
 
-  mockLdClient.variation.mockResolvedValue(defaultValue);
+  const expectedLDFlagValue = {
+    _ldMeta: { enabled: defaultValue.enabled },
+    model: defaultValue.model,
+    provider: defaultValue.provider,
+    instructions: defaultValue.instructions,
+  };
+
+  mockLdClient.variation.mockResolvedValue(expectedLDFlagValue);
 
   const result = await client.agent(key, testContext, defaultValue);
 
@@ -262,10 +276,10 @@ it('passes the default value to the underlying client for single agent', async (
     instructions: defaultValue.instructions,
     provider: defaultValue.provider,
     tracker: expect.any(Object),
-    enabled: false,
+    enabled: defaultValue.enabled,
   });
 
-  expect(mockLdClient.variation).toHaveBeenCalledWith(key, testContext, defaultValue);
+  expect(mockLdClient.variation).toHaveBeenCalledWith(key, testContext, expectedLDFlagValue);
 });
 
 it('returns multiple agents config with interpolated instructions', async () => {

packages/sdk/server-ai/src/LDAIClientImpl.ts

@@ -69,12 +69,32 @@ export class LDAIClientImpl implements LDAIClient {
     return Mustache.render(template, variables, undefined, { escape: (item: any) => item });
   }
 
+  private static _toLDFlagValue(defaultValue: LDAIDefaults | LDAIAgentDefaults): {
+    _ldMeta: { enabled: boolean };
+    model?: LDModelConfig;
+    messages?: LDMessage[];
+    provider?: LDProviderConfig;
+    instructions?: string;
+  } {
+    return {
+      _ldMeta: { enabled: defaultValue.enabled ?? false },
+      model: defaultValue.model,
+      messages: 'messages' in defaultValue ? defaultValue.messages : undefined,
+      provider: defaultValue.provider,
+      instructions: 'instructions' in defaultValue ? defaultValue.instructions : undefined,
+    };
+  }
+
   private async _evaluate(
     key: string,
     context: LDContext,
     defaultValue: LDAIDefaults,
   ): Promise<EvaluationResult> {
-    const value: VariationContent = await this._ldClient.variation(key, context, defaultValue);
+    // Convert default value to LDFlagValue format
+    // eslint-disable-next-line no-underscore-dangle
+    const ldFlagValue = LDAIClientImpl._toLDFlagValue(defaultValue);
+
+    const value: VariationContent = await this._ldClient.variation(key, context, ldFlagValue);
 
     const tracker = new LDAIConfigTrackerImpl(
       this._ldClient,
@@ -109,11 +129,13 @@ export class LDAIClientImpl implements LDAIClient {
     defaultValue: LDAIAgentDefaults,
     variables?: Record<string, unknown>,
   ): Promise<LDAIAgent> {
-    const { tracker, enabled, model, provider, instructions } = await this._evaluate(
-      key,
-      context,
-      defaultValue,
-    );
+    const {
+      tracker,
+      enabled,
+      model,
+      provider: configProvider,
+      instructions,
+    } = await this._evaluate(key, context, defaultValue);
 
     const agent: LDAIAgent = {
       tracker,
@@ -126,8 +148,8 @@ export class LDAIClientImpl implements LDAIClient {
       agent.model = { ...model };
     }
 
-    if (provider) {
-      agent.provider = { ...provider };
+    if (configProvider) {
+      agent.provider = { ...configProvider };
     }
 
     const allVariables = { ...variables, ldctx: context };