pr feedback, cleanup, fixing tests

Author: jsonbailey

packages/sdk/server-ai/__tests__/LDAIClientImpl.test.ts

@@ -62,7 +62,7 @@ export class LDAIClientImpl implements LDAIClient {
 
     // Validate mode match
     // eslint-disable-next-line no-underscore-dangle
-    const flagMode = value._ldMeta?.mode;
+    const flagMode = value._ldMeta?.mode ?? 'completion';
     if (flagMode !== mode) {
       this._logger?.warn(
         `AI Config mode mismatch for ${key}: expected ${mode}, got ${flagMode}. Returning disabled config.`,

packages/sdk/server-ai/src/LDAIClientImpl.ts

@@ -238,6 +238,9 @@ export interface LDAIClient {
    * @param context The standard LDContext used when evaluating flags.
    * @param defaultValue A default value representing a standard AI chat config result.
    * @param variables Dictionary of values for instruction interpolation.
+   * The variables will also be used for judge evaluation. For the judge only, the variables
+   * `message_history` and `response_to_evaluate` are reserved and will be ignored.
+   * @param defaultAiProvider Optional default AI provider to use.
    * @returns A promise that resolves to the TrackedChat instance, or null if the configuration is disabled.
    *
    * @example
@@ -258,10 +261,6 @@ export interface LDAIClient {
    * if (chat) {
    *   const response = await chat.invoke("I need help with my order");
    *   console.log(response.message.content);
-   *
-   *   // Access configuration and tracker if needed
-   *   console.log('Model:', chat.getConfig().model?.name);
-   *   chat.getTracker().trackSuccess();
    * }
    * ```
    */
@@ -290,7 +289,9 @@ export interface LDAIClient {
    * @param key The key identifying the AI judge configuration to use
    * @param context Standard LDContext used when evaluating flags
    * @param defaultValue A default value representing a standard AI config result
-   * @param variables Dictionary of values for instruction interpolation
+   * @param variables Dictionary of values for instruction interpolation.
+   * The variables `message_history` and `response_to_evaluate` are reserved for the judge and will be ignored.
+   * @param defaultAiProvider Optional default AI provider to use.
    * @returns Promise that resolves to a Judge instance or undefined if disabled/unsupported
    *
    * @example

packages/sdk/server-ai/src/api/LDAIClient.ts

@@ -15,19 +15,15 @@ import { ChatResponse } from './types';
  */
 export class TrackedChat {
   protected messages: LDMessage[];
-  protected judges: Record<string, Judge>;
-  private readonly _logger?: LDLogger;
 
   constructor(
     protected readonly aiConfig: LDAICompletionConfig,
     protected readonly tracker: LDAIConfigTracker,
     protected readonly provider: AIProvider,
-    judges?: Record<string, Judge>,
-    logger?: LDLogger,
+    protected readonly judges: Record<string, Judge> = {},
+    private readonly _logger?: LDLogger,
   ) {
     this.messages = [];
-    this.judges = judges || {};
-    this._logger = logger;
   }
 
   /**
@@ -93,16 +89,14 @@ export class TrackedChat {
 
       const evalResult = await judge.evaluateMessages(messages, response, judgeConfig.samplingRate);
 
-      // Track scores if evaluation was successful
       if (evalResult && evalResult.success) {
         this.tracker.trackEvalScores(evalResult.evals);
       }
 
       return evalResult;
     });
 
-    // Use Promise.allSettled to ensure all evaluations complete
-    // even if some fail
+    // ensure all evaluations complete even if some fail
     const results = await Promise.allSettled(evaluationPromises);
 
     return results.map((result) => (result.status === 'fulfilled' ? result.value : undefined));

packages/sdk/server-ai/src/api/chat/TrackedChat.ts

@@ -87,7 +87,6 @@ export class LDAIConfigUtils {
     // eslint-disable-next-line no-underscore-dangle
     const flagValueMode = flagValue._ldMeta?.mode;
 
-    // Convert to appropriate config type based on actual mode
     switch (flagValueMode) {
       case 'agent':
         return this.toAgentConfig(flagValue, tracker);

packages/sdk/server-ai/src/api/config/LDAIConfigUtils.ts

@@ -1,6 +1,24 @@
 import { LDAIConfigTracker } from './LDAIConfigTracker';
 import { VercelAISDKConfig, VercelAISDKMapOptions, VercelAISDKProvider } from './VercelAISDK';
 
+// ============================================================================
+// Foundation Types
+// ============================================================================
+
+/**
+ * Information about prompts.
+ */
+export interface LDMessage {
+  /**
+   * The role of the prompt.
+   */
+  role: 'user' | 'assistant' | 'system';
+  /**
+   * Content for the prompt.
+   */
+  content: string;
+}
+
 /**
  * Configuration related to the model.
  */
@@ -28,6 +46,10 @@ export interface LDProviderConfig {
   name: string;
 }
 
+// ============================================================================
+// Judge Types
+// ============================================================================
+
 /**
  * Configuration for a single judge attachment.
  */
@@ -46,6 +68,30 @@ export interface LDJudgeConfiguration {
   judges: LDJudge[];
 }
 
+// ============================================================================
+// Base AI Config Types
+// ============================================================================
+
+/**
+ * Base AI Config interface for default implementations with optional enabled property.
+ */
+export interface LDAIConfigDefault {
+  /**
+   * Optional model configuration.
+   */
+  model?: LDModelConfig;
+
+  /**
+   * Optional configuration for the provider.
+   */
+  provider?: LDProviderConfig;
+
+  /**
+   * Whether the configuration is enabled. Defaults to false when not provided.
+   */
+  enabled?: boolean;
+}
+
 /**
  * Base AI Config interface without mode-specific fields.
  */
@@ -81,44 +127,9 @@ export interface LDAIConfig extends Omit<LDAIConfigDefault, 'enabled'> {
   ) => VercelAISDKConfig<TMod>;
 }
 
-/**
- * Base AI Config interface for default implementations with optional enabled property.
- */
-export interface LDAIConfigDefault {
-  /**
-   * Optional model configuration.
-   */
-  model?: LDModelConfig;
-
-  /**
-   * Optional configuration for the provider.
-   */
-  provider?: LDProviderConfig;
-
-  /**
-   * Whether the configuration is enabled. Defaults to false when not provided.
-   */
-  enabled?: boolean;
-}
-
-/**
- * Default implementation types for AI Configs with optional enabled property.
- */
-
-/**
- * Default Judge-specific AI Config with required evaluation metric key.
- */
-export interface LDAIJudgeConfigDefault extends LDAIConfigDefault {
-  /**
-   * Optional prompt data for judge configurations.
-   */
-  messages?: LDMessage[];
-  /**
-   * Evaluation metric keys for judge configurations.
-   * The keys of the metrics that this judge can evaluate.
-   */
-  evaluationMetricKeys?: string[];
-}
+// ============================================================================
+// Default AI Config Implementation Types
+// ============================================================================
 
 /**
  * Default Agent-specific AI Config with instructions.
@@ -151,13 +162,9 @@ export interface LDAICompletionConfigDefault extends LDAIConfigDefault {
 }
 
 /**
- * Non-default implementation types for AI Configs with required enabled property and tracker.
- */
-
-/**
- * Judge-specific AI Config with required evaluation metric key.
+ * Default Judge-specific AI Config with required evaluation metric key.
  */
-export interface LDAIJudgeConfig extends LDAIConfig {
+export interface LDAIJudgeConfigDefault extends LDAIConfigDefault {
   /**
    * Optional prompt data for judge configurations.
    */
@@ -166,9 +173,21 @@ export interface LDAIJudgeConfig extends LDAIConfig {
    * Evaluation metric keys for judge configurations.
    * The keys of the metrics that this judge can evaluate.
    */
-  evaluationMetricKeys: string[];
+  evaluationMetricKeys?: string[];
 }
 
+/**
+ * Union type for all default AI Config variants.
+ */
+export type LDAIConfigDefaultKind =
+  | LDAIAgentConfigDefault
+  | LDAICompletionConfigDefault
+  | LDAIJudgeConfigDefault;
+
+// ============================================================================
+// AI Config Implementation Types
+// ============================================================================
+
 /**
  * Agent-specific AI Config with instructions.
  */
@@ -200,31 +219,32 @@ export interface LDAICompletionConfig extends LDAIConfig {
 }
 
 /**
- * Information about prompts.
+ * Judge-specific AI Config with required evaluation metric key.
  */
-export interface LDMessage {
+export interface LDAIJudgeConfig extends LDAIConfig {
   /**
-   * The role of the prompt.
+   * Optional prompt data for judge configurations.
    */
-  role: 'user' | 'assistant' | 'system';
+  messages?: LDMessage[];
   /**
-   * Content for the prompt.
+   * Evaluation metric keys for judge configurations.
+   * The keys of the metrics that this judge can evaluate.
    */
-  content: string;
+  evaluationMetricKeys: string[];
 }
 
+// ============================================================================
+// Union Types
+// ============================================================================
+
 /**
  * Union type for all AI Config variants.
  */
-export type LDAIConfigKind = LDAICompletionConfig | LDAIAgentConfig | LDAIJudgeConfig;
+export type LDAIConfigKind = LDAIAgentConfig | LDAICompletionConfig | LDAIJudgeConfig;
 
-/**
- * Union type for all default AI Config variants.
- */
-export type LDAIConfigDefaultKind =
-  | LDAICompletionConfigDefault
-  | LDAIAgentConfigDefault
-  | LDAIJudgeConfigDefault;
+// ============================================================================
+// Agent-Specific Request Type
+// ============================================================================
 
 /**
  * Configuration for a single agent request.
@@ -246,15 +266,9 @@ export interface LDAIAgentRequestConfig {
   variables?: Record<string, unknown>;
 }
 
-/**
- * AI Config agent interface (extends agent config without tracker and toVercelAISDK).
- */
-export interface LDAIAgent extends Omit<LDAIAgentConfig, 'toVercelAISDK' | 'tracker'> {
-  /**
-   * Instructions for the agent.
-   */
-  instructions?: string;
-}
+// ============================================================================
+// Mode Type
+// ============================================================================
 
 /**
  * Mode type for AI configurations.