set defaults for ai provider and adjust some type names for ai sdk

Author: jsonbailey

packages/sdk/server-ai/src/LDAIClientImpl.ts

@@ -7,7 +7,8 @@ import {
   LDAIAgentConfig,
   LDAIAgentConfigDefault,
   LDAIAgentRequestConfig,
-  LDAIConfigKindDefault,
+  LDAIConfigDefaultKind,
+  LDAIConfigKind,
   LDAIConversationConfig,
   LDAIConversationConfigDefault,
   LDAIJudgeConfig,
@@ -39,10 +40,10 @@ export class LDAIClientImpl implements LDAIClient {
   private async _evaluate(
     key: string,
     context: LDContext,
-    defaultValue: LDAIConfigKindDefault,
+    defaultValue: LDAIConfigDefaultKind,
     mode: 'completion' | 'agent' | 'judge',
     variables?: Record<string, unknown>,
-  ): Promise<LDAIConversationConfig | LDAIAgentConfig | LDAIJudgeConfig> {
+  ): Promise<LDAIConfigKind> {
     // Convert default value to LDFlagValue format
     const ldFlagValue = LDAIConfigUtils.toFlagValue(defaultValue, mode);
 

packages/sdk/server-ai/src/api/config/LDAIConfigUtils.ts

@@ -1,7 +1,7 @@
 import { LDAIConfigTracker } from './LDAIConfigTracker';
 import {
   LDAIAgentConfig,
-  LDAIConfigKindDefault,
+  LDAIConfigDefaultKind,
   LDAIConversationConfig,
   LDAIJudgeConfig,
   LDJudgeConfiguration,
@@ -45,7 +45,7 @@ export class LDAIConfigUtils {
    * @returns The flag value structure for LaunchDarkly
    */
   static toFlagValue(
-    config: LDAIConfigKindDefault,
+    config: LDAIConfigDefaultKind,
     mode: 'completion' | 'agent' | 'judge',
   ): LDAIConfigFlagValue {
     return {

packages/sdk/server-ai/src/api/config/types.ts

@@ -49,7 +49,7 @@ export interface LDJudgeConfiguration {
 /**
  * Base AI Config interface without mode-specific fields.
  */
-export interface LDAIConfigBase extends Omit<LDAIConfigBaseDefault, 'enabled'> {
+export interface LDAIConfig extends Omit<LDAIConfigDefault, 'enabled'> {
   /**
    * Whether the configuration is enabled.
    */
@@ -81,7 +81,7 @@ export interface LDAIConfigBase extends Omit<LDAIConfigBaseDefault, 'enabled'> {
 /**
  * Base AI Config interface for default implementations with optional enabled property.
  */
-export interface LDAIConfigBaseDefault {
+export interface LDAIConfigDefault {
   /**
    * Optional model configuration.
    */
@@ -105,7 +105,7 @@ export interface LDAIConfigBaseDefault {
 /**
  * Default Judge-specific AI Config with required evaluation metric key.
  */
-export interface LDAIJudgeConfigDefault extends LDAIConfigBaseDefault {
+export interface LDAIJudgeConfigDefault extends LDAIConfigDefault {
   /**
    * Optional prompt data for judge configurations.
    */
@@ -120,7 +120,7 @@ export interface LDAIJudgeConfigDefault extends LDAIConfigBaseDefault {
 /**
  * Default Agent-specific AI Config with instructions.
  */
-export interface LDAIAgentConfigDefault extends LDAIConfigBaseDefault {
+export interface LDAIAgentConfigDefault extends LDAIConfigDefault {
   /**
    * Instructions for the agent.
    */
@@ -135,7 +135,7 @@ export interface LDAIAgentConfigDefault extends LDAIConfigBaseDefault {
 /**
  * Default Completion AI Config (default mode).
  */
-export interface LDAIConversationConfigDefault extends LDAIConfigBaseDefault {
+export interface LDAIConversationConfigDefault extends LDAIConfigDefault {
   /**
    * Optional prompt data for completion configurations.
    */
@@ -154,7 +154,7 @@ export interface LDAIConversationConfigDefault extends LDAIConfigBaseDefault {
 /**
  * Judge-specific AI Config with required evaluation metric key.
  */
-export interface LDAIJudgeConfig extends LDAIConfigBase {
+export interface LDAIJudgeConfig extends LDAIConfig {
   /**
    * Optional prompt data for judge configurations.
    */
@@ -169,7 +169,7 @@ export interface LDAIJudgeConfig extends LDAIConfigBase {
 /**
  * Agent-specific AI Config with instructions.
  */
-export interface LDAIAgentConfig extends LDAIConfigBase {
+export interface LDAIAgentConfig extends LDAIConfig {
   /**
    * Instructions for the agent.
    */
@@ -184,7 +184,7 @@ export interface LDAIAgentConfig extends LDAIConfigBase {
 /**
  * Completion AI Config (default mode).
  */
-export interface LDAIConversationConfig extends LDAIConfigBase {
+export interface LDAIConversationConfig extends LDAIConfig {
   /**
    * Optional prompt data for completion configurations.
    */
@@ -218,7 +218,7 @@ export type LDAIConfigKind = LDAIConversationConfig | LDAIAgentConfig | LDAIJudg
 /**
  * Union type for all default AI Config variants.
  */
-export type LDAIConfigKindDefault =
+export type LDAIConfigDefaultKind =
   | LDAIConversationConfigDefault
   | LDAIAgentConfigDefault
   | LDAIJudgeConfigDefault;

packages/sdk/server-ai/src/api/providers/AIProvider.ts

@@ -1,7 +1,7 @@
 import { LDLogger } from '@launchdarkly/js-server-sdk-common';
 
 import { ChatResponse } from '../chat/types';
-import { LDAIConfigKind, LDMessage } from '../config/types';
+import { LDAIConfig, LDMessage } from '../config/types';
 import { StructuredResponse } from '../judge/types';
 
 /**
@@ -23,24 +23,60 @@ export abstract class AIProvider {
    * This method should convert messages to provider format, invoke the model,
    * and return a ChatResponse with the result and metrics.
    *
+   * Default implementation takes no action and returns a placeholder response.
+   * Provider implementations should override this method.
+   *
    * @param messages Array of LDMessage objects representing the conversation
    * @returns Promise that resolves to a ChatResponse containing the model's response
    */
-  abstract invokeModel(messages: LDMessage[]): Promise<ChatResponse>;
+  async invokeModel(_messages: LDMessage[]): Promise<ChatResponse> {
+    this.logger?.warn('invokeModel not implemented by this provider');
+    return {
+      message: {
+        role: 'assistant',
+        content: '',
+      },
+      metrics: {
+        success: false,
+        usage: {
+          total: 0,
+          input: 0,
+          output: 0,
+        },
+      },
+    };
+  }
 
   /**
    * Invoke the chat model with structured output support.
    * This method should convert messages to provider format, invoke the model with
    * structured output configuration, and return a structured response.
    *
+   * Default implementation takes no action and returns a placeholder response.
+   * Provider implementations should override this method.
+   *
    * @param messages Array of LDMessage objects representing the conversation
-   * @param outputs Dictionary of output configurations keyed by output name
+   * @param responseStructure Dictionary of output configurations keyed by output name
    * @returns Promise that resolves to a structured response
    */
-  abstract invokeStructuredModel(
-    messages: LDMessage[],
-    responseStructure: Record<string, unknown>,
-  ): Promise<StructuredResponse>;
+  async invokeStructuredModel(
+    _messages: LDMessage[],
+    _responseStructure: Record<string, unknown>,
+  ): Promise<StructuredResponse> {
+    this.logger?.warn('invokeStructuredModel not implemented by this provider');
+    return {
+      data: {},
+      rawResponse: '',
+      metrics: {
+        success: false,
+        usage: {
+          total: 0,
+          input: 0,
+          output: 0,
+        },
+      },
+    };
+  }
 
   /**
    * Static method that constructs an instance of the provider.
@@ -52,7 +88,7 @@ export abstract class AIProvider {
    * @returns Promise that resolves to a configured provider instance
    */
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  static async create(aiConfig: LDAIConfigKind, logger?: LDLogger): Promise<AIProvider> {
+  static async create(aiConfig: LDAIConfig, logger?: LDLogger): Promise<AIProvider> {
     throw new Error('Provider implementations must override the static create method');
   }
 }