Skip to content

Commit 5064806

Browse files
committed
Remove unused options from test.
1 parent 3b7030b commit 5064806

File tree

2 files changed

+16
-26
lines changed

2 files changed

+16
-26
lines changed

packages/telemetry/browser-telemetry/__tests__/BrowserTelemetryImpl.test.ts

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -215,17 +215,6 @@ it('logs event dropped message when maxPendingEvents is reached', () => {
215215
};
216216
const telemetry = new BrowserTelemetryImpl({
217217
...defaultOptions,
218-
breadcrumbs: {
219-
maxBreadcrumbs: 2,
220-
click: false,
221-
keyboardInput: false,
222-
http: {
223-
instrumentFetch: false,
224-
instrumentXhr: false,
225-
},
226-
evaluations: false,
227-
flagChange: false,
228-
},
229218
maxPendingEvents: 2,
230219
logger: mockLogger,
231220
});
@@ -237,8 +226,9 @@ it('logs event dropped message when maxPendingEvents is reached', () => {
237226
telemetry.captureError(new Error('Test error 3'));
238227
expect(mockLogger.warn).toHaveBeenCalledWith(
239228
'LaunchDarkly - Browser Telemetry: Maximim pending events reached. Old events will be dropped until the SDK' +
240-
' client is registered.');
229+
' client is registered.',
230+
);
241231

242232
telemetry.captureError(new Error('Test error 4'));
243-
expect(mockLogger.warn).toHaveBeenCalledTimes(1)
233+
expect(mockLogger.warn).toHaveBeenCalledTimes(1);
244234
});

packages/telemetry/browser-telemetry/src/BrowserTelemetryImpl.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -190,20 +190,20 @@ export default class BrowserTelemetryImpl implements BrowserTelemetry {
190190

191191
const data: ErrorData = validException
192192
? {
193-
type: exception.name || exception.constructor?.name || GENERIC_EXCEPTION,
194-
// Only coalesce null/undefined, not empty.
195-
message: exception.message ?? MISSING_MESSAGE,
196-
stack: parse(exception, this._options.stack),
197-
breadcrumbs: [...this._breadcrumbs],
198-
sessionId: this._sessionId,
199-
}
193+
type: exception.name || exception.constructor?.name || GENERIC_EXCEPTION,
194+
// Only coalesce null/undefined, not empty.
195+
message: exception.message ?? MISSING_MESSAGE,
196+
stack: parse(exception, this._options.stack),
197+
breadcrumbs: [...this._breadcrumbs],
198+
sessionId: this._sessionId,
199+
}
200200
: {
201-
type: GENERIC_EXCEPTION,
202-
message: NULL_EXCEPTION_MESSAGE,
203-
stack: { frames: [] },
204-
breadcrumbs: [...this._breadcrumbs],
205-
sessionId: this._sessionId,
206-
};
201+
type: GENERIC_EXCEPTION,
202+
message: NULL_EXCEPTION_MESSAGE,
203+
stack: { frames: [] },
204+
breadcrumbs: [...this._breadcrumbs],
205+
sessionId: this._sessionId,
206+
};
207207
this._capture(ERROR_KEY, data);
208208
}
209209

0 commit comments

Comments
 (0)