Skip to content

Commit 58da14a

Browse files
Todd AndersonTodd Anderson
authored andcommitted
Fixing merge issue and spelling mistakes
1 parent bc55fc1 commit 58da14a

File tree

3 files changed

+2
-22
lines changed

3 files changed

+2
-22
lines changed

packages/shared/common/__tests__/internal/fdv2/PayloadReader.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ it('it includes multiple types of updates in payload', () => {
137137
expect(receivedPayloads[0].updates[2].deleted).toEqual(undefined);
138138
});
139139

140-
it('it does not include messages thats are not between server-intent and payloader-transferred', () => {
140+
it('it does not include messages thats are not between server-intent and payload-transferred', () => {
141141
const mockStream = new MockEventStream();
142142
const receivedPayloads: Payload[] = [];
143143
const readerUnderTest = new PayloadReader(mockStream, {

packages/shared/common/src/internal/fdv2/payloadReader.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ export class PayloadReader {
176176
private _processPayloadTransferred = (data: PayloadTransferred) => {
177177
// if the following properties haven't been provided by now, we should reset
178178
if (
179-
!this._tempId || // server intent hasn't been recieved yet.
179+
!this._tempId || // server intent hasn't been received yet.
180180
!data.state ||
181181
!data.version
182182
) {

packages/shared/sdk-server/src/api/options/LDOptions.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@ export interface LDOptions {
7070
* Some implementations provide the store implementation object itself, while others
7171
* provide a factory function that creates the store implementation based on the SDK
7272
* configuration; this property accepts either.
73-
*
74-
* @deprecated This is now superceded by {@link LDOptions#dataSystem} using property
75-
* {@link LDDataSystemOptions#persistentStore}. The scope of the {@link LDFeatureStore}
76-
* that you provide is being reduced in the next major version to only being responsible
77-
* for persistence. See documention on {@link LDDataSystemOptions#persistentStore} for
78-
* more information.
7973
*/
8074
featureStore?: LDFeatureStore | ((clientContext: LDClientContext) => LDFeatureStore);
8175

@@ -166,11 +160,6 @@ export interface LDOptions {
166160
*
167161
* This is true by default. If you set it to false, the client will use polling.
168162
* Streaming should only be disabled on the advice of LaunchDarkly support.
169-
*
170-
* @deprecated This functionality is now controlled by {@link LDOptions#dataSystem}
171-
* by specifying {@link LDDataSystemOptions#dataSource} options. To opt out of
172-
* streaming, you can use the {@link PollingDataSourceOptions}. Streaming should
173-
* only be disabled on the advice of LaunchDarkly support.
174163
*/
175164
stream?: boolean;
176165

@@ -184,12 +173,6 @@ export interface LDOptions {
184173
* increase exponentially for any subsequent connection failures.
185174
*
186175
* The default value is 1.
187-
*
188-
*
189-
* @deprecated This functionality is now controlled by {@link LDOptions#dataSystem}
190-
* by specifying {@link LDDataSystemOptions#dataSource} options. Specifying the reconnect
191-
* delay is still available when using {@link StandardDataSourceOptions} or
192-
* {@link StreamingDataSourceOptions}.
193176
*/
194177
streamInitialReconnectDelay?: number;
195178

@@ -201,9 +184,6 @@ export interface LDOptions {
201184
* In this configuration, the client will not connect to LaunchDarkly to get feature flags,
202185
* but will instead get feature state from a database (Redis or another supported feature
203186
* store integration) that is populated by the relay. By default, this is false.
204-
*
205-
* @deprecated This functionality is now controlled by {@link LDOptions#dataSystem}
206-
* by specifying {@link LDDataSystemOptions#useLdd}.
207187
*/
208188
useLdd?: boolean;
209189

0 commit comments

Comments
 (0)