Skip to content

Commit 58dfec6

Browse files
ctawiahkinyoklion
andauthored
feat: Upgrade edgekv bundled files to 0.6.3 (#610)
**Requirements** - [ ] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** Provide links to any issues in this repository or elsewhere relating to this pull request. **Describe the solution you've provided** Provide a clear and concise description of what you expect to happen. **Describe alternatives you've considered** Provide a clear and concise description of any alternative solutions or features you've considered. **Additional context** Add any other context about the pull request here. --------- Co-authored-by: Ryan Lamb <[email protected]>
1 parent aafd1a5 commit 58dfec6

File tree

4 files changed

+371
-414
lines changed

4 files changed

+371
-414
lines changed

packages/sdk/akamai-edgekv/__tests__/edgekv/edgeKVProvider.test.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import { LDLogger } from '@launchdarkly/js-server-sdk-common';
2+
13
import { EdgeKV } from '../../src/edgekv/edgekv';
24
import EdgeKVProvider from '../../src/edgekv/edgeKVProvider';
35

@@ -11,14 +13,21 @@ const NAMESPACE = 'namespace';
1113
const GROUP = 'group';
1214

1315
describe('EdgeKVProvider', () => {
16+
let logger: LDLogger;
1417
beforeEach(() => {
1518
mockEdgeKV.mockImplementation(() => ({
1619
getText: jest.fn().mockResolvedValue('some-text'),
1720
}));
21+
logger = {
22+
debug: jest.fn(),
23+
info: jest.fn(),
24+
warn: jest.fn(),
25+
error: jest.fn(),
26+
};
1827
});
1928

2029
it('get string from edgeKV', async () => {
21-
const edgeKVProvider = new EdgeKVProvider({ namespace: NAMESPACE, group: GROUP });
30+
const edgeKVProvider = new EdgeKVProvider({ namespace: NAMESPACE, group: GROUP, logger });
2231
expect(await edgeKVProvider.get('rootKey')).toEqual('some-text');
2332
});
2433

@@ -28,7 +37,7 @@ describe('EdgeKVProvider', () => {
2837
getText: jest.fn().mockRejectedValueOnce(expectedError),
2938
}));
3039

31-
const edgeKVProvider = new EdgeKVProvider({ namespace: NAMESPACE, group: GROUP });
40+
const edgeKVProvider = new EdgeKVProvider({ namespace: NAMESPACE, group: GROUP, logger });
3241
const result = await edgeKVProvider.get('rootKey');
3342
expect(result).toBe(undefined);
3443
});

packages/sdk/akamai-edgekv/src/edgekv/edgeKVProvider.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,28 @@
11
import { EdgeProvider } from '@launchdarkly/akamai-edgeworker-sdk-common';
2+
import { LDLogger } from '@launchdarkly/js-server-sdk-common';
23

34
import { EdgeKV } from './edgekv';
45

56
type EdgeKVProviderParams = {
67
namespace: string;
78
group: string;
9+
logger: LDLogger;
810
};
911

1012
export default class EdgeKVProvider implements EdgeProvider {
1113
private _edgeKv: EdgeKV;
14+
private _logger: LDLogger;
1215

13-
constructor({ namespace, group }: EdgeKVProviderParams) {
16+
constructor({ namespace, group, logger }: EdgeKVProviderParams) {
1417
this._edgeKv = new EdgeKV({ namespace, group } as any);
18+
this._logger = logger;
1519
}
1620

1721
async get(rootKey: string): Promise<string | null | undefined> {
1822
try {
1923
return await this._edgeKv.getText({ item: rootKey } as any);
2024
} catch (e) {
21-
/* empty */
25+
this._logger?.error(`Error getting value from EdgeKV: ${e}`);
2226
}
2327
return undefined;
2428
}

0 commit comments

Comments
 (0)