Skip to content

Commit 6951966

Browse files
committed
Add log tag for mobile data manager.
1 parent 72139de commit 6951966

File tree

2 files changed

+21
-11
lines changed

2 files changed

+21
-11
lines changed

packages/sdk/react-native/__tests__/MobileDataManager.test.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ describe('given a MobileDataManager with mocked dependencies', () => {
177177
const initialMode = mobileDataManager.getConnectionMode();
178178
await mobileDataManager.setConnectionMode(initialMode);
179179
expect(logger.debug).toHaveBeenCalledWith(
180-
`setConnectionMode ignored. Mode is already '${initialMode}'.`,
180+
`[MobileDataManager] setConnectionMode ignored. Mode is already '${initialMode}'.`,
181181
);
182182
expect(mobileDataManager.getConnectionMode()).toBe(initialMode);
183183
});
@@ -231,7 +231,9 @@ describe('given a MobileDataManager with mocked dependencies', () => {
231231

232232
await mobileDataManager.identify(identifyResolve, identifyReject, context, identifyOptions);
233233

234-
expect(logger.debug).toHaveBeenCalledWith('Identify completing with cached flags');
234+
expect(logger.debug).toHaveBeenCalledWith(
235+
'[MobileDataManager] Identify completing with cached flags',
236+
);
235237

236238
expect(flagManager.loadCached).toHaveBeenCalledWith(context);
237239
expect(identifyResolve).toHaveBeenCalled();
@@ -248,7 +250,7 @@ describe('given a MobileDataManager with mocked dependencies', () => {
248250
await mobileDataManager.identify(identifyResolve, identifyReject, context, identifyOptions);
249251

250252
expect(logger.debug).toHaveBeenCalledWith(
251-
'Identify - Flags loaded from cache, but identify was requested with "waitForNetworkResults"',
253+
'[MobileDataManager] Identify - Flags loaded from cache, but identify was requested with "waitForNetworkResults"',
252254
);
253255

254256
expect(flagManager.loadCached).toHaveBeenCalledWith(context);
@@ -268,7 +270,7 @@ describe('given a MobileDataManager with mocked dependencies', () => {
268270
await mobileDataManager.identify(identifyResolve, identifyReject, context, identifyOptions);
269271

270272
expect(logger.debug).toHaveBeenCalledWith(
271-
'Offline identify - no cached flags, using defaults or already loaded flags.',
273+
'[MobileDataManager] Offline identify - no cached flags, using defaults or already loaded flags.',
272274
);
273275

274276
expect(flagManager.loadCached).toHaveBeenCalledWith(context);
@@ -287,7 +289,9 @@ describe('given a MobileDataManager with mocked dependencies', () => {
287289

288290
await mobileDataManager.identify(identifyResolve, identifyReject, context, identifyOptions);
289291

290-
expect(logger.debug).toHaveBeenCalledWith('Offline identify - using cached flags.');
292+
expect(logger.debug).toHaveBeenCalledWith(
293+
'[MobileDataManager] Offline identify - using cached flags.',
294+
);
291295

292296
expect(flagManager.loadCached).toHaveBeenCalledWith(context);
293297
expect(identifyResolve).toHaveBeenCalled();

packages/sdk/react-native/src/MobileDataManager.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ import {
1414

1515
import { ValidatedOptions } from './options';
1616

17+
const logTag = '[MobileDataManager]';
18+
1719
export default class MobileDataManager extends BaseDataManager {
1820
// Not implemented yet.
1921
protected networkAvailable: boolean = true;
@@ -45,6 +47,10 @@ export default class MobileDataManager extends BaseDataManager {
4547
this.connectionMode = rnConfig.initialConnectionMode;
4648
}
4749

50+
private debugLog(message: any, ...args: any[]) {
51+
this.logger.debug(`${logTag} ${message}`, ...args);
52+
}
53+
4854
override async identify(
4955
identifyResolve: () => void,
5056
identifyReject: (err: Error) => void,
@@ -58,20 +64,20 @@ export default class MobileDataManager extends BaseDataManager {
5864

5965
const loadedFromCache = await this.flagManager.loadCached(context);
6066
if (loadedFromCache && !waitForNetworkResults) {
61-
this.logger.debug('Identify completing with cached flags');
67+
this.debugLog('Identify completing with cached flags');
6268
identifyResolve();
6369
}
6470
if (loadedFromCache && waitForNetworkResults) {
65-
this.logger.debug(
71+
this.debugLog(
6672
'Identify - Flags loaded from cache, but identify was requested with "waitForNetworkResults"',
6773
);
6874
}
6975

7076
if (this.connectionMode === 'offline') {
7177
if (loadedFromCache) {
72-
this.logger.debug('Offline identify - using cached flags.');
78+
this.debugLog('Offline identify - using cached flags.');
7379
} else {
74-
this.logger.debug(
80+
this.debugLog(
7581
'Offline identify - no cached flags, using defaults or already loaded flags.',
7682
);
7783
identifyResolve();
@@ -109,12 +115,12 @@ export default class MobileDataManager extends BaseDataManager {
109115

110116
async setConnectionMode(mode: ConnectionMode): Promise<void> {
111117
if (this.connectionMode === mode) {
112-
this.logger.debug(`setConnectionMode ignored. Mode is already '${mode}'.`);
118+
this.debugLog(`setConnectionMode ignored. Mode is already '${mode}'.`);
113119
return;
114120
}
115121

116122
this.connectionMode = mode;
117-
this.logger.debug(`setConnectionMode ${mode}.`);
123+
this.debugLog(`setConnectionMode ${mode}.`);
118124

119125
switch (mode) {
120126
case 'offline':

0 commit comments

Comments
 (0)