chore: fix lint issues

Author: joker23

packages/sdk/browser/src/BrowserClient.ts

@@ -138,10 +138,9 @@ class BrowserClientImpl extends LDClientImpl {
           diagnosticsManager,
         ),
       {
-        getLegacyStorageKeys: () => {
-          // This logic is derived from https://github.com/launchdarkly/js-sdk-common/blob/main/src/PersistentFlagStore.js
-          return getAllStorageKeys().filter((key) => key.startsWith(`ld:${clientSideId}:`));
-        },
+        // This logic is derived from https://github.com/launchdarkly/js-sdk-common/blob/main/src/PersistentFlagStore.js
+        getLegacyStorageKeys: () =>
+          getAllStorageKeys().filter((key) => key.startsWith(`ld:${clientSideId}:`)),
         analyticsEventPath: `/events/bulk/${clientSideId}`,
         diagnosticEventPath: `/events/diagnostic/${clientSideId}`,
         includeAuthorizationHeader: false,

packages/shared/sdk-client/__tests__/LDClientImpl.storage.test.ts

@@ -662,9 +662,7 @@ describe('sdk-client storage', () => {
     };
 
     // Set up storage with legacy keys, current keys, and other keys
-    mockPlatform.storage.get.mockImplementation((storageKey: string) => {
-      return storage[storageKey];
-    });
+    mockPlatform.storage.get.mockImplementation((storageKey: string) => storage[storageKey]);
 
     const legacyKeys = ['legacyKey1', 'legacyKey2'];
     const internalOptions = {
@@ -686,6 +684,8 @@ describe('sdk-client storage', () => {
       internalOptions,
     );
 
+    await jest.runAllTimersAsync();
+
     expect(mockPlatform.storage.clear).toHaveBeenCalledWith('legacyKey1');
     expect(mockPlatform.storage.clear).toHaveBeenCalledWith('legacyKey2');
     expect(mockPlatform.storage.clear).toHaveBeenCalledTimes(2);

packages/shared/sdk-client/src/LDClientImpl.ts

@@ -165,18 +165,26 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
       this._hookRunner.addHook(getInspectorHook(this._inspectorManager));
     }
 
-    if (options.cleanOldPersistentData && internalOptions?.getLegacyStorageKeys && this.platform.storage) {
+    if (
+      options.cleanOldPersistentData &&
+      internalOptions?.getLegacyStorageKeys &&
+      this.platform.storage
+    ) {
       // NOTE: we are letting this fail silently because it's not critical and we don't want to block the client from initializing.
-      this.logger.debug('Cleaning old persistent data.');
-      Promise.all(
-        internalOptions.getLegacyStorageKeys().map((key) => this.platform.storage?.clear(key)),
-      )
-        .catch((error) => {
-          this.logger.error(`Error cleaning old persistent data: ${error}`);
-        })
-        .finally(() => {
-          this.logger.debug('Cleaned old persistent data.');
-        });
+      try {
+        this.logger.debug('Cleaning old persistent data.');
+        Promise.all(
+          internalOptions.getLegacyStorageKeys().map((key) => this.platform.storage?.clear(key)),
+        )
+          .catch((error) => {
+            this.logger.error(`Error cleaning old persistent data: ${error}`);
+          })
+          .finally(() => {
+            this.logger.debug('Cleaned old persistent data.');
+          });
+      } catch (error) {
+        this.logger.error(`Error cleaning old persistent data: ${error}`);
+      }
     }
   }