Skip to content

Commit 6f95c1f

Browse files
committed
fix: added logging when retrieving values from with edgkv lib fails
1 parent 18bb6f5 commit 6f95c1f

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

packages/sdk/akamai-edgekv/src/edgekv/edgeKVProvider.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,27 @@
1-
import { EdgeProvider } from '@launchdarkly/akamai-edgeworker-sdk-common';
1+
import { BasicLogger, EdgeProvider } from '@launchdarkly/js-server-sdk-common';
22

33
import { EdgeKV } from './edgekv';
44

55
type EdgeKVProviderParams = {
66
namespace: string;
77
group: string;
8+
logger: BasicLogger;
89
};
910

1011
export default class EdgeKVProvider implements EdgeProvider {
1112
private edgeKv: EdgeKV;
13+
private logger: BasicLogger;
1214

13-
constructor({ namespace, group }: EdgeKVProviderParams) {
15+
constructor({ namespace, group, logger }: EdgeKVProviderParams) {
1416
this.edgeKv = new EdgeKV({ namespace, group } as any);
17+
this.logger = logger;
1518
}
1619

1720
async get(rootKey: string): Promise<string | null | undefined> {
1821
try {
1922
return await this.edgeKv.getText({ item: rootKey } as any);
2023
} catch (e) {
21-
/* empty */
24+
this.logger?.error(`Error getting value from EdgeKV: ${e}`);
2225
}
2326
return undefined;
2427
}

packages/sdk/akamai-edgekv/src/index.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import { init as initEdge, LDClient, LDOptions } from '@launchdarkly/akamai-edgeworker-sdk-common';
1212

1313
import EdgeKVProvider from './edgekv/edgeKVProvider';
14+
import { BasicLogger } from '@launchdarkly/js-server-sdk-common';
1415

1516
export * from '@launchdarkly/akamai-edgeworker-sdk-common';
1617

@@ -32,11 +33,14 @@ export const init = ({
3233
options = {},
3334
sdkKey,
3435
}: AkamaiLDClientParams): LDClient => {
35-
const edgekvProvider = new EdgeKVProvider({ namespace, group });
36+
const logger = options.logger ?? BasicLogger.get();
37+
38+
const edgekvProvider = new EdgeKVProvider({ namespace, group, logger });
39+
3640

3741
return initEdge({
3842
sdkKey,
39-
options,
43+
options: { ...options, logger },
4044
featureStoreProvider: edgekvProvider,
4145
platformName: 'Akamai EdgeWorker',
4246
sdkName: '@launchdarkly/akamai-server-edgekv-sdk',

0 commit comments

Comments
 (0)