Skip to content

Commit 7722641

Browse files
kinyoklionkinyoklion
committed
Cleanup sdk client tests.
1 parent b3b724f commit 7722641

File tree

6 files changed

+63
-327
lines changed

6 files changed

+63
-327
lines changed

‎packages/shared/sdk-client/__tests__/LDClientImpl.events.test.ts‎

Lines changed: 3 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,14 @@ import {
1616
} from '@launchdarkly/private-js-mocks';
1717

1818
import { Configuration } from '../src/configuration/Configuration';
19+
import { DataManagerFactory } from '../src/DataManager';
1920
import { FlagManager } from '../src/flag-manager/FlagManager';
2021
import LDClientImpl from '../src/LDClientImpl';
2122
import LDEmitter from '../src/LDEmitter';
2223
import { Flags } from '../src/types';
2324
import * as mockResponseJson from './evaluation/mockResponse.json';
2425
import { MockEventSource } from './streaming/LDClientImpl.mocks';
25-
import TestDataManager from './TestDataManager';
26+
import TestDataManager, { makeTestDataManagerFactory } from './TestDataManager';
2627

2728
type InputCustomEvent = internal.InputCustomEvent;
2829
type InputIdentifyEvent = internal.InputIdentifyEvent;
@@ -93,38 +94,7 @@ describe('sdk-client object', () => {
9394
{
9495
logger,
9596
},
96-
(
97-
flagManager: FlagManager,
98-
configuration: Configuration,
99-
baseHeaders: LDHeaders,
100-
emitter: LDEmitter,
101-
diagnosticsManager?: internal.DiagnosticsManager,
102-
) =>
103-
new TestDataManager(
104-
mockPlatform,
105-
flagManager,
106-
testSdkKey,
107-
configuration,
108-
() => ({
109-
pathGet(encoding: Encoding, _plainContextString: string): string {
110-
return `/msdk/evalx/contexts/${base64UrlEncode(_plainContextString, encoding)}`;
111-
},
112-
pathReport(_encoding: Encoding, _plainContextString: string): string {
113-
return `/msdk/evalx/context`;
114-
},
115-
}),
116-
() => ({
117-
pathGet(_encoding: Encoding, _plainContextString: string): string {
118-
return '/stream/path';
119-
},
120-
pathReport(_encoding: Encoding, _plainContextString: string): string {
121-
return '/stream/path';
122-
},
123-
}),
124-
baseHeaders,
125-
emitter,
126-
diagnosticsManager,
127-
),
97+
makeTestDataManagerFactory(testSdkKey, mockPlatform),
12898
);
12999
});
130100

‎packages/shared/sdk-client/__tests__/LDClientImpl.storage.test.ts‎

Lines changed: 3 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import LDEmitter from '../src/LDEmitter';
1717
import { Flags, PatchFlag } from '../src/types';
1818
import * as mockResponseJson from './evaluation/mockResponse.json';
1919
import { MockEventSource } from './streaming/LDClientImpl.mocks';
20-
import TestDataManager from './TestDataManager';
20+
import TestDataManager, { makeTestDataManagerFactory } from './TestDataManager';
2121

2222
let mockPlatform: ReturnType<typeof createBasicPlatform>;
2323
let logger: ReturnType<typeof createLogger>;
@@ -70,38 +70,7 @@ describe('sdk-client storage', () => {
7070
logger,
7171
sendEvents: false,
7272
},
73-
(
74-
flagManager: FlagManager,
75-
configuration: Configuration,
76-
baseHeaders: LDHeaders,
77-
inEmitter: LDEmitter,
78-
diagnosticsManager?: internal.DiagnosticsManager,
79-
) =>
80-
new TestDataManager(
81-
mockPlatform,
82-
flagManager,
83-
testSdkKey,
84-
configuration,
85-
() => ({
86-
pathGet(encoding: Encoding, _plainContextString: string): string {
87-
return `/msdk/evalx/contexts/${base64UrlEncode(_plainContextString, encoding)}`;
88-
},
89-
pathReport(_encoding: Encoding, _plainContextString: string): string {
90-
return `/msdk/evalx/context`;
91-
},
92-
}),
93-
() => ({
94-
pathGet(_encoding: Encoding, _plainContextString: string): string {
95-
return '/stream/path/get';
96-
},
97-
pathReport(_encoding: Encoding, _plainContextString: string): string {
98-
return '/stream/path/report';
99-
},
100-
}),
101-
baseHeaders,
102-
inEmitter,
103-
diagnosticsManager,
104-
),
73+
makeTestDataManagerFactory(testSdkKey, mockPlatform),
10574
);
10675

10776
// @ts-ignore
@@ -167,38 +136,7 @@ describe('sdk-client storage', () => {
167136
logger,
168137
sendEvents: false,
169138
},
170-
(
171-
flagManager: FlagManager,
172-
configuration: Configuration,
173-
baseHeaders: LDHeaders,
174-
inEmitter: LDEmitter,
175-
diagnosticsManager?: internal.DiagnosticsManager,
176-
) =>
177-
new TestDataManager(
178-
mockPlatform,
179-
flagManager,
180-
testSdkKey,
181-
configuration,
182-
() => ({
183-
pathGet(encoding: Encoding, _plainContextString: string): string {
184-
return `/msdk/evalx/contexts/${base64UrlEncode(_plainContextString, encoding)}`;
185-
},
186-
pathReport(_encoding: Encoding, _plainContextString: string): string {
187-
return `/msdk/evalx/context`;
188-
},
189-
}),
190-
() => ({
191-
pathGet(_encoding: Encoding, _plainContextString: string): string {
192-
return '/stream/path/get';
193-
},
194-
pathReport(_encoding: Encoding, _plainContextString: string): string {
195-
return '/stream/path/report';
196-
},
197-
}),
198-
baseHeaders,
199-
inEmitter,
200-
diagnosticsManager,
201-
),
139+
makeTestDataManagerFactory(testSdkKey, mockPlatform),
202140
);
203141
// @ts-ignore
204142
emitter = ldc.emitter;

‎packages/shared/sdk-client/__tests__/LDClientImpl.test.ts‎

Lines changed: 5 additions & 129 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import LDEmitter from '../src/LDEmitter';
1717
import { Flags } from '../src/types';
1818
import * as mockResponseJson from './evaluation/mockResponse.json';
1919
import { MockEventSource } from './streaming/LDClientImpl.mocks';
20-
import TestDataManager from './TestDataManager';
20+
import TestDataManager, { makeTestDataManagerFactory } from './TestDataManager';
2121

2222
const testSdkKey = 'test-sdk-key';
2323
const context: LDContext = { kind: 'org', key: 'Testy Pizza' };
@@ -78,38 +78,7 @@ describe('sdk-client object', () => {
7878
logger,
7979
sendEvents: false,
8080
},
81-
(
82-
flagManager: FlagManager,
83-
configuration: Configuration,
84-
baseHeaders: LDHeaders,
85-
emitter: LDEmitter,
86-
diagnosticsManager?: internal.DiagnosticsManager,
87-
) =>
88-
new TestDataManager(
89-
mockPlatform,
90-
flagManager,
91-
testSdkKey,
92-
configuration,
93-
() => ({
94-
pathGet(encoding: Encoding, _plainContextString: string): string {
95-
return `/msdk/evalx/contexts/${base64UrlEncode(_plainContextString, encoding)}`;
96-
},
97-
pathReport(_encoding: Encoding, _plainContextString: string): string {
98-
return `/msdk/evalx/context`;
99-
},
100-
}),
101-
() => ({
102-
pathGet(_encoding: Encoding, _plainContextString: string): string {
103-
return '/stream/path/get';
104-
},
105-
pathReport(_encoding: Encoding, _plainContextString: string): string {
106-
return '/stream/path/report';
107-
},
108-
}),
109-
baseHeaders,
110-
emitter,
111-
diagnosticsManager,
112-
),
81+
makeTestDataManagerFactory(testSdkKey, mockPlatform),
11382
);
11483
});
11584

@@ -185,38 +154,7 @@ describe('sdk-client object', () => {
185154
sendEvents: false,
186155
withReasons: true,
187156
},
188-
(
189-
flagManager: FlagManager,
190-
configuration: Configuration,
191-
baseHeaders: LDHeaders,
192-
emitter: LDEmitter,
193-
diagnosticsManager?: internal.DiagnosticsManager,
194-
) =>
195-
new TestDataManager(
196-
mockPlatform,
197-
flagManager,
198-
testSdkKey,
199-
configuration,
200-
() => ({
201-
pathGet(encoding: Encoding, _plainContextString: string): string {
202-
return `/msdk/evalx/contexts/${base64UrlEncode(_plainContextString, encoding)}`;
203-
},
204-
pathReport(_encoding: Encoding, _plainContextString: string): string {
205-
return `/msdk/evalx/context`;
206-
},
207-
}),
208-
() => ({
209-
pathGet(encoding: Encoding, _plainContextString: string): string {
210-
return `/meval/${base64UrlEncode(_plainContextString, encoding)}`;
211-
},
212-
pathReport(_encoding: Encoding, _plainContextString: string): string {
213-
return `/meval`;
214-
},
215-
}),
216-
baseHeaders,
217-
emitter,
218-
diagnosticsManager,
219-
),
157+
makeTestDataManagerFactory(testSdkKey, mockPlatform),
220158
);
221159

222160
await ldc.identify(carContext);
@@ -247,38 +185,7 @@ describe('sdk-client object', () => {
247185
sendEvents: false,
248186
useReport: true,
249187
},
250-
(
251-
flagManager: FlagManager,
252-
configuration: Configuration,
253-
baseHeaders: LDHeaders,
254-
emitter: LDEmitter,
255-
diagnosticsManager?: internal.DiagnosticsManager,
256-
) =>
257-
new TestDataManager(
258-
mockPlatform,
259-
flagManager,
260-
testSdkKey,
261-
configuration,
262-
() => ({
263-
pathGet(encoding: Encoding, _plainContextString: string): string {
264-
return `/msdk/evalx/contexts/${base64UrlEncode(_plainContextString, encoding)}`;
265-
},
266-
pathReport(_encoding: Encoding, _plainContextString: string): string {
267-
return `/msdk/evalx/context`;
268-
},
269-
}),
270-
() => ({
271-
pathGet(_encoding: Encoding, _plainContextString: string): string {
272-
return '/stream/path/get';
273-
},
274-
pathReport(_encoding: Encoding, _plainContextString: string): string {
275-
return '/stream/path/report';
276-
},
277-
}),
278-
baseHeaders,
279-
emitter,
280-
diagnosticsManager,
281-
),
188+
makeTestDataManagerFactory(testSdkKey, mockPlatform),
282189
);
283190

284191
await ldc.identify(carContext);
@@ -302,38 +209,7 @@ describe('sdk-client object', () => {
302209
logger,
303210
sendEvents: false,
304211
},
305-
(
306-
flagManager: FlagManager,
307-
configuration: Configuration,
308-
baseHeaders: LDHeaders,
309-
emitter: LDEmitter,
310-
diagnosticsManager?: internal.DiagnosticsManager,
311-
) =>
312-
new TestDataManager(
313-
mockPlatform,
314-
flagManager,
315-
testSdkKey,
316-
configuration,
317-
() => ({
318-
pathGet(encoding: Encoding, _plainContextString: string): string {
319-
return `/msdk/evalx/contexts/${base64UrlEncode(_plainContextString, encoding)}`;
320-
},
321-
pathReport(_encoding: Encoding, _plainContextString: string): string {
322-
return `/msdk/evalx/context`;
323-
},
324-
}),
325-
() => ({
326-
pathGet(encoding: Encoding, _plainContextString: string): string {
327-
return `/meval/${base64UrlEncode(_plainContextString, encoding)}`;
328-
},
329-
pathReport(_encoding: Encoding, _plainContextString: string): string {
330-
return `/meval`;
331-
},
332-
}),
333-
baseHeaders,
334-
emitter,
335-
diagnosticsManager,
336-
),
212+
makeTestDataManagerFactory(testSdkKey, mockPlatform),
337213
);
338214

339215
await ldc.identify(carContext);

0 commit comments

Comments
 (0)