fix: Fix breadcrumb filter option parsing. (#742)

There was a mistake in checking the filters option for breadcrumbs. This
fixes the issue and ensures the all options parsing doesn't have any
warnings logged.

Author: kinyoklion

packages/telemetry/browser-telemetry/__tests__/options.test.ts

@@ -1,3 +1,4 @@
+import { Breadcrumb } from '../src/api/Breadcrumb';
 import ErrorCollector from '../src/collectors/error';
 import parse, { defaultOptions } from '../src/options';
 
@@ -15,14 +16,15 @@ it('handles an empty configuration', () => {
 });
 
 it('can set all options at once', () => {
+  const filter = (breadcrumb: Breadcrumb) => breadcrumb;
   const outOptions = parse({
     maxPendingEvents: 1,
     breadcrumbs: {
       maxBreadcrumbs: 1,
       click: false,
       evaluations: false,
       flagChange: false,
-      filters: [(breadcrumb) => breadcrumb],
+      filters: [filter],
     },
     collectors: [new ErrorCollector(), new ErrorCollector()],
   });
@@ -39,7 +41,7 @@ it('can set all options at once', () => {
         instrumentFetch: true,
         instrumentXhr: true,
       },
-      filters: expect.any(Array),
+      filters: expect.arrayContaining([filter]),
     },
     stack: {
       source: {
@@ -50,6 +52,7 @@ it('can set all options at once', () => {
     },
     collectors: [new ErrorCollector(), new ErrorCollector()],
   });
+  expect(mockLogger.warn).not.toHaveBeenCalled();
 });
 
 it('warns when maxPendingEvents is not a number', () => {
@@ -435,6 +438,6 @@ it('warns when filters is not an array', () => {
   );
   expect(outOptions.breadcrumbs.filters).toEqual([]);
   expect(mockLogger.warn).toHaveBeenCalledWith(
-    'LaunchDarkly - Browser Telemetry: Config option "breadcrumbs.filters" should be of type array, got string, using default value',
+    'LaunchDarkly - Browser Telemetry: Config option "breadcrumbs.filters" should be of type BreadcrumbFilter[], got string, using default value',
   );
 });

packages/telemetry/browser-telemetry/src/options.ts

@@ -187,11 +187,13 @@ export default function parse(options: Options, logger?: MinLogger): ParsedOptio
         checkBasic('boolean', 'breadcrumbs.keyboardInput', logger),
       ),
       http: parseHttp(options.breadcrumbs?.http, defaults.breadcrumbs.http, logger),
-      filters: itemOrDefault(
-        options.breadcrumbs?.filters,
-        defaults.breadcrumbs.filters,
-        checkBasic('array', 'breadcrumbs.filters', logger),
-      ),
+      filters: itemOrDefault(options.breadcrumbs?.filters, defaults.breadcrumbs.filters, (item) => {
+        if (Array.isArray(item)) {
+          return true;
+        }
+        logger?.warn(wrongOptionType('breadcrumbs.filters', 'BreadcrumbFilter[]', typeof item));
+        return false;
+      }),
     },
     stack: parseStack(options.stack, defaults.stack),
     maxPendingEvents: itemOrDefault(