Skip to content

Commit 8993970

Browse files
committed
Add configurable size limit.
1 parent 7730579 commit 8993970

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

.github/workflows/browser.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,3 +41,4 @@ jobs:
4141
target_file: 'packages/sdk/browser/dist/index.js'
4242
package_name: '@launchdarkly/js-client-sdk'
4343
pr_number: ${{ github.event.number }}
44+
size_limit: 21000

.github/workflows/common.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,4 @@ jobs:
3333
target_file: 'packages/shared/common/dist/esm/index.mjs'
3434
package_name: '@launchdarkly/js-sdk-common'
3535
pr_number: ${{ github.event.number }}
36+
size_limit: 21000

.github/workflows/sdk-client.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,4 @@ jobs:
3030
target_file: 'packages/shared/sdk-client/dist/esm/index.mjs'
3131
package_name: '@launchdarkly/js-client-sdk-common'
3232
pr_number: ${{ github.event.number }}
33+
size_limit: 20000

actions/package-size/action.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ inputs:
1111
description: 'The name of the package'
1212
required: true
1313
pr_number:
14-
description: 'Th PR number'
14+
description: 'The PR number'
15+
required: true
16+
size_limit:
17+
description: 'The maximum size of the library'
1518
required: true
1619
runs:
1720
using: composite
@@ -44,6 +47,7 @@ runs:
4447
${{ inputs.package_name }} size report
4548
This is the brotli compressed size of the ESM build.
4649
Size: ${{ env.PACK_SIZE }} bytes
50+
Size limit: ${{ inputs.size_limit }}
4751
4852
- name: Update comment
4953
if: steps.fc.outputs.comment-id != ''
@@ -55,8 +59,9 @@ runs:
5559
${{ inputs.package_name }} size report
5660
This is the brotli compressed size of the ESM build.
5761
Size: ${{ env.PACK_SIZE }} bytes
62+
Size limit: ${{ inputs.size_limit }}
5863
5964
- name: Check package size limit
6065
shell: bash
6166
run: |
62-
[ $PACK_SIZE -le 25000 ] || exit 1
67+
[ $PACK_SIZE -le ${{ inputs.size_limit }} ] || exit 1

0 commit comments

Comments
 (0)