chore: Remove shared mocks package. (#601)

The dependencies between the mocks, and the unpublished nature of the
package, made maintenance complex. Additionally the mocks themselves
cause the tests to be harder to maintain and understand.

This PR changes all test dependencies to be in their own project. If we
need shared test code, then we could make shared code and not a package.

The main motivator for removal is the circular dependency relationship
between the mocks and common. Updating common to support ESM is made
more difficult, but needs to be done.

Overall this makes things much simpler at the cost of a couple hundred
lines of total duplication. (As indicated by the PR additions versus
subtractions.) There was code that was shared that was actually only
used in singular test locations.

Fixes SDK-729.

Author: kinyoklion

.github/workflows/mocks.yml

@@ -16,7 +16,6 @@ on:
       - 'packages/shared/common/**'
       - 'packages/shared/sdk-client/**'
       - 'packages/sdk/react-native/**'
-      - 'packages/shared/mocks/**'
 
 jobs:
   detox-android:

.github/workflows/react-native-detox.yml

@@ -2,7 +2,6 @@
   "name": "@launchdarkly/js-core",
   "workspaces": [
     "packages/shared/common",
-    "packages/shared/mocks",
     "packages/shared/sdk-client",
     "packages/shared/sdk-server",
     "packages/shared/sdk-server-edge",

package.json

@@ -40,7 +40,6 @@
   },
   "devDependencies": {
     "@jest/globals": "^29.7.0",
-    "@launchdarkly/private-js-mocks": "0.0.1",
     "@rollup/plugin-commonjs": "^25.0.0",
     "@rollup/plugin-json": "^6.1.0",
     "@rollup/plugin-node-resolve": "^15.0.2",

packages/sdk/browser/package.json

@@ -3,15 +3,7 @@
   "version": "2.5.14",
   "exports": "./src/index.ts",
   "publish": {
-    "include": [
-      "LICENSE",
-      "README.md",
-      "package.json",
-      "jsr.json",
-      "src/**/*.ts"
-    ],
-    "exclude": [
-      "src/**/*.test.ts"
-    ]
+    "include": ["LICENSE", "README.md", "package.json", "jsr.json", "src/**/*.ts"],
+    "exclude": ["src/**/*.test.ts"]
   }
 }

packages/sdk/cloudflare/jsr.json

@@ -1,15 +1,19 @@
-import { type EventName } from '@launchdarkly/js-client-sdk-common';
-import { createLogger } from '@launchdarkly/private-js-mocks';
+import { type EventName, LDLogger } from '@launchdarkly/js-client-sdk-common';
 
 import EventSource, {
   backoff,
   jitter,
 } from '../../../src/fromExternal/react-native-sse/EventSource';
 
-let logger: ReturnType<typeof createLogger>;
+let logger: LDLogger;
 
 beforeEach(() => {
-  logger = createLogger();
+  logger = {
+    error: jest.fn(),
+    warn: jest.fn(),
+    info: jest.fn(),
+    debug: jest.fn(),
+  };
 });
 
 describe('EventSource', () => {

packages/sdk/react-native/__tests__/fromExternal/react-native-sse/EventSource.test.ts

@@ -46,7 +46,6 @@
     "base64-js": "^1.5.1"
   },
   "devDependencies": {
-    "@launchdarkly/private-js-mocks": "0.0.1",
     "@testing-library/react": "^14.1.2",
     "@trivago/prettier-plugin-sort-imports": "^4.1.1",
     "@types/jest": "^29.5.11",

packages/sdk/react-native/package.json

@@ -1,15 +1,18 @@
-import { integrations } from '@launchdarkly/js-server-sdk-common';
-import { createLogger } from '@launchdarkly/private-js-mocks';
+import { integrations, LDLogger } from '@launchdarkly/js-server-sdk-common';
 
 import { Context, LDClient } from '../src';
 import LDClientNode from '../src/LDClientNode';
 
-let logger: ReturnType<typeof createLogger>;
+let logger: LDLogger;
 
 beforeEach(() => {
-  logger = createLogger();
+  logger = {
+    error: jest.fn(),
+    warn: jest.fn(),
+    info: jest.fn(),
+    debug: jest.fn(),
+  };
 });
-
 describe('given an LDClient with test data', () => {
   let client: LDClient;
   let td: integrations.TestData;

packages/sdk/server-node/__tests__/LDClientNode.listeners.test.ts

@@ -1,12 +1,16 @@
-import { LDContext } from '@launchdarkly/js-server-sdk-common';
-import { createLogger } from '@launchdarkly/private-js-mocks';
+import { LDContext, LDLogger } from '@launchdarkly/js-server-sdk-common';
 
 import { init } from '../src';
 
-let logger: ReturnType<typeof createLogger>;
+let logger: LDLogger;
 
 beforeEach(() => {
-  logger = createLogger();
+  logger = {
+    error: jest.fn(),
+    warn: jest.fn(),
+    info: jest.fn(),
+    debug: jest.fn(),
+  };
 });
 
 it('fires ready event in offline mode', (done) => {

packages/sdk/server-node/__tests__/LDClientNode.test.ts

@@ -6,15 +6,18 @@ import {
   TestHttpServer,
 } from 'launchdarkly-js-test-helpers';
 
-import { createLogger } from '@launchdarkly/private-js-mocks';
-
-import { LDClient } from '../src';
+import { LDClient, LDLogger } from '../src';
 import LDClientNode from '../src/LDClientNode';
 
-let logger: ReturnType<typeof createLogger>;
+let logger: LDLogger;
 
 beforeEach(() => {
-  logger = createLogger();
+  logger = {
+    error: jest.fn(),
+    warn: jest.fn(),
+    info: jest.fn(),
+    debug: jest.fn(),
+  };
 });
 
 describe('When using a TLS connection', () => {