chore: hide mapper and expose methods directly on config object

Author: abarker-launchdarkly

packages/sdk/server-ai/__tests__/LDAIClientImpl.test.ts

@@ -56,8 +56,8 @@ it('returns config with interpolated messagess', async () => {
       { role: 'user', content: 'Score: 42' },
     ],
     tracker: expect.any(Object),
-    mapper: expect.any(Object),
     enabled: true,
+    toVercelAISDK: expect.any(Function),
   });
 });
 
@@ -102,8 +102,8 @@ it('handles missing metadata in variation', async () => {
     model: { name: 'example-provider', parameters: { name: 'imagination' } },
     messages: [{ role: 'system', content: 'Hello' }],
     tracker: expect.any(Object),
-    mapper: expect.any(Object),
     enabled: false,
+    toVercelAISDK: expect.any(Function),
   });
 });
 
@@ -126,8 +126,8 @@ it('passes the default value to the underlying client', async () => {
     messages: defaultValue.messages,
     provider: defaultValue.provider,
     tracker: expect.any(Object),
-    mapper: expect.any(Object),
     enabled: false,
+    toVercelAISDK: expect.any(Function),
   });
 
   expect(mockLdClient.variation).toHaveBeenCalledWith(key, testContext, defaultValue);

…i/__tests__/LDAIConfigMapperImpl.test.ts …er-ai/__tests__/LDAIConfigMapper.test.tspackages/sdk/server-ai/__tests__/LDAIConfigMapperImpl.test.ts renamed to packages/sdk/server-ai/__tests__/LDAIConfigMapper.test.ts packages/sdk/server-ai/__tests__/LDAIConfigMapperImpl.test.ts renamed to packages/sdk/server-ai/__tests__/LDAIConfigMapper.test.ts

@@ -1,15 +1,15 @@
 import { LDMessage, VercelAISDKMapOptions } from '../src/api/config';
-import { LDAIConfigMapperImpl } from '../src/LDAIConfigMapperImpl';
+import { LDAIConfigMapper } from '../src/LDAIConfigMapper';
 
 describe('_findParameter', () => {
   it('handles undefined model and messages', () => {
-    const mapper = new LDAIConfigMapperImpl();
+    const mapper = new LDAIConfigMapper();
     // eslint-disable-next-line @typescript-eslint/dot-notation
     expect(mapper['_findParameter']<number>('test-param')).toBeUndefined();
   });
 
   it('handles parameter not found', () => {
-    const mapper = new LDAIConfigMapperImpl({
+    const mapper = new LDAIConfigMapper({
       name: 'test-ai-model',
       parameters: {
         'test-param': 123,
@@ -23,7 +23,7 @@ describe('_findParameter', () => {
   });
 
   it('finds parameter from single model parameter', () => {
-    const mapper = new LDAIConfigMapperImpl({
+    const mapper = new LDAIConfigMapper({
       name: 'test-ai-model',
       parameters: {
         'test-param': 123,
@@ -34,7 +34,7 @@ describe('_findParameter', () => {
   });
 
   it('finds parameter from multiple model parameters', () => {
-    const mapper = new LDAIConfigMapperImpl({
+    const mapper = new LDAIConfigMapper({
       name: 'test-ai-model',
       parameters: {
         testParam: 123,
@@ -45,7 +45,7 @@ describe('_findParameter', () => {
   });
 
   it('finds parameter from single model custom parameter', () => {
-    const mapper = new LDAIConfigMapperImpl({
+    const mapper = new LDAIConfigMapper({
       name: 'test-ai-model',
       custom: {
         'test-param': 123,
@@ -56,7 +56,7 @@ describe('_findParameter', () => {
   });
 
   it('finds parameter from multiple model custom parameters', () => {
-    const mapper = new LDAIConfigMapperImpl({
+    const mapper = new LDAIConfigMapper({
       name: 'test-ai-model',
       custom: {
         testParam: 123,
@@ -67,7 +67,7 @@ describe('_findParameter', () => {
   });
 
   it('gives precedence to model parameters over model custom parameters', () => {
-    const mapper = new LDAIConfigMapperImpl({
+    const mapper = new LDAIConfigMapper({
       name: 'test-ai-model',
       parameters: {
         'test-param': 123,
@@ -97,7 +97,7 @@ describe('toVercelAIAISDK', () => {
   });
 
   it('handles undefined model and messages', () => {
-    const mapper = new LDAIConfigMapperImpl();
+    const mapper = new LDAIConfigMapper();
     const result = mapper.toVercelAISDK(mockProvider);
 
     expect(mockProvider).toHaveBeenCalledWith('');
@@ -110,7 +110,7 @@ describe('toVercelAIAISDK', () => {
   });
 
   it('uses additional messages', () => {
-    const mapper = new LDAIConfigMapperImpl({ name: 'test-ai-model' });
+    const mapper = new LDAIConfigMapper({ name: 'test-ai-model' });
     const result = mapper.toVercelAISDK(mockProvider, mockOptions);
 
     expect(mockProvider).toHaveBeenCalledWith('test-ai-model');
@@ -123,7 +123,7 @@ describe('toVercelAIAISDK', () => {
   });
 
   it('combines config messages and additional messages', () => {
-    const mapper = new LDAIConfigMapperImpl({ name: 'test-ai-model' }, undefined, mockMessages);
+    const mapper = new LDAIConfigMapper({ name: 'test-ai-model' }, undefined, mockMessages);
     const result = mapper.toVercelAISDK(mockProvider, mockOptions);
 
     expect(mockProvider).toHaveBeenCalledWith('test-ai-model');
@@ -136,7 +136,7 @@ describe('toVercelAIAISDK', () => {
   });
 
   it('requests parameters correctly', () => {
-    const mapper = new LDAIConfigMapperImpl({ name: 'test-ai-model' }, undefined, mockMessages);
+    const mapper = new LDAIConfigMapper({ name: 'test-ai-model' }, undefined, mockMessages);
     const findParameterMock = jest.spyOn(mapper as any, '_findParameter');
     const result = mapper.toVercelAISDK(mockProvider);
 

packages/sdk/server-ai/src/LDAIClientImpl.ts

@@ -2,9 +2,18 @@ import * as Mustache from 'mustache';
 
 import { LDContext } from '@launchdarkly/js-server-sdk-common';
 
-import { LDAIConfig, LDAIDefaults, LDMessage, LDModelConfig, LDProviderConfig } from './api/config';
+import {
+  LDAIConfig,
+  LDAIDefaults,
+  LDMessage,
+  LDModelConfig,
+  LDProviderConfig,
+  VercelAISDKConfig,
+  VercelAISDKMapOptions,
+  VercelAISDKProvider,
+} from './api/config';
 import { LDAIClient } from './api/LDAIClient';
-import { LDAIConfigMapperImpl } from './LDAIConfigMapperImpl';
+import { LDAIConfigMapper } from './LDAIConfigMapper';
 import { LDAIConfigTrackerImpl } from './LDAIConfigTrackerImpl';
 import { LDClientMin } from './LDClientMin';
 
@@ -53,7 +62,7 @@ export class LDAIClientImpl implements LDAIClient {
     );
     // eslint-disable-next-line no-underscore-dangle
     const enabled = !!value._ldMeta?.enabled;
-    const config: Omit<LDAIConfig, 'mapper'> = {
+    const config: Omit<LDAIConfig, 'toVercelAISDK'> = {
       tracker,
       enabled,
     };
@@ -74,9 +83,14 @@ export class LDAIClientImpl implements LDAIClient {
       }));
     }
 
+    const mapper = new LDAIConfigMapper(config.model, config.provider, config.messages);
+
     return {
       ...config,
-      mapper: new LDAIConfigMapperImpl(config.model, config.provider, config.messages),
+      toVercelAISDK: <TMod>(
+        provider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
+        options?: VercelAISDKMapOptions | undefined,
+      ): VercelAISDKConfig<TMod> => mapper.toVercelAISDK(provider, options),
     };
   }
 }

…dk/server-ai/src/LDAIConfigMapperImpl.ts …es/sdk/server-ai/src/LDAIConfigMapper.tspackages/sdk/server-ai/src/LDAIConfigMapperImpl.ts renamed to packages/sdk/server-ai/src/LDAIConfigMapper.ts packages/sdk/server-ai/src/LDAIConfigMapperImpl.ts renamed to packages/sdk/server-ai/src/LDAIConfigMapper.ts

@@ -1,5 +1,4 @@
 import {
-  LDAIConfigMapper,
   LDMessage,
   LDModelConfig,
   LDProviderConfig,
@@ -8,7 +7,7 @@ import {
   VercelAISDKProvider,
 } from './api/config';
 
-export class LDAIConfigMapperImpl implements LDAIConfigMapper {
+export class LDAIConfigMapper {
   constructor(
     private _model?: LDModelConfig | undefined,
     private _provider?: LDProviderConfig | undefined,

packages/sdk/server-ai/src/api/config/LDAIConfig.ts

@@ -1,5 +1,5 @@
-import { LDAIConfigMapper } from './LDAIConfigMapper';
 import { LDAIConfigTracker } from './LDAIConfigTracker';
+import { VercelAISDKConfig, VercelAISDKMapOptions, VercelAISDKProvider } from './VercelAISDK';
 
 /**
  * Configuration related to the model.
@@ -66,21 +66,29 @@ export interface LDAIConfig {
   tracker: LDAIConfigTracker;
 
   /**
-   * A mapper which can be used to map configuration for selected supported providers.
+   * Whether the configuration is enabled.
    */
-  mapper: LDAIConfigMapper;
+  enabled: boolean;
 
   /**
-   * Whether the configuration is enabled.
+   * Maps this AI config to a format usable direcly in Vercel AI SDK generateText()
+   * and streamText() methods.
+   *
+   * @param provider A Vercel AI SDK Provider or a map of provider names to Vercel AI SDK Providers.
+   * @param options Optional mapping options.
+   * @returns A configuration directly usable in Vercel AI SDK generateText() and streamText()
    */
-  enabled: boolean;
+  toVercelAISDK: <TMod>(
+    provider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
+    options?: VercelAISDKMapOptions | undefined,
+  ) => VercelAISDKConfig<TMod>;
 }
 
 /**
  * Default value for a `modelConfig`. This is the same as the LDAIConfig, but it does not include
  * a tracker or mapper, and `enabled` is optional.
  */
-export type LDAIDefaults = Omit<LDAIConfig, 'tracker' | 'mapper' | 'enabled'> & {
+export type LDAIDefaults = Omit<LDAIConfig, 'tracker' | 'enabled' | 'toVercelAISDK'> & {
   /**
    * Whether the configuration is enabled.
    *

…er-ai/src/api/config/LDAIConfigMapper.ts …/server-ai/src/api/config/VercelAISDK.tspackages/sdk/server-ai/src/api/config/LDAIConfigMapper.ts renamed to packages/sdk/server-ai/src/api/config/VercelAISDK.ts packages/sdk/server-ai/src/api/config/LDAIConfigMapper.ts renamed to packages/sdk/server-ai/src/api/config/VercelAISDK.ts

@@ -18,10 +18,3 @@ export interface VercelAISDKConfig<TMod> {
   stopSequences?: string[] | undefined;
   seed?: number | undefined;
 }
-
-export interface LDAIConfigMapper {
-  toVercelAISDK: <TMod>(
-    provider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
-    options?: VercelAISDKMapOptions | undefined,
-  ) => VercelAISDKConfig<TMod>;
-}

packages/sdk/server-ai/src/api/config/index.ts

@@ -1,3 +1,3 @@
 export * from './LDAIConfig';
-export * from './LDAIConfigMapper';
+export * from './VercelAISDK';
 export { LDAIConfigTracker } from './LDAIConfigTracker';