chore(test): Streaming mock fixes. Mock cleanup. (#549)

Author: kinyoklion

packages/shared/mocks/src/crypto.ts

@@ -1,12 +1,9 @@
 import type { Hasher } from '@common';
 
-// eslint-disable-next-line import/no-mutable-exports
-export let hasher: Hasher;
-
 export const setupCrypto = () => {
   let counter = 0;
-  hasher = {
-    update: jest.fn(() => hasher),
+  const hasher = {
+    update: jest.fn((): Hasher => hasher),
     digest: jest.fn(() => '1234567890123456'),
   };
 

packages/shared/mocks/src/hasher.ts

@@ -16,6 +16,10 @@ export const setupMockStreamingProcessor = (
   errorTimeoutSeconds: number = 0,
   initTimeoutMs: number = 0,
 ) => {
+  let initTimeoutHandle: any;
+  let patchTimeoutHandle: any;
+  let deleteTimeoutHandle: any;
+
   MockStreamingProcessor.mockImplementation(
     (
       sdkKey: string,
@@ -28,26 +32,36 @@ export const setupMockStreamingProcessor = (
     ) => ({
       start: jest.fn(async () => {
         if (shouldError) {
-          setTimeout(() => {
+          initTimeoutHandle = setTimeout(() => {
             const unauthorized = new Error('test-error') as LDStreamingError;
             // @ts-ignore
             unauthorized.code = 401;
             errorHandler(unauthorized);
           }, errorTimeoutSeconds * 1000);
         } else {
           // execute put which will resolve the identify promise
-          setTimeout(() => listeners.get('put')?.processJson(putResponseJson), initTimeoutMs);
+          initTimeoutHandle = setTimeout(() => {
+            listeners.get('put')?.processJson(putResponseJson);
+          }, initTimeoutMs);
 
           if (patchResponseJson) {
-            setTimeout(() => listeners.get('patch')?.processJson(patchResponseJson));
+            patchTimeoutHandle = setTimeout(() =>
+              listeners.get('patch')?.processJson(patchResponseJson),
+            );
           }
 
           if (deleteResponseJson) {
-            setTimeout(() => listeners.get('delete')?.processJson(deleteResponseJson));
+            deleteTimeoutHandle = setTimeout(() =>
+              listeners.get('delete')?.processJson(deleteResponseJson),
+            );
           }
         }
       }),
-      close: jest.fn(),
+      close: jest.fn(() => {
+        clearTimeout(initTimeoutHandle);
+        clearTimeout(patchTimeoutHandle);
+        clearTimeout(deleteTimeoutHandle);
+      }),
       eventSource: {},
     }),
   );

packages/shared/mocks/src/streamingProcessor.ts

@@ -57,11 +57,11 @@ describe('sdk-client object', () => {
     defaultPutResponse = clone<Flags>(mockResponseJson);
     setupMockStreamingProcessor(false, defaultPutResponse);
     mockPlatform.crypto.randomUUID.mockReturnValue('random1');
-    const hasher: Hasher = {
-      update: jest.fn(() => hasher),
+    const hasher = {
+      update: jest.fn((): Hasher => hasher),
       digest: jest.fn(() => 'digested1'),
     };
-    mockPlatform.crypto.createHash = jest.fn(() => hasher);
+    mockPlatform.crypto.createHash.mockReturnValue(hasher);
 
     ldc = new LDClientImpl(testSdkKey, AutoEnvAttributes.Enabled, mockPlatform, {
       logger,
@@ -72,7 +72,8 @@ describe('sdk-client object', () => {
       .mockReturnValue('/stream/path');
   });
 
-  afterEach(() => {
+  afterEach(async () => {
+    await ldc.close();
     jest.resetAllMocks();
   });
 

packages/shared/sdk-client/src/LDClientImpl.test.ts

@@ -85,11 +85,11 @@ describe('Bucketer.test', () => {
     ],
   ])('given bucketing parameters', (context, key, attr, salt, kindForRollout, seed, expected) => {
     it('hashes the correct string', () => {
-      const hasher: Hasher = {
-        update: jest.fn(() => hasher),
+      const hasher = {
+        update: jest.fn((): Hasher => hasher),
         digest: jest.fn(() => '1234567890123456'),
       };
-      mockPlatform.crypto.createHash = jest.fn(() => hasher);
+      mockPlatform.crypto.createHash.mockReturnValue(hasher);
 
       const validatedContext = Context.fromLDContext(context);
       const attrRef = new AttributeReference(attr);
@@ -120,11 +120,11 @@ describe('Bucketer.test', () => {
     ['bad', 'key'],
   ])('when given a non string or integer reference', (kind, attr) => {
     it('buckets to 0 when given bad data', () => {
-      const hasher: Hasher = {
-        update: jest.fn(() => hasher),
+      const hasher = {
+        update: jest.fn((): Hasher => hasher),
         digest: jest.fn(() => 'digested1'),
       };
-      mockPlatform.crypto.createHash = jest.fn(() => hasher);
+      mockPlatform.crypto.createHash.mockReturnValue(hasher);
 
       const validatedContext = Context.fromLDContext({
         key: 'context-key',